| Message ID | 20220930192954.242546-11-krzysztof.kozlowski@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | pinctrl/arm64: qcom: 4th set of Qualcomm TLMM pinctrl schema warnings | expand |
On 2022-09-30 21:29:48, Krzysztof Kozlowski wrote: > DT schema expects TLMM pin configuration nodes to be named with > '-state' suffix and their optional children with '-pins' suffix. > > Reviewed-by: Konrad Dybcio <konrad.dybcio@somainline.org> > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Thanks! Reviewed-by: Marijn Suijten <marijn.suijten@somainline.org> Perhaps mention more clearly that this is fixing up an earlier patch that tried to address missing `-pins`? - Marijn > --- > arch/arm64/boot/dts/qcom/sm6125.dtsi | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/sm6125.dtsi b/arch/arm64/boot/dts/qcom/sm6125.dtsi > index 1fe3fa3ad877..af49a748e511 100644 > --- a/arch/arm64/boot/dts/qcom/sm6125.dtsi > +++ b/arch/arm64/boot/dts/qcom/sm6125.dtsi > @@ -407,13 +407,13 @@ data-pins { > }; > > sdc2_on_state: sdc2-on-state { > - clk { > + clk-pins { > pins = "sdc2_clk"; > drive-strength = <16>; > bias-disable; > }; > > - cmd-pins-pins { > + cmd-pins { > pins = "sdc2_cmd"; > drive-strength = <10>; > bias-pull-up; > -- > 2.34.1 >
On 11/10/2022 03:45, Marijn Suijten wrote: > On 2022-09-30 21:29:48, Krzysztof Kozlowski wrote: >> DT schema expects TLMM pin configuration nodes to be named with >> '-state' suffix and their optional children with '-pins' suffix. >> >> Reviewed-by: Konrad Dybcio <konrad.dybcio@somainline.org> >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > Thanks! > > Reviewed-by: Marijn Suijten <marijn.suijten@somainline.org> > > Perhaps mention more clearly that this is fixing up an earlier patch > that tried to address missing `-pins`? It is not fixing only that patch, but also nodes added later without suffix. Best regards, Krzysztof
On 2022-10-11 08:06:55, Krzysztof Kozlowski wrote: > On 11/10/2022 03:45, Marijn Suijten wrote: > > On 2022-09-30 21:29:48, Krzysztof Kozlowski wrote: > >> DT schema expects TLMM pin configuration nodes to be named with > >> '-state' suffix and their optional children with '-pins' suffix. > >> > >> Reviewed-by: Konrad Dybcio <konrad.dybcio@somainline.org> > >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > > > Thanks! > > > > Reviewed-by: Marijn Suijten <marijn.suijten@somainline.org> > > > > Perhaps mention more clearly that this is fixing up an earlier patch > > that tried to address missing `-pins`? > > It is not fixing only that patch, but also nodes added later without suffix. Afaik the node was already there when [1] was applied, it just accidentally added -pins to cmd twice instead of once to clk and cmd separately. But feel free to stick to a generic commit message. [1]: https://lore.kernel.org/all/20220912061746.6311-35-krzysztof.kozlowski@linaro.org/ - Marijn
diff --git a/arch/arm64/boot/dts/qcom/sm6125.dtsi b/arch/arm64/boot/dts/qcom/sm6125.dtsi index 1fe3fa3ad877..af49a748e511 100644 --- a/arch/arm64/boot/dts/qcom/sm6125.dtsi +++ b/arch/arm64/boot/dts/qcom/sm6125.dtsi @@ -407,13 +407,13 @@ data-pins { }; sdc2_on_state: sdc2-on-state { - clk { + clk-pins { pins = "sdc2_clk"; drive-strength = <16>; bias-disable; }; - cmd-pins-pins { + cmd-pins { pins = "sdc2_cmd"; drive-strength = <10>; bias-pull-up;