| Message ID | 20221006140637.246665-1-krzysztof.kozlowski@linaro.org |
|---|---|
| Headers | show |
| Series | pinctrl/arm64: qcom: continued - fix Qualcomm TLMM pinctrl schema warnings (5th set) | expand |
On 06/10/2022 17:49, Stephan Gerhold wrote: >> .../qcom,sm8450-lpass-lpi-pinctrl.yaml | 13 ++-- >> .../bindings/pinctrl/qcom,sm8450-pinctrl.yaml | 22 ++---- > > Just a random thought since you are already doing minor style cleanups > here: Some of these files are named incorrectly, e.g. qcom,sm8450-pinctrl.yaml > actually documents "qcom,sm8450-tlmm". I noticed this while adding > qcom,msm8909-tlmm but I have to admit that it did not bother me enough > to actually prepare a patch for this (and now it would just conflict > with all your patches). :) > > No need to change anything here, just thought I'd mention it. Sure, I can change this as well. Thanks for sharing! Best regards, Krzysztof
On Thu, 06 Oct 2022 16:06:05 +0200, Krzysztof Kozlowski wrote: > The common Qualcomm TLMM pin controller schema already brings > requirement of function for GPIO pins. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- > .../bindings/pinctrl/qcom,sc7280-pinctrl.yaml | 11 +---------- > 1 file changed, 1 insertion(+), 10 deletions(-) > Acked-by: Rob Herring <robh@kernel.org>
On Thu, 06 Oct 2022 16:06:07 +0200, Krzysztof Kozlowski wrote: > The common Qualcomm TLMM pin controller schema already brings > requirement of function for GPIO pins. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- > .../bindings/pinctrl/qcom,sc8180x-pinctrl.yaml | 11 +---------- > 1 file changed, 1 insertion(+), 10 deletions(-) > Acked-by: Rob Herring <robh@kernel.org>
On Thu, 06 Oct 2022 16:06:09 +0200, Krzysztof Kozlowski wrote: > Reference common Qualcomm TLMM pin controller schema, to bring common > properties, other pinctrl schemas and additional checks, like function > required only for GPIOs. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- > .../bindings/pinctrl/qcom,sm6115-pinctrl.yaml | 44 +++---------------- > 1 file changed, 6 insertions(+), 38 deletions(-) > Acked-by: Rob Herring <robh@kernel.org>
On Thu, 06 Oct 2022 16:06:11 +0200, Krzysztof Kozlowski wrote: > The binding references common Qualcomm TLMM pin controller schema, which > references pinctrl.yaml. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- > .../devicetree/bindings/pinctrl/qcom,sm6125-pinctrl.yaml | 1 - > 1 file changed, 1 deletion(-) > Acked-by: Rob Herring <robh@kernel.org>
On Thu, 06 Oct 2022 16:06:14 +0200, Krzysztof Kozlowski wrote: > The binding references common Qualcomm TLMM pin controller schema, which > references pinctrl.yaml. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- > Documentation/devicetree/bindings/pinctrl/qcom,sm6375-tlmm.yaml | 1 - > 1 file changed, 1 deletion(-) > Acked-by: Rob Herring <robh@kernel.org>
On Thu, 06 Oct 2022 16:06:20 +0200, Krzysztof Kozlowski wrote: > Drop "binding" from description (and align it with other Qualcomm > pinctrl bindings), use double quotes consistently and drop redundant > quotes. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- > .../bindings/pinctrl/qcom,mdm9607-pinctrl.yaml | 15 +++++++-------- > 1 file changed, 7 insertions(+), 8 deletions(-) > Acked-by: Rob Herring <robh@kernel.org>
On Thu, 06 Oct 2022 16:06:30 +0200, Krzysztof Kozlowski wrote: > Drop "binding" from description (and align it with other Qualcomm > pinctrl bindings), drop redundant minItems, use double quotes > consistently and drop redundant quotes. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- > .../bindings/pinctrl/qcom,sm8250-pinctrl.yaml | 36 +++++++++---------- > 1 file changed, 17 insertions(+), 19 deletions(-) > Acked-by: Rob Herring <robh@kernel.org>
On Thu, 06 Oct 2022 16:06:32 +0200, Krzysztof Kozlowski wrote: > Drop "binding" from description (and align it with other Qualcomm > pinctrl bindings), use double quotes consistently and drop redundant > quotes. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- > .../bindings/pinctrl/qcom,sm8450-pinctrl.yaml | 11 +++++------ > 1 file changed, 5 insertions(+), 6 deletions(-) > Acked-by: Rob Herring <robh@kernel.org>
On Thu, 06 Oct 2022 16:06:34 +0200, Krzysztof Kozlowski wrote: > Drop "binding" from description (and align it with other Qualcomm > pinctrl bindings), drop redundant minItems, use double quotes > consistently and drop redundant quotes. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- > .../pinctrl/qcom,sm8250-lpass-lpi-pinctrl.yaml | 16 +++++++--------- > 1 file changed, 7 insertions(+), 9 deletions(-) > Acked-by: Rob Herring <robh@kernel.org>
On 17/10/2022 05:24, Linus Walleij wrote: > On Thu, Oct 6, 2022 at 4:06 PM Krzysztof Kozlowski > <krzysztof.kozlowski@linaro.org> wrote: > >> Patches are organized not by file, but rather type of change >> 1. First patches is for common TLMM schema and dropping unneeded refs. >> 2. Last patches are pure cleanups without functional impact. >> >> Overview >> ======== >> This is the *fifth* patchset around Qualcomm pinctrl in recent days: >> 1. First round of TLMM fixes: merged >> 2. LPASS fixes: >> https://lore.kernel.org/linux-devicetree/20220927153429.55365-1-krzysztof.kozlowski@linaro.org/ >> 3. ARMv7 TLMM fixes: >> https://lore.kernel.org/linux-devicetree/20221006124659.217540-1-krzysztof.kozlowski@linaro.org/ >> 4. ARMv8 remaining TLMM fixes: >> https://lore.kernel.org/linux-devicetree/20220930192954.242546-1-krzysztof.kozlowski@linaro.org/ >> 5. Fifth clean - styles and using common TLMM schema: *THIS PATCHSET* > > Blanket: > Acked-by: Linus Walleij <linus.walleij@linaro.org> > > Please send me pull requests for any parts that need to go into > the pinctrl tree. Will do. Best regards, Krzysztof
Hi, Patches are organized not by file, but rather type of change 1. First patches is for common TLMM schema and dropping unneeded refs. 2. Last patches are pure cleanups without functional impact. Overview ======== This is the *fifth* patchset around Qualcomm pinctrl in recent days: 1. First round of TLMM fixes: merged 2. LPASS fixes: https://lore.kernel.org/linux-devicetree/20220927153429.55365-1-krzysztof.kozlowski@linaro.org/ 3. ARMv7 TLMM fixes: https://lore.kernel.org/linux-devicetree/20221006124659.217540-1-krzysztof.kozlowski@linaro.org/ 4. ARMv8 remaining TLMM fixes: https://lore.kernel.org/linux-devicetree/20220930192954.242546-1-krzysztof.kozlowski@linaro.org/ 5. Fifth clean - styles and using common TLMM schema: *THIS PATCHSET* Dependencies ============ 1. Almost no dependencies - logically the bindings patch "dt-bindings: pinctrl: qcom,sm8250: drop checks used in common TLMM" depends on patchset #3 above. This is not a hard-dependency, everything will compile nicely, no warnings. 2. dt-bindings are independent of DTS patches. Best regards, Krzysztof Krzysztof Kozlowski (34): dt-bindings: pinctrl: qcom,mdm9607: drop ref to pinctrl.yaml dt-bindings: pinctrl: qcom,sc7280: drop checks used in common TLMM dt-bindings: pinctrl: qcom,sc8180x: drop ref to pinctrl.yaml dt-bindings: pinctrl: qcom,sc8180x: drop checks used in common TLMM dt-bindings: pinctrl: qcom,sc8280xp: drop checks used in common TLMM dt-bindings: pinctrl: qcom,sm6115: use common TLMM schema dt-bindings: pinctrl: qcom,sm6125: drop checks used in common TLMM dt-bindings: pinctrl: qcom,sm6125: drop ref to pinctrl.yaml dt-bindings: pinctrl: qcom,sm6350: drop ref to pinctrl.yaml dt-bindings: pinctrl: qcom,sm6350: drop checks used in common TLMM dt-bindings: pinctrl: qcom,sm6375-tlmm: drop ref to pinctrl.yaml dt-bindings: pinctrl: qcom,sm6375-tlmm: drop checks used in common TLMM dt-bindings: pinctrl: qcom,sm8250: use common TLMM schema dt-bindings: pinctrl: qcom,sm8350: drop ref to pinctrl.yaml dt-bindings: pinctrl: qcom,sm8350: drop checks used in common TLMM dt-bindings: pinctrl: qcom,sm8450: drop checks used in common TLMM dt-bindings: pinctrl: qcom,mdm9607: minor style cleanups dt-bindings: pinctrl: qcom,msm8909-tlmm: minor style cleanups dt-bindings: pinctrl: qcom,qcm2290: minor style cleanups dt-bindings: pinctrl: qcom,sdx65: minor style cleanups dt-bindings: pinctrl: qcom,sc8180x: minor style cleanups dt-bindings: pinctrl: qcom,sc8280xp: minor style cleanups dt-bindings: pinctrl: qcom,sm6115: minor style cleanups dt-bindings: pinctrl: qcom,sm6125: minor style cleanups dt-bindings: pinctrl: qcom,sm6350: minor style cleanups dt-bindings: pinctrl: qcom,sm6375: minor style cleanups dt-bindings: pinctrl: qcom,sm8250: minor style cleanups dt-bindings: pinctrl: qcom,sm8350: minor style cleanups dt-bindings: pinctrl: qcom,sm8450: minor style cleanups dt-bindings: pinctrl: qcom,sc7280-lpass-lpi: minor style cleanups dt-bindings: pinctrl: qcom,sm8250-lpass-lpi: minor style cleanups dt-bindings: pinctrl: qcom,sc8280xp-lpass-lpi: minor style cleanups dt-bindings: pinctrl: qcom,sm8450-lpass-lpi: minor style cleanups dt-bindings: pinctrl: qcom: adjust description .../pinctrl/qcom,ipq6018-pinctrl.yaml | 5 +- .../pinctrl/qcom,mdm9607-pinctrl.yaml | 16 ++--- .../pinctrl/qcom,msm8226-pinctrl.yaml | 5 +- .../bindings/pinctrl/qcom,msm8909-tlmm.yaml | 11 ++- .../pinctrl/qcom,msm8953-pinctrl.yaml | 5 +- .../pinctrl/qcom,qcm2290-pinctrl.yaml | 10 ++- .../qcom,sc7280-lpass-lpi-pinctrl.yaml | 13 ++-- .../bindings/pinctrl/qcom,sc7280-pinctrl.yaml | 16 +---- .../pinctrl/qcom,sc8180x-pinctrl.yaml | 27 +++---- .../qcom,sc8280xp-lpass-lpi-pinctrl.yaml | 13 ++-- .../pinctrl/qcom,sc8280xp-pinctrl.yaml | 22 ++---- .../bindings/pinctrl/qcom,sdx55-pinctrl.yaml | 5 +- .../bindings/pinctrl/qcom,sdx65-pinctrl.yaml | 10 ++- .../bindings/pinctrl/qcom,sm6115-pinctrl.yaml | 53 +++----------- .../bindings/pinctrl/qcom,sm6125-pinctrl.yaml | 30 +++----- .../bindings/pinctrl/qcom,sm6350-pinctrl.yaml | 23 ++---- .../bindings/pinctrl/qcom,sm6375-tlmm.yaml | 23 ++---- .../qcom,sm8250-lpass-lpi-pinctrl.yaml | 16 ++--- .../bindings/pinctrl/qcom,sm8250-pinctrl.yaml | 70 ++++++------------- .../bindings/pinctrl/qcom,sm8350-pinctrl.yaml | 23 ++---- .../qcom,sm8450-lpass-lpi-pinctrl.yaml | 13 ++-- .../bindings/pinctrl/qcom,sm8450-pinctrl.yaml | 22 ++---- 22 files changed, 136 insertions(+), 295 deletions(-)