| Message ID | 20221004192715.173210-1-colin.i.king@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | [next] i2c: microchip: pci1xxxx: Fix comparison of -EPERM against an unsigned variable | expand |
On Tue, Oct 04, 2022 at 08:27:15PM +0100, Colin Ian King wrote: > The comparison of variable ret with -EPERM is always false because > ret is an u8 type. Fix this by making ret an int. > > Cleans up clang warning: > drivers/i2c/busses/i2c-mchp-pci1xxxx.c:714:10: warning: result of comparison > of constant -1 with expression of type 'u8' (aka 'unsigned char') is always > false [-Wtautological-constant-out-of-range-compare] > > Fixes: 361693697249 ("i2c: microchip: pci1xxxx: Add driver for I2C host controller in multifunction endpoint of pci1xxxx switch") > Signed-off-by: Colin Ian King <colin.i.king@gmail.com> Applied to for-current, thanks!
diff --git a/drivers/i2c/busses/i2c-mchp-pci1xxxx.c b/drivers/i2c/busses/i2c-mchp-pci1xxxx.c index f5342201eb6b..09af75921147 100644 --- a/drivers/i2c/busses/i2c-mchp-pci1xxxx.c +++ b/drivers/i2c/busses/i2c-mchp-pci1xxxx.c @@ -708,7 +708,7 @@ static void pci1xxxx_i2c_init(struct pci1xxxx_i2c *i2c) void __iomem *p2 = i2c->i2c_base + SMBUS_STATUS_REG_OFF; void __iomem *p1 = i2c->i2c_base + SMB_GPR_REG; u8 regval; - u8 ret; + int ret; ret = set_sys_lock(i2c); if (ret == -EPERM) {
The comparison of variable ret with -EPERM is always false because ret is an u8 type. Fix this by making ret an int. Cleans up clang warning: drivers/i2c/busses/i2c-mchp-pci1xxxx.c:714:10: warning: result of comparison of constant -1 with expression of type 'u8' (aka 'unsigned char') is always false [-Wtautological-constant-out-of-range-compare] Fixes: 361693697249 ("i2c: microchip: pci1xxxx: Add driver for I2C host controller in multifunction endpoint of pci1xxxx switch") Signed-off-by: Colin Ian King <colin.i.king@gmail.com> --- drivers/i2c/busses/i2c-mchp-pci1xxxx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)