[v2,08/11] mfd: qcom-pm8xxx: drop unused PM8018 compatible

Message ID	20220928-mdm9615-dt-schema-fixes-v2-8-87fbeb4ae053@linaro.org
State	Superseded
Headers	show Return-Path: <linux-arm-msm-owner@kernel.org> From: Neil Armstrong <neil.armstrong@linaro.org> Date: Tue, 04 Oct 2022 08:08:24 +0000 Subject: [PATCH v2 08/11] mfd: qcom-pm8xxx: drop unused PM8018 compatible MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Message-Id: <20220928-mdm9615-dt-schema-fixes-v2-8-87fbeb4ae053@linaro.org> References: <20220928-mdm9615-dt-schema-fixes-v2-0-87fbeb4ae053@linaro.org> In-Reply-To: <20220928-mdm9615-dt-schema-fixes-v2-0-87fbeb4ae053@linaro.org> To: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Bjorn Andersson <andersson@kernel.org>, Satya Priya <quic_c_skakit@quicinc.com>, Andy Gross <agross@kernel.org>, Alexandre Belloni <alexandre.belloni@bootlin.com>, Rob Herring <robh+dt@kernel.org>, Konrad Dybcio <konrad.dybcio@somainline.org>, Lee Jones <lee@kernel.org>, Dmitry Torokhov <dmitry.torokhov@gmail.com>, Alessandro Zummo <a.zummo@towertech.it> Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Bjorn Andersson <andersson@kernel.org>, linux-input@vger.kernel.org, Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>, Neil Armstrong <neil.armstrong@linaro.org>, linux-arm-msm@vger.kernel.org, linux-rtc@vger.kernel.org Precedence: bulk
Series	arm: qcom: mdm9615: first round of bindings and DT fixes \| expand [v2,00/11] arm: qcom: mdm9615: first round of bindings and DT fixes [v2,01/11] dt-bindings: arm: qcom: move swir,mangoh-green-wp8548 board documentation to qcom.yaml [v2,02/11] arm: dts: qcom: mdm9615*: add SPDX-License-Identifier [v2,03/11] arm: dts: qcom: mdm9615: add missing reg in cpu@0 node [v2,04/11] arm: dts: qcom: mdm9615: remove invalid spi-max-frequency gsbi3_spi node [v2,05/11] dt-bindings: mfd: qcom-pm8xxx: document qcom,pm8921 as fallback of qcom,pm8018 [v2,06/11] dt-bindings: input: qcom,pm8921-pwrkey: convert to dt-schema [v2,07/11] dt-bindings: rtc: qcom-pm8xxx: document qcom,pm8921-rtc as fallback of qcom,pm8018-rtc [v2,08/11] mfd: qcom-pm8xxx: drop unused PM8018 compatible [v2,09/11] rtc: pm8xxx: drop unused pm8018 compatible [v2,10/11] arm: dts: qcom: mdm9615: remove invalid interrupt-names from pl18x mmc nodes [v2,11/11] arm: dts: qcom: mdm9615: remove useless amba subnode

Message ID

20220928-mdm9615-dt-schema-fixes-v2-8-87fbeb4ae053@linaro.org

State

Superseded

Headers

From: Neil Armstrong <neil.armstrong@linaro.org>
Date: Tue, 04 Oct 2022 08:08:24 +0000
Subject: [PATCH v2 08/11] mfd: qcom-pm8xxx: drop unused PM8018 compatible
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
Message-Id: <20220928-mdm9615-dt-schema-fixes-v2-8-87fbeb4ae053@linaro.org>
References: <20220928-mdm9615-dt-schema-fixes-v2-0-87fbeb4ae053@linaro.org>
In-Reply-To: <20220928-mdm9615-dt-schema-fixes-v2-0-87fbeb4ae053@linaro.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Bjorn Andersson <andersson@kernel.org>,
        Satya Priya <quic_c_skakit@quicinc.com>,
        Andy Gross <agross@kernel.org>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        Rob Herring <robh+dt@kernel.org>,
        Konrad Dybcio <konrad.dybcio@somainline.org>,
        Lee Jones <lee@kernel.org>,
        Dmitry Torokhov <dmitry.torokhov@gmail.com>,
        Alessandro Zummo <a.zummo@towertech.it>
Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
        Bjorn Andersson <andersson@kernel.org>,
        linux-input@vger.kernel.org,
        Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        Neil Armstrong <neil.armstrong@linaro.org>,
        linux-arm-msm@vger.kernel.org, linux-rtc@vger.kernel.org
Precedence: bulk

Series

arm: qcom: mdm9615: first round of bindings and DT fixes | expand

Comments

Krzysztof Kozlowski Oct. 4, 2022, 9:02 a.m. UTC | #1

On 04/10/2022 10:08, Neil Armstrong wrote:
> The PM8921 compatible is used as fallback when PM8018 is available,
> then remove PM8018 compatible.

s/then/so/

But it's a bit confusing because PM8018 is not "available". It is
"present" or "is" instead, so rather:
"The PM8018 compatible is always used with PM8921 fallback, so PM8018
compatible can be safely removed from device ID table".

> 
> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof

Neil Armstrong Oct. 4, 2022, 9:42 a.m. UTC | #2

On 04/10/2022 11:02, Krzysztof Kozlowski wrote:
> On 04/10/2022 10:08, Neil Armstrong wrote:
>> The PM8921 compatible is used as fallback when PM8018 is available,
>> then remove PM8018 compatible.
> 
> s/then/so/
> 
> But it's a bit confusing because PM8018 is not "available". It is
> "present" or "is" instead, so rather:
> "The PM8018 compatible is always used with PM8921 fallback, so PM8018
> compatible can be safely removed from device ID table".

Thx for the suggestion, will use this wording, same in patch 9.

> 
>>
>> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
> 
> 
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> 
> Best regards,
> Krzysztof
> 

Thanks,
Neil

diff --git a/drivers/mfd/qcom-pm8xxx.c b/drivers/mfd/qcom-pm8xxx.c
index 2f2734ba5273..601106580e2e 100644
--- a/drivers/mfd/qcom-pm8xxx.c
+++ b/drivers/mfd/qcom-pm8xxx.c
@@ -497,7 +497,6 @@  static const struct pm_irq_data pm8821_data = {
 };
 
 static const struct of_device_id pm8xxx_id_table[] = {
-	{ .compatible = "qcom,pm8018", .data = &pm8xxx_data},
 	{ .compatible = "qcom,pm8058", .data = &pm8xxx_data},
 	{ .compatible = "qcom,pm8821", .data = &pm8821_data},
 	{ .compatible = "qcom,pm8921", .data = &pm8xxx_data},

[v2,08/11] mfd: qcom-pm8xxx: drop unused PM8018 compatible

Commit Message

Comments

Patch