Message ID | 20221001005208.8010-1-matt.ranostay@konsulko.com |
---|---|
Headers | show |
Series | HID: mcp2221: iio support and device resource management | expand |
On Fri, 30 Sep 2022 17:52:08 -0700 Matt Ranostay <matt.ranostay@konsulko.com> wrote: > Add support for 3x 10-bit ADC and 1x DAC channels registered via the iio > subsystem. > > To prevent breakage and unexpected dependencies this support only is > only built if CONFIG_IIO is enabled, and is only weakly referenced by > 'imply IIO' within the respective Kconfig. > > Additionally the iio device only gets registered if at least one channel > is enabled in the power-on configuration read from SRAM. > > Signed-off-by: Matt Ranostay <matt.ranostay@konsulko.com> I'm never particularly keen on drivers from elsewhere in the tree gaining IIO support - but that's just because it can make a bit of a mess of changes to the IIO subsystem itself. Having said that, this code looks fine to me. Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
On Sun, 2 Oct 2022, Jonathan Cameron wrote: > > Add support for 3x 10-bit ADC and 1x DAC channels registered via the > > iio subsystem. > > > > To prevent breakage and unexpected dependencies this support only is > > only built if CONFIG_IIO is enabled, and is only weakly referenced by > > 'imply IIO' within the respective Kconfig. > > > > Additionally the iio device only gets registered if at least one channel > > is enabled in the power-on configuration read from SRAM. > > > > Signed-off-by: Matt Ranostay <matt.ranostay@konsulko.com> > > I'm never particularly keen on drivers from elsewhere in the tree gaining > IIO support - but that's just because it can make a bit of a mess of > changes to the IIO subsystem itself. Having said that, this code looks fine to me. > > Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> Thanks. Applied for 6.2.