Message ID | 20220928034336.2939265-1-tharunkumar.pasumarthi@microchip.com |
---|---|
Headers | show |
Series | spi: microchip: pci1xxxx: Load SPI driver for SPI endpoint of PCI1XXXX switch | expand |
On Wed, 2022-09-28 at 12:26 +0100, Mark Brown wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > Please make the above a single C++ style comment block so things look moreĀ > intentional. Okay. > This does nothing if the chip select is to be disabled, that's clearly not > going to work. Okay. I will handle disable case of chip select. > The driver should set SPI_CONTROLLER_TX since it needs to transmit data inorer > to receive Okay. > Please write normal conditional statements to improve legibility. Okay. > Are you sure the device is fully set up and ready for interrupts at thisĀ > point, and that the freeing of the driver will work fine with devm? Okay, I will move init_completion and interrupt mask management before devm_request_irq API. Thanks, Tharun Kumar P