mbox series

[RFC,SPI,for-next,0/2] spi: microchip: pci1xxxx: Load SPI driver for SPI endpoint of PCI1XXXX switch

Message ID 20220928034336.2939265-1-tharunkumar.pasumarthi@microchip.com
Headers show
Series spi: microchip: pci1xxxx: Load SPI driver for SPI endpoint of PCI1XXXX switch | expand

Message

Tharun Kumar P Sept. 28, 2022, 3:43 a.m. UTC
Microchip PCI1XXXX is an unmanaged PCIe3.1a switch for consumer, industrial, and
automotive applications. This switch has multiple downstream ports. One of the
switch's downstream ports is a multifunction endpoint; one of those functions
supports SPI functionality. This series of patches provides the SPI controller
driver for the SPI function of the multifunction PCIe endpoint of the switch.

Tharun Kumar P (2):
  spi: microchip: pci1xxxx: Add driver for SPI controller of PCI1XXXX
    PCIe switch
  spi: microchip: pci1xxxx: Add suspend and resume support for PCI1XXXX
    SPI driver

 drivers/spi/Kconfig        |   9 +
 drivers/spi/Makefile       |   1 +
 drivers/spi/spi-pci1xxxx.c | 453 +++++++++++++++++++++++++++++++++++++
 3 files changed, 463 insertions(+)
 create mode 100644 drivers/spi/spi-pci1xxxx.c

Comments

Tharun Kumar P Sept. 30, 2022, 5:51 a.m. UTC | #1
On Wed, 2022-09-28 at 12:26 +0100, Mark Brown wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the
> content is safe
> 
> Please make the above a single C++ style comment block so things look moreĀ 
> intentional.

Okay.

> This does nothing if the chip select is to be disabled, that's clearly not
> going to work. 

Okay. I will handle disable case of chip select.

> The driver should set SPI_CONTROLLER_TX since it needs to transmit data inorer
> to receive

Okay.

> Please write normal conditional statements to improve legibility.

Okay.

> Are you sure the device is fully set up and ready for interrupts at thisĀ 
> point, and that the freeing of the driver will work fine with devm?

Okay, I will move init_completion and interrupt mask management before
devm_request_irq API. 


Thanks,
Tharun Kumar P