| Message ID | 20220927114442.000026f7@arducam.com |
|---|---|
| State | New |
| Headers | show |
| Series | [RESEND,1/2] dt-bindings: media: i2c: Add IMX519 CMOS sensor binding | expand |
On Tue, Sep 27, 2022 at 11:44:42AM +0800, Lee Jackson wrote: > Add YAML device tree binding for IMX519 CMOS image sensor, and > the relevant MAINTAINERS entries. I don't see any signs of patch 2/2... > Signed-off-by: Lee Jackson <info@arducam.com> > --- > .../devicetree/bindings/media/i2c/imx519.yaml | 113 ++++++++++++++++++ sony,imx519.yaml > MAINTAINERS | 8 ++ > 2 files changed, 121 insertions(+) > create mode 100644 Documentation/devicetree/bindings/media/i2c/imx519.yaml > > diff --git a/Documentation/devicetree/bindings/media/i2c/imx519.yaml b/Documentation/devicetree/bindings/media/i2c/imx519.yaml > new file mode 100644 > index 000000000000..717230a21764 > --- /dev/null > +++ b/Documentation/devicetree/bindings/media/i2c/imx519.yaml > @@ -0,0 +1,113 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/media/i2c/imx519.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Sony 1/2.5-Inch 16Mpixel CMOS Digital Image Sensor > + > +maintainers: > + - Lee Jackson <info@arducam.com> > + > +description: |- > + The Sony IMX519 is a 1/2.5-inch CMOS active pixel digital image sensor > + with an active array size of 4656H x 3496V. It is programmable through > + I2C interface. The I2C address is fixed to 0x1A as per sensor data sheet. > + Image data is sent through MIPI CSI-2, which is configured as either 2 or > + 4 data lanes. > + > +properties: > + compatible: > + const: sony,imx519 > + > + reg: > + description: I2C device address > + maxItems: 1 > + > + clocks: > + maxItems: 1 > + > + VDIG-supply: > + description: > + Digital I/O voltage supply, 1.05 volts > + > + VANA-supply: > + description: > + Analog voltage supply, 2.8 volts > + > + VDDL-supply: > + description: > + Digital core voltage supply, 1.8 volts > + > + reset-gpios: > + description: |- > + Reference to the GPIO connected to the xclr pin, if any. > + Must be released (set high) after all supplies and INCK are applied. > + > + # See ../video-interfaces.txt for more details What does that file say? > + port: > + type: object > + properties: > + endpoint: > + type: object Please look at any other camera sensor schema for how this should look. > + properties: > + data-lanes: > + description: |- > + The sensor supports either two-lane, or four-lane operation. > + For two-lane operation the property must be set to <1 2>. > + items: > + - const: 1 > + - const: 2 > + > + clock-noncontinuous: > + type: boolean > + description: |- > + MIPI CSI-2 clock is non-continuous if this property is present, > + otherwise it's continuous. > + > + link-frequencies: > + allOf: > + - $ref: /schemas/types.yaml#/definitions/uint64-array > + description: > + Allowed data bus frequencies. > + > + required: > + - link-frequencies > + > +required: > + - compatible > + - reg > + - clocks > + - VANA-supply > + - VDIG-supply > + - VDDL-supply > + - port > + > +additionalProperties: false > + > +examples: > + - | > + i2c0 { i2c { > + #address-cells = <1>; > + #size-cells = <0>; > + > + imx519: sensor@1a { > + compatible = "sony,imx519"; > + reg = <0x1a>; > + clocks = <&imx519_clk>; > + VANA-supply = <&imx519_vana>; /* 2.8v */ > + VDIG-supply = <&imx519_vdig>; /* 1.05v */ > + VDDL-supply = <&imx519_vddl>; /* 1.8v */ > + > + port { > + imx519_0: endpoint { > + remote-endpoint = <&csi1_ep>; > + data-lanes = <1 2>; > + clock-noncontinuous; > + link-frequencies = /bits/ 64 <493500000>; > + }; > + }; > + }; > + }; > + > +... > diff --git a/MAINTAINERS b/MAINTAINERS > index a58f1fc6dd47..a2de51d71677 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -19007,6 +19007,14 @@ T: git git://linuxtv.org/media_tree.git > F: Documentation/devicetree/bindings/media/i2c/sony,imx412.yaml > F: drivers/media/i2c/imx412.c > > +SONY IMX519 SENSOR DRIVER > +M: Arducam Kernel Maintenance <info@arducam.com> > +L: linux-media@vger.kernel.org > +S: Maintained > +T: git git://linuxtv.org/media_tree.git > +F: Documentation/devicetree/bindings/media/i2c/imx519.yaml > +F: drivers/media/i2c/imx519.c > + > SONY MEMORYSTICK SUBSYSTEM > M: Maxim Levitsky <maximlevitsky@gmail.com> > M: Alex Dubov <oakad@yahoo.com> > -- > 2.25.1 > >
Hi Lee, On Tue, Sep 27, 2022 at 11:44:42AM +0800, Lee Jackson wrote: > Add YAML device tree binding for IMX519 CMOS image sensor, and > the relevant MAINTAINERS entries. > > Signed-off-by: Lee Jackson <info@arducam.com> This should be your own e-mail address. > --- > .../devicetree/bindings/media/i2c/imx519.yaml | 113 ++++++++++++++++++ > MAINTAINERS | 8 ++ > 2 files changed, 121 insertions(+) > create mode 100644 Documentation/devicetree/bindings/media/i2c/imx519.yaml > > diff --git a/Documentation/devicetree/bindings/media/i2c/imx519.yaml b/Documentation/devicetree/bindings/media/i2c/imx519.yaml > new file mode 100644 > index 000000000000..717230a21764 > --- /dev/null > +++ b/Documentation/devicetree/bindings/media/i2c/imx519.yaml > @@ -0,0 +1,113 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/media/i2c/imx519.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Sony 1/2.5-Inch 16Mpixel CMOS Digital Image Sensor > + > +maintainers: > + - Lee Jackson <info@arducam.com> > + > +description: |- > + The Sony IMX519 is a 1/2.5-inch CMOS active pixel digital image sensor > + with an active array size of 4656H x 3496V. It is programmable through > + I2C interface. The I2C address is fixed to 0x1A as per sensor data sheet. > + Image data is sent through MIPI CSI-2, which is configured as either 2 or > + 4 data lanes. > + > +properties: > + compatible: > + const: sony,imx519 > + > + reg: > + description: I2C device address > + maxItems: 1 > + > + clocks: > + maxItems: 1 > + > + VDIG-supply: > + description: > + Digital I/O voltage supply, 1.05 volts > + > + VANA-supply: > + description: > + Analog voltage supply, 2.8 volts > + > + VDDL-supply: > + description: > + Digital core voltage supply, 1.8 volts > + > + reset-gpios: > + description: |- > + Reference to the GPIO connected to the xclr pin, if any. > + Must be released (set high) after all supplies and INCK are applied. > + > + # See ../video-interfaces.txt for more details > + port: > + type: object > + properties: > + endpoint: > + type: object > + properties: > + data-lanes: > + description: |- > + The sensor supports either two-lane, or four-lane operation. > + For two-lane operation the property must be set to <1 2>. > + items: > + - const: 1 > + - const: 2 Please see my comments from 5th February. > + > + clock-noncontinuous: > + type: boolean > + description: |- > + MIPI CSI-2 clock is non-continuous if this property is present, > + otherwise it's continuous. > + > + link-frequencies: > + allOf: > + - $ref: /schemas/types.yaml#/definitions/uint64-array > + description: > + Allowed data bus frequencies. > + > + required: > + - link-frequencies > + > +required: > + - compatible > + - reg > + - clocks > + - VANA-supply > + - VDIG-supply > + - VDDL-supply > + - port > + > +additionalProperties: false > + > +examples: > + - | > + i2c0 { > + #address-cells = <1>; > + #size-cells = <0>; > + > + imx519: sensor@1a { > + compatible = "sony,imx519"; > + reg = <0x1a>; > + clocks = <&imx519_clk>; > + VANA-supply = <&imx519_vana>; /* 2.8v */ > + VDIG-supply = <&imx519_vdig>; /* 1.05v */ > + VDDL-supply = <&imx519_vddl>; /* 1.8v */ > + > + port { > + imx519_0: endpoint { > + remote-endpoint = <&csi1_ep>; > + data-lanes = <1 2>; > + clock-noncontinuous; > + link-frequencies = /bits/ 64 <493500000>; > + }; > + }; > + }; > + }; > + > +... > diff --git a/MAINTAINERS b/MAINTAINERS > index a58f1fc6dd47..a2de51d71677 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -19007,6 +19007,14 @@ T: git git://linuxtv.org/media_tree.git > F: Documentation/devicetree/bindings/media/i2c/sony,imx412.yaml > F: drivers/media/i2c/imx412.c > > +SONY IMX519 SENSOR DRIVER > +M: Arducam Kernel Maintenance <info@arducam.com> > +L: linux-media@vger.kernel.org > +S: Maintained > +T: git git://linuxtv.org/media_tree.git > +F: Documentation/devicetree/bindings/media/i2c/imx519.yaml > +F: drivers/media/i2c/imx519.c > + > SONY MEMORYSTICK SUBSYSTEM > M: Maxim Levitsky <maximlevitsky@gmail.com> > M: Alex Dubov <oakad@yahoo.com>
diff --git a/Documentation/devicetree/bindings/media/i2c/imx519.yaml b/Documentation/devicetree/bindings/media/i2c/imx519.yaml new file mode 100644 index 000000000000..717230a21764 --- /dev/null +++ b/Documentation/devicetree/bindings/media/i2c/imx519.yaml @@ -0,0 +1,113 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/media/i2c/imx519.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Sony 1/2.5-Inch 16Mpixel CMOS Digital Image Sensor + +maintainers: + - Lee Jackson <info@arducam.com> + +description: |- + The Sony IMX519 is a 1/2.5-inch CMOS active pixel digital image sensor + with an active array size of 4656H x 3496V. It is programmable through + I2C interface. The I2C address is fixed to 0x1A as per sensor data sheet. + Image data is sent through MIPI CSI-2, which is configured as either 2 or + 4 data lanes. + +properties: + compatible: + const: sony,imx519 + + reg: + description: I2C device address + maxItems: 1 + + clocks: + maxItems: 1 + + VDIG-supply: + description: + Digital I/O voltage supply, 1.05 volts + + VANA-supply: + description: + Analog voltage supply, 2.8 volts + + VDDL-supply: + description: + Digital core voltage supply, 1.8 volts + + reset-gpios: + description: |- + Reference to the GPIO connected to the xclr pin, if any. + Must be released (set high) after all supplies and INCK are applied. + + # See ../video-interfaces.txt for more details + port: + type: object + properties: + endpoint: + type: object + properties: + data-lanes: + description: |- + The sensor supports either two-lane, or four-lane operation. + For two-lane operation the property must be set to <1 2>. + items: + - const: 1 + - const: 2 + + clock-noncontinuous: + type: boolean + description: |- + MIPI CSI-2 clock is non-continuous if this property is present, + otherwise it's continuous. + + link-frequencies: + allOf: + - $ref: /schemas/types.yaml#/definitions/uint64-array + description: + Allowed data bus frequencies. + + required: + - link-frequencies + +required: + - compatible + - reg + - clocks + - VANA-supply + - VDIG-supply + - VDDL-supply + - port + +additionalProperties: false + +examples: + - | + i2c0 { + #address-cells = <1>; + #size-cells = <0>; + + imx519: sensor@1a { + compatible = "sony,imx519"; + reg = <0x1a>; + clocks = <&imx519_clk>; + VANA-supply = <&imx519_vana>; /* 2.8v */ + VDIG-supply = <&imx519_vdig>; /* 1.05v */ + VDDL-supply = <&imx519_vddl>; /* 1.8v */ + + port { + imx519_0: endpoint { + remote-endpoint = <&csi1_ep>; + data-lanes = <1 2>; + clock-noncontinuous; + link-frequencies = /bits/ 64 <493500000>; + }; + }; + }; + }; + +... diff --git a/MAINTAINERS b/MAINTAINERS index a58f1fc6dd47..a2de51d71677 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -19007,6 +19007,14 @@ T: git git://linuxtv.org/media_tree.git F: Documentation/devicetree/bindings/media/i2c/sony,imx412.yaml F: drivers/media/i2c/imx412.c +SONY IMX519 SENSOR DRIVER +M: Arducam Kernel Maintenance <info@arducam.com> +L: linux-media@vger.kernel.org +S: Maintained +T: git git://linuxtv.org/media_tree.git +F: Documentation/devicetree/bindings/media/i2c/imx519.yaml +F: drivers/media/i2c/imx519.c + SONY MEMORYSTICK SUBSYSTEM M: Maxim Levitsky <maximlevitsky@gmail.com> M: Alex Dubov <oakad@yahoo.com>
Add YAML device tree binding for IMX519 CMOS image sensor, and the relevant MAINTAINERS entries. Signed-off-by: Lee Jackson <info@arducam.com> --- .../devicetree/bindings/media/i2c/imx519.yaml | 113 ++++++++++++++++++ MAINTAINERS | 8 ++ 2 files changed, 121 insertions(+) create mode 100644 Documentation/devicetree/bindings/media/i2c/imx519.yaml