| Message ID | 20220928201214.8544-1-wsa@kernel.org |
|---|---|
| State | Accepted |
| Commit | 228336f50711e9f0f47352483a8501e0c598845b |
| Headers | show |
| Series | i2c: pci1xxxx: prevent signed integer overflow | expand |
On Wed, Sep 28, 2022 at 10:12:14PM +0200, Wolfram Sang wrote: > Some constants need 'UL' markings, otherwise they are shifted into the > sign bit. > > Fixes: 361693697249 ("i2c: microchip: pci1xxxx: Add driver for I2C host controller in multifunction endpoint of pci1xxxx switch") > Signed-off-by: Wolfram Sang <wsa@kernel.org> Applied to for-next, thanks!
diff --git a/drivers/i2c/busses/i2c-mchp-pci1xxxx.c b/drivers/i2c/busses/i2c-mchp-pci1xxxx.c index b2b7dbff5ef4..f5342201eb6b 100644 --- a/drivers/i2c/busses/i2c-mchp-pci1xxxx.c +++ b/drivers/i2c/busses/i2c-mchp-pci1xxxx.c @@ -190,9 +190,9 @@ * Bus Idle Minimum time = BUS_IDLE_MIN[7:0] x Baud_Clock_Period x * (BUS_IDLE_MIN_XK_TICKS[7] ? 4,1) */ -#define BUS_IDLE_MIN_100K_TICKS 167 -#define BUS_IDLE_MIN_400K_TICKS 139 -#define BUS_IDLE_MIN_1000K_TICKS 133 +#define BUS_IDLE_MIN_100K_TICKS 167UL +#define BUS_IDLE_MIN_400K_TICKS 139UL +#define BUS_IDLE_MIN_1000K_TICKS 133UL /* * CTRL_CUM_TIME_OUT_XK_TICKS defines SMBus Controller Cumulative Time-Out.
Some constants need 'UL' markings, otherwise they are shifted into the sign bit. Fixes: 361693697249 ("i2c: microchip: pci1xxxx: Add driver for I2C host controller in multifunction endpoint of pci1xxxx switch") Signed-off-by: Wolfram Sang <wsa@kernel.org> --- drivers/i2c/busses/i2c-mchp-pci1xxxx.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)