| Message ID | 20220926074415.53100-5-krzysztof.kozlowski@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | pinctrl/arm64: qcom: continued - fix Qualcomm TLMM pinctrl schema warnings | expand |
On 26.09.2022 09:43, Krzysztof Kozlowski wrote: > DT schema expects TLMM pin configuration nodes to be named with > '-state' suffix and their optional children with '-pins' suffix. Schema > also requires 'function' property, so two nodes for the same gpio (mux > and config) should be merged into one. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- Reviewed-by: Konrad Dybcio <konrad.dybcio@somainline.org> Konrad > .../boot/dts/qcom-sdx55-telit-fn980-tlb.dts | 45 +++++++------------ > 1 file changed, 15 insertions(+), 30 deletions(-) > > diff --git a/arch/arm/boot/dts/qcom-sdx55-telit-fn980-tlb.dts b/arch/arm/boot/dts/qcom-sdx55-telit-fn980-tlb.dts > index a4fa468a095f..ac8b4626ae9a 100644 > --- a/arch/arm/boot/dts/qcom-sdx55-telit-fn980-tlb.dts > +++ b/arch/arm/boot/dts/qcom-sdx55-telit-fn980-tlb.dts > @@ -282,40 +282,25 @@ &remoteproc_mpss { > }; > > &tlmm { > - pcie_ep_clkreq_default: pcie_ep_clkreq_default { > - mux { > - pins = "gpio56"; > - function = "pcie_clkreq"; > - }; > - config { > - pins = "gpio56"; > - drive-strength = <2>; > - bias-disable; > - }; > + pcie_ep_clkreq_default: pcie-ep-clkreq-default-state { > + pins = "gpio56"; > + function = "pcie_clkreq"; > + drive-strength = <2>; > + bias-disable; > }; > > - pcie_ep_perst_default: pcie_ep_perst_default { > - mux { > - pins = "gpio57"; > - function = "gpio"; > - }; > - config { > - pins = "gpio57"; > - drive-strength = <2>; > - bias-pull-down; > - }; > + pcie_ep_perst_default: pcie-ep-perst-default-state { > + pins = "gpio57"; > + function = "gpio"; > + drive-strength = <2>; > + bias-pull-down; > }; > > - pcie_ep_wake_default: pcie_ep_wake_default { > - mux { > - pins = "gpio53"; > - function = "gpio"; > - }; > - config { > - pins = "gpio53"; > - drive-strength = <2>; > - bias-disable; > - }; > + pcie_ep_wake_default: pcie-ep-wake-default-state { > + pins = "gpio53"; > + function = "gpio"; > + drive-strength = <2>; > + bias-disable; > }; > }; >
diff --git a/arch/arm/boot/dts/qcom-sdx55-telit-fn980-tlb.dts b/arch/arm/boot/dts/qcom-sdx55-telit-fn980-tlb.dts index a4fa468a095f..ac8b4626ae9a 100644 --- a/arch/arm/boot/dts/qcom-sdx55-telit-fn980-tlb.dts +++ b/arch/arm/boot/dts/qcom-sdx55-telit-fn980-tlb.dts @@ -282,40 +282,25 @@ &remoteproc_mpss { }; &tlmm { - pcie_ep_clkreq_default: pcie_ep_clkreq_default { - mux { - pins = "gpio56"; - function = "pcie_clkreq"; - }; - config { - pins = "gpio56"; - drive-strength = <2>; - bias-disable; - }; + pcie_ep_clkreq_default: pcie-ep-clkreq-default-state { + pins = "gpio56"; + function = "pcie_clkreq"; + drive-strength = <2>; + bias-disable; }; - pcie_ep_perst_default: pcie_ep_perst_default { - mux { - pins = "gpio57"; - function = "gpio"; - }; - config { - pins = "gpio57"; - drive-strength = <2>; - bias-pull-down; - }; + pcie_ep_perst_default: pcie-ep-perst-default-state { + pins = "gpio57"; + function = "gpio"; + drive-strength = <2>; + bias-pull-down; }; - pcie_ep_wake_default: pcie_ep_wake_default { - mux { - pins = "gpio53"; - function = "gpio"; - }; - config { - pins = "gpio53"; - drive-strength = <2>; - bias-disable; - }; + pcie_ep_wake_default: pcie-ep-wake-default-state { + pins = "gpio53"; + function = "gpio"; + drive-strength = <2>; + bias-disable; }; };
DT schema expects TLMM pin configuration nodes to be named with '-state' suffix and their optional children with '-pins' suffix. Schema also requires 'function' property, so two nodes for the same gpio (mux and config) should be merged into one. Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- .../boot/dts/qcom-sdx55-telit-fn980-tlb.dts | 45 +++++++------------ 1 file changed, 15 insertions(+), 30 deletions(-)