| Message ID | 20220927033138.1945842-1-yangyingliang@huawei.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [-next,v3] backlight: gpio_backlight: Switch to use dev_err_probe() helper | expand |
On Tue, Sep 27, 2022 at 11:31:38AM +0800, Yang Yingliang wrote: > In the probe path, dev_err() can be replaced with dev_err_probe() > which will check if error code is -EPROBE_DEFER and prints the > error name. It also sets the defer probe reason which can be > checked later through debugfs. It's more simple in error path. > > Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org> Daniel.
On Tue, 27 Sep 2022, Daniel Thompson wrote: > On Tue, Sep 27, 2022 at 11:31:38AM +0800, Yang Yingliang wrote: > > In the probe path, dev_err() can be replaced with dev_err_probe() > > which will check if error code is -EPROBE_DEFER and prints the > > error name. It also sets the defer probe reason which can be > > checked later through debugfs. It's more simple in error path. > > > > Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> > > Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org> The original patch is not in my inbox. Was I missed from the original mail?
Hi, On 2022/9/28 17:11, Lee Jones wrote: > On Tue, 27 Sep 2022, Daniel Thompson wrote: > >> On Tue, Sep 27, 2022 at 11:31:38AM +0800, Yang Yingliang wrote: >>> In the probe path, dev_err() can be replaced with dev_err_probe() >>> which will check if error code is -EPROBE_DEFER and prints the >>> error name. It also sets the defer probe reason which can be >>> checked later through debugfs. It's more simple in error path. >>> >>> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> >> Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org> > > The original patch is not in my inbox. > > Was I missed from the original mail? I have already add your mail address to my Cc list, when sending the patch. Here is the early mail: V1: https://lore.kernel.org/linux-fbdev/f98b2e35-0f86-ffd0-db11-ca91930e153f@huawei.com/T/#t V2: https://lore.kernel.org/linux-fbdev/7d8cfce2-ba08-afc0-de2d-972ee15b5865@huawei.com/T/#t Thanks, Yang
diff --git a/drivers/video/backlight/gpio_backlight.c b/drivers/video/backlight/gpio_backlight.c index 6f78d928f054..7df85b044e1c 100644 --- a/drivers/video/backlight/gpio_backlight.c +++ b/drivers/video/backlight/gpio_backlight.c @@ -64,13 +64,9 @@ static int gpio_backlight_probe(struct platform_device *pdev) def_value = device_property_read_bool(dev, "default-on"); gbl->gpiod = devm_gpiod_get(dev, NULL, GPIOD_ASIS); - if (IS_ERR(gbl->gpiod)) { - ret = PTR_ERR(gbl->gpiod); - if (ret != -EPROBE_DEFER) - dev_err(dev, - "Error: The gpios parameter is missing or invalid.\n"); - return ret; - } + if (IS_ERR(gbl->gpiod)) + return dev_err_probe(dev, PTR_ERR(gbl->gpiod), + "gpios parameter is missing or invalid.\n"); memset(&props, 0, sizeof(props)); props.type = BACKLIGHT_RAW;
In the probe path, dev_err() can be replaced with dev_err_probe() which will check if error code is -EPROBE_DEFER and prints the error name. It also sets the defer probe reason which can be checked later through debugfs. It's more simple in error path. Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> --- v1 -> v3: Remove "Error: The ". --- drivers/video/backlight/gpio_backlight.c | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-)