| Message ID | 20220924080459.13084-1-krzysztof.kozlowski@linaro.org |
|---|---|
| Headers | show |
| Series | pinctrl/arm64: qcom: continued - fix Qualcomm TLMM pinctrl schema warnings | expand |
On 25/09/2022 16:00, Stephan Gerhold wrote: >> + allOf: >> + - $ref: "qcom,tlmm-common.yaml#/$defs/qcom-tlmm-state" >> + - if: >> + properties: >> + pins: >> + pattern: "^gpio([0-9]|[1-9][0-9]|10[0-9]|11[0-7])$" >> + then: >> + required: >> + - function >> > > Is it possible to place this into qcom,tlmm-common.yaml? If the pattern > is only used to make "function" required for GPIOs, then it should not > matter if it matches just the prefix ("^gpio") or the exact set of > allowed GPIO numbers. The definition of the "pins" property will already > take care of validating those. Hm, very good idea. > > Or are there some Qcom SoCs where a GPIO without "function" is valid? Quick look at drivers says there is no such case. I can try adding it to common schema and look for errors. Best regards, Krzysztof
On Sat, 24 Sep 2022 10:04:37 +0200, Krzysztof Kozlowski wrote: > Certain pins, like SDcard related, do not have functions and such should > not be required. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- > .../bindings/pinctrl/qcom,ipq6018-pinctrl.yaml | 12 ++++++++++-- > 1 file changed, 10 insertions(+), 2 deletions(-) > Reviewed-by: Rob Herring <robh@kernel.org>
On Sat, 24 Sep 2022 10:04:40 +0200, Krzysztof Kozlowski wrote: > Certain pins, like SDcard related, do not have functions and such should > not be required. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- > .../bindings/pinctrl/qcom,msm8226-pinctrl.yaml | 12 ++++++++++-- > 1 file changed, 10 insertions(+), 2 deletions(-) > Reviewed-by: Rob Herring <robh@kernel.org>
On Sat, Sep 24, 2022 at 10:04:52AM +0200, Krzysztof Kozlowski wrote: > Certain pins, like SDcard related, do not have functions and such should > not be required. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- > .../bindings/pinctrl/qcom,qcm2290-pinctrl.yaml | 11 ++++++++++- > 1 file changed, 10 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,qcm2290-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,qcm2290-pinctrl.yaml > index 5324b61eb4f7..89453cb60c12 100644 > --- a/Documentation/devicetree/bindings/pinctrl/qcom,qcm2290-pinctrl.yaml > +++ b/Documentation/devicetree/bindings/pinctrl/qcom,qcm2290-pinctrl.yaml > @@ -60,7 +60,6 @@ patternProperties: > description: > Pinctrl node's client devices use subnodes for desired pin configuration. > Client device subnodes use below standard properties. > - $ref: "qcom,tlmm-common.yaml#/$defs/qcom-tlmm-state" > > properties: > pins: > @@ -116,6 +115,16 @@ patternProperties: > required: > - pins > > + allOf: > + - $ref: "qcom,tlmm-common.yaml#/$defs/qcom-tlmm-state" You can drop the quotes here. > + - if: > + properties: > + pins: > + pattern: "^gpio([0-9]|[1-9][0-9]|1[0-1][0-9]|12[0-6])$" > + then: > + required: > + - function > + > additionalProperties: false > > allOf: > -- > 2.34.1 > >
On Sat, 24 Sep 2022 10:04:52 +0200, Krzysztof Kozlowski wrote: > Certain pins, like SDcard related, do not have functions and such should > not be required. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- > .../bindings/pinctrl/qcom,qcm2290-pinctrl.yaml | 11 ++++++++++- > 1 file changed, 10 insertions(+), 1 deletion(-) > Reviewed-by: Rob Herring <robh@kernel.org>
On 27/09/2022 01:15, Rob Herring wrote: >> properties: >> pins: >> @@ -116,6 +115,16 @@ patternProperties: >> required: >> - pins >> >> + allOf: >> + - $ref: "qcom,tlmm-common.yaml#/$defs/qcom-tlmm-state" > > You can drop the quotes here. > Ack. Best regards, Krzysztof
On Sat, 24 Sept 2022 at 11:07, Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > > Certain pins, like SDcard related, do not have functions and such should > not be required. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- > .../bindings/pinctrl/qcom,qcm2290-pinctrl.yaml | 11 ++++++++++- > 1 file changed, 10 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,qcm2290-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,qcm2290-pinctrl.yaml > index 5324b61eb4f7..89453cb60c12 100644 > --- a/Documentation/devicetree/bindings/pinctrl/qcom,qcm2290-pinctrl.yaml > +++ b/Documentation/devicetree/bindings/pinctrl/qcom,qcm2290-pinctrl.yaml > @@ -60,7 +60,6 @@ patternProperties: > description: > Pinctrl node's client devices use subnodes for desired pin configuration. > Client device subnodes use below standard properties. > - $ref: "qcom,tlmm-common.yaml#/$defs/qcom-tlmm-state" > > properties: > pins: > @@ -116,6 +115,16 @@ patternProperties: > required: > - pins > > + allOf: Nit: I think you can drop allOf here and move the $ref up a few lines. > + - $ref: "qcom,tlmm-common.yaml#/$defs/qcom-tlmm-state" > + - if: > + properties: > + pins: > + pattern: "^gpio([0-9]|[1-9][0-9]|1[0-1][0-9]|12[0-6])$" > + then: > + required: > + - function > + > additionalProperties: false > > allOf: > -- > 2.34.1 >
On 27/09/2022 13:42, Dmitry Baryshkov wrote: > On Sat, 24 Sept 2022 at 11:07, Krzysztof Kozlowski > <krzysztof.kozlowski@linaro.org> wrote: >> >> Certain pins, like SDcard related, do not have functions and such should >> not be required. >> >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >> --- >> .../bindings/pinctrl/qcom,qcm2290-pinctrl.yaml | 11 ++++++++++- >> 1 file changed, 10 insertions(+), 1 deletion(-) >> >> diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,qcm2290-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,qcm2290-pinctrl.yaml >> index 5324b61eb4f7..89453cb60c12 100644 >> --- a/Documentation/devicetree/bindings/pinctrl/qcom,qcm2290-pinctrl.yaml >> +++ b/Documentation/devicetree/bindings/pinctrl/qcom,qcm2290-pinctrl.yaml >> @@ -60,7 +60,6 @@ patternProperties: >> description: >> Pinctrl node's client devices use subnodes for desired pin configuration. >> Client device subnodes use below standard properties. >> - $ref: "qcom,tlmm-common.yaml#/$defs/qcom-tlmm-state" >> >> properties: >> pins: >> @@ -116,6 +115,16 @@ patternProperties: >> required: >> - pins >> >> + allOf: > > Nit: I think you can drop allOf here and move the $ref up a few lines. > It's anyway different in v2 - there is no if:then. Best regards, Krzysztof
On Sat, Sep 24, 2022 at 10:05 AM Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > This is the third patchset around Qualcomm pinctrl in recent days: > 1. First round of TLMM fixes: merged > 2. LPASS fixes: https://lore.kernel.org/linux-devicetree/20220922195651.345369-1-krzysztof.kozlowski@linaro.org/T/#t > 3. Second round of TLMM fixes: THIS PATCHSET Same thing with TLMM as LPASS! Stack up the bindings, send me pull requests, because I trust you. Yours, Linus Walleij
Hi, Overview ======== This is the third patchset around Qualcomm pinctrl in recent days: 1. First round of TLMM fixes: merged 2. LPASS fixes: https://lore.kernel.org/linux-devicetree/20220922195651.345369-1-krzysztof.kozlowski@linaro.org/T/#t 3. Second round of TLMM fixes: THIS PATCHSET Dependencies ============ 1. No dependencies. 2. dt-bindings are independent of DTS patches. Best regards, Krzysztof Krzysztof Kozlowski (32): arm64: dts: qcom: ipq6018-cp01-c1: correct blspi1 pins arm64: dts: qcom: ipq6018: align TLMM pin configuration with DT schema ARM: dts: qcom: sdx55: add gpio-ranges to TLMM pinctrl ARM: dts: qcom: sdx55: align TLMM pin configuration with DT schema ARM: dts: qcom: msm8226: align TLMM pin configuration with DT schema ARM: dts: qcom: msm8974: align TLMM pin configuration with DT schema dt-bindings: pinctrl: qcom,ipq6018: add qpic_pad function dt-bindings: pinctrl: qcom,ipq6018: increase number of pins in pinmux dt-bindings: pinctrl: qcom,ipq6018: fix matching pin config dt-bindings: pinctrl: qcom,ipq6018: do not require function on non-GPIOs dt-bindings: pinctrl: qcom,ipq6018: fix indentation in example dt-bindings: pinctrl: qcom,msm8226: fix matching pin config dt-bindings: pinctrl: qcom,msm8226: do not require function on non-GPIOs dt-bindings: pinctrl: qcom,msm8226: add functions and input-enable dt-bindings: pinctrl: qcom,msm8226: fix indentation in example dt-bindings: pinctrl: qcom,msm8909-tlmm: fix matching pin config dt-bindings: pinctrl: qcom,msm8909-tlmm: do not require function on non-GPIOs dt-bindings: pinctrl: qcom,msm8909-tlmm: fix indentation in example dt-bindings: pinctrl: qcom,msm8953: fix matching pin config dt-bindings: pinctrl: qcom,msm8953: do not require function on non-GPIOs dt-bindings: pinctrl: qcom,msm8953: fix indentation in example dt-bindings: pinctrl: qcom,mdm9607: do not require function on non-GPIOs dt-bindings: pinctrl: qcom,mdm9607: fix indentation in example dt-bindings: pinctrl: qcom,qcm2290: fix matching pin config dt-bindings: pinctrl: qcom,qcm2290: do not require function on non-GPIOs dt-bindings: pinctrl: qcom,sdx55: fix matching pin config dt-bindings: pinctrl: qcom,sdx55: do not require function on non-GPIOs dt-bindings: pinctrl: qcom,sdx55: fix indentation in example dt-bindings: pinctrl: qcom,sdx65: fix matching pin config dt-bindings: pinctrl: qcom,sdx65: do not require function on non-GPIOs dt-bindings: pinctrl: qcom,sc7280: fix matching pin config dt-bindings: pinctrl: qcom,sc8280xp: fix indentation in example (remaining piece) .../pinctrl/qcom,ipq6018-pinctrl.yaml | 67 ++++++++++------- .../pinctrl/qcom,mdm9607-pinctrl.yaml | 34 +++++---- .../pinctrl/qcom,msm8226-pinctrl.yaml | 70 ++++++++++------- .../bindings/pinctrl/qcom,msm8909-tlmm.yaml | 75 +++++++++++-------- .../pinctrl/qcom,msm8953-pinctrl.yaml | 58 ++++++++------ .../pinctrl/qcom,qcm2290-pinctrl.yaml | 20 +++-- .../bindings/pinctrl/qcom,sc7280-pinctrl.yaml | 14 +++- .../pinctrl/qcom,sc8280xp-pinctrl.yaml | 4 +- .../bindings/pinctrl/qcom,sdx55-pinctrl.yaml | 58 ++++++++------ .../bindings/pinctrl/qcom,sdx65-pinctrl.yaml | 20 +++-- arch/arm/boot/dts/qcom-apq8026-lg-lenok.dts | 6 +- arch/arm/boot/dts/qcom-msm8226.dtsi | 24 +++--- .../qcom-msm8974-lge-nexus5-hammerhead.dts | 30 ++++---- .../boot/dts/qcom-sdx55-telit-fn980-tlb.dts | 45 ++++------- arch/arm/boot/dts/qcom-sdx55.dtsi | 1 + arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dts | 8 +- arch/arm64/boot/dts/qcom/ipq6018.dtsi | 4 +- 17 files changed, 316 insertions(+), 222 deletions(-)