| Message ID | 20220922195651.345369-1-krzysztof.kozlowski@linaro.org |
|---|---|
| Headers | show |
| Series | pinctrl/arm64: qcom: continued - fix Qualcomm LPASS pinctrl schema warnings | expand |
On Thu, Sep 22, 2022 at 09:56:40PM +0200, Krzysztof Kozlowski wrote: > Fix double ']' in GPIO pattern to properly match "pins" property. > Otherwise schema for pins state is not applied. Huh? The schema is applied, but would fail, right? Perhaps the example should have some child nodes to demonstrate this. > > Fixes: 958bb025f5b3 ("dt-bindings: pinctrl: qcom: Add sc8280xp lpass lpi pinctrl bindings") > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- > .../bindings/pinctrl/qcom,sc8280xp-lpass-lpi-pinctrl.yaml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sc8280xp-lpass-lpi-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sc8280xp-lpass-lpi-pinctrl.yaml > index 1f468303bb08..fb3ad6c0d80e 100644 > --- a/Documentation/devicetree/bindings/pinctrl/qcom,sc8280xp-lpass-lpi-pinctrl.yaml > +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sc8280xp-lpass-lpi-pinctrl.yaml > @@ -58,7 +58,7 @@ patternProperties: > List of gpio pins affected by the properties specified in this > subnode. > items: > - pattern: "^gpio([0-1]|1[0-8]])$" > + pattern: "^gpio([0-1]|1[0-8])$" > > function: > enum: [ swr_tx_clk, swr_tx_data, swr_rx_clk, swr_rx_data, > -- > 2.34.1 > >
On Thu, 22 Sep 2022 21:56:43 +0200, Krzysztof Kozlowski wrote: > The LPASS pin controller follows generic pin-controller bindings, so > just like TLMM, should have subnodes with '-state' and '-pins'. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- > .../qcom,sc8280xp-lpass-lpi-pinctrl.yaml | 29 +++++++++++++++++-- > 1 file changed, 27 insertions(+), 2 deletions(-) > Reviewed-by: Rob Herring <robh@kernel.org>
On Thu, 22 Sep 2022 21:56:45 +0200, Krzysztof Kozlowski wrote: > The LPASS pin controller follows generic pin-controller bindings, so > just like TLMM, should have subnodes with '-state' and '-pins'. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- > .../qcom,sm8450-lpass-lpi-pinctrl.yaml | 36 +++++++++++++++++-- > 1 file changed, 34 insertions(+), 2 deletions(-) > Reviewed-by: Rob Herring <robh@kernel.org>
On Thu, 22 Sep 2022 21:56:46 +0200, Krzysztof Kozlowski wrote: > The existing SC7280 LPASS pin controller nodes use bias-bus-hold, so > allow it. Squash also blank lines for readability. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- > .../bindings/pinctrl/qcom,sc7280-lpass-lpi-pinctrl.yaml | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > Acked-by: Rob Herring <robh@kernel.org>
On Mon, Sep 26, 2022 at 3:33 PM Rob Herring <robh@kernel.org> wrote: > > On Thu, Sep 22, 2022 at 09:56:40PM +0200, Krzysztof Kozlowski wrote: > > Fix double ']' in GPIO pattern to properly match "pins" property. > > Otherwise schema for pins state is not applied. > > Huh? The schema is applied, but would fail, right? > > Perhaps the example should have some child nodes to demonstrate this. NM, I see you've done that in subsequent patches. So other than the confusing commit msg: Acked-by: Rob Herring <robh@kernel.org>
On Thu, Sep 22, 2022 at 09:56:41PM +0200, Krzysztof Kozlowski wrote: > Fix double ']' in GPIO pattern to properly match "pins" property. > Otherwise schema for pins state is not applied. > > Fixes: 4faa4e73011d ("dt-bindings: pinctrl: qcom: Add sm8450 lpass lpi pinctrl bindings") > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- > .../bindings/pinctrl/qcom,sm8450-lpass-lpi-pinctrl.yaml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Other than the same confusing commit msg: Acked-by: Rob Herring <robh@kernel.org>
On 26/09/2022 22:40, Rob Herring wrote: > On Mon, Sep 26, 2022 at 3:33 PM Rob Herring <robh@kernel.org> wrote: >> >> On Thu, Sep 22, 2022 at 09:56:40PM +0200, Krzysztof Kozlowski wrote: >>> Fix double ']' in GPIO pattern to properly match "pins" property. >>> Otherwise schema for pins state is not applied. >> >> Huh? The schema is applied, but would fail, right? >> >> Perhaps the example should have some child nodes to demonstrate this. > > NM, I see you've done that in subsequent patches. So other than the > confusing commit msg: > > Acked-by: Rob Herring <robh@kernel.org> Yes, I'll adjust the commit msg. Best regards, Krzysztof
On Thu, Sep 22, 2022 at 9:56 PM Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
> Set of fixes for LPASS (audio) pin controller bindings and DTS.
I certainly trust you with this stuff.
Once you feel confident with the long series, please send me
pull request(s) based on v6.1-rc1 with the binding stuff for these,
thanks!
Yours,
Linus Walleij
Hi, Set of fixes for LPASS (audio) pin controller bindings and DTS. Dependencies ============ 1. dt-bindings are independent of DTS patches. Best regards, Krzysztof Krzysztof Kozlowski (12): dt-bindings: pinctrl: qcom,sc8280xp-lpass-lpi: fix gpio pattern dt-bindings: pinctrl: qcom,sm8450-lpass-lpi: fix gpio pattern dt-bindings: pinctrl: qcom,sc7280-lpass-lpi: fix matching pin config dt-bindings: pinctrl: qcom,sc8280xp-lpass-lpi: fix matching pin config dt-bindings: pinctrl: qcom,sm8250-lpass-lpi: fix matching pin config dt-bindings: pinctrl: qcom,sm8450-lpass-lpi: fix matching pin config dt-bindings: pinctrl: qcom,sc7280-lpass-lpi: add bias-bus-hold dt-bindings: pinctrl: qcom,sm8250-lpass-lpi: add bias-bus-hold and input-enable arm64: dts: qcom: sc7280: drop clock-cells from LPASS TLMM arm64: dts: qcom: sc7280: align LPASS pin configuration with DT schema arm64: dts: qcom: sm8250: correct LPASS pin pull down arm64: dts: qcom: sm8250: align LPASS pin configuration with DT schema .../qcom,sc7280-lpass-lpi-pinctrl.yaml | 34 +++++++++++--- .../qcom,sc8280xp-lpass-lpi-pinctrl.yaml | 31 +++++++++++-- .../qcom,sm8250-lpass-lpi-pinctrl.yaml | 42 ++++++++++++++--- .../qcom,sm8450-lpass-lpi-pinctrl.yaml | 38 +++++++++++++-- arch/arm64/boot/dts/qcom/sc7280.dtsi | 34 +++++++------- arch/arm64/boot/dts/qcom/sm8250.dtsi | 46 +++++++++---------- 6 files changed, 166 insertions(+), 59 deletions(-)