diff mbox series

[v4,7/7] acpi/x86: s2idle: Add a quirk for ASUSTeK COMPUTER INC. ROG Flow X13

Message ID 20220921204055.22889-8-mario.limonciello@amd.com
State Accepted
Commit 631b54519e8e58758e4541756c1818dcebd2dcc9
Headers show
Series Fixups for s2idle on various Rembrandt laptops | expand

Commit Message

Mario Limonciello Sept. 21, 2022, 8:40 p.m. UTC 
ASUSTeK COMPUTER INC. ROG Flow X13 has a problem with fans upon wakeup from
s2idle. In examining the ASL, functions 3 and 4 are not called in the AMD
codepath but only in the Microsoft codepath.

Add the system to the quirk list to force Microsoft codepath.

Link: https://gitlab.freedesktop.org/drm/amd/-/issues/2148
Tested-by: short-circuit <davidedp91@gmail.com>
Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
---
v3->v4:
 * Absorb tag
v2->v3:
 * New patch
---
 drivers/acpi/x86/s2idle.c | 11 +++++++++++
 1 file changed, 11 insertions(+)

Comments

Luke D. Jones Sept. 27, 2022, 9:06 a.m. UTC | #1 
Hello Mario,

I have confirmed that another suspect ASUS laptop requires the quirk,
patch is as follows:


---
 drivers/acpi/x86/s2idle.c | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/drivers/acpi/x86/s2idle.c b/drivers/acpi/x86/s2idle.c
index 2cd381f6c002..c811eeed42cd 100644
--- a/drivers/acpi/x86/s2idle.c
+++ b/drivers/acpi/x86/s2idle.c
@@ -428,6 +428,16 @@ static const struct dmi_system_id
s2idle_dmi_table[] __initconst = {
 			DMI_MATCH(DMI_PRODUCT_NAME, "ROG Zephyrus G14
GA402"),
 		},
 	},
+	{
+		/*
+		 * ASUS ROG Flow X16 - GV601
+		 */
+		.callback = lps0_prefer_microsoft,
+		.matches = {
+			DMI_MATCH(DMI_BOARD_VENDOR, "ASUSTeK COMPUTER
INC."),
+			DMI_MATCH(DMI_PRODUCT_NAME, "GV601"),
+		},
+	},
 	{}
 };
Mario Limonciello Sept. 27, 2022, 4:07 p.m. UTC | #2 
On 9/27/2022 04:06, Luke Jones wrote:
> Hello Mario,
> 
> I have confirmed that another suspect ASUS laptop requires the quirk,
> patch is as follows:
> 
> 
> ---
>   drivers/acpi/x86/s2idle.c | 12 ++++++++++++
>   1 file changed, 12 insertions(+)
> 
> diff --git a/drivers/acpi/x86/s2idle.c b/drivers/acpi/x86/s2idle.c
> index 2cd381f6c002..c811eeed42cd 100644
> --- a/drivers/acpi/x86/s2idle.c
> +++ b/drivers/acpi/x86/s2idle.c
> @@ -428,6 +428,16 @@ static const struct dmi_system_id
> s2idle_dmi_table[] __initconst = {
>   			DMI_MATCH(DMI_PRODUCT_NAME, "ROG Zephyrus G14
> GA402"),
>   		},
>   	},
> +	{
> +		/*
> +		 * ASUS ROG Flow X16 - GV601
> +		 */
> +		.callback = lps0_prefer_microsoft,
> +		.matches = {
> +			DMI_MATCH(DMI_BOARD_VENDOR, "ASUSTeK COMPUTER
> INC."),
> +			DMI_MATCH(DMI_PRODUCT_NAME, "GV601"),
> +		},
> +	},
>   	{}
>   };
>   

Hey Luke,

The series that was under development has been merged for 6.1.  At this 
point, can you just make a proper patch with a S-o-b on top of 
linux-pm/bleeding-edge for the new model to add to the list and send it out?

In addition to that, if you can please add a Link: to the acpidump and 
dmesg if available?

Thanks
Luke D. Jones Sept. 27, 2022, 8 p.m. UTC | #3 
On Tue, 2022-09-27 at 11:07 -0500, Limonciello, Mario wrote:
> On 9/27/2022 04:06, Luke Jones wrote:
> > Hello Mario,
> > 
> > I have confirmed that another suspect ASUS laptop requires the
> > quirk,
> > patch is as follows:
> > 
> > 
> > ---
> >   drivers/acpi/x86/s2idle.c | 12 ++++++++++++
> >   1 file changed, 12 insertions(+)
> > 
> > diff --git a/drivers/acpi/x86/s2idle.c b/drivers/acpi/x86/s2idle.c
> > index 2cd381f6c002..c811eeed42cd 100644
> > --- a/drivers/acpi/x86/s2idle.c
> > +++ b/drivers/acpi/x86/s2idle.c
> > @@ -428,6 +428,16 @@ static const struct dmi_system_id
> > s2idle_dmi_table[] __initconst = {
> >                         DMI_MATCH(DMI_PRODUCT_NAME, "ROG Zephyrus
> > G14
> > GA402"),
> >                 },
> >         },
> > +       {
> > +               /*
> > +                * ASUS ROG Flow X16 - GV601
> > +                */
> > +               .callback = lps0_prefer_microsoft,
> > +               .matches = {
> > +                       DMI_MATCH(DMI_BOARD_VENDOR, "ASUSTeK
> > COMPUTER
> > INC."),
> > +                       DMI_MATCH(DMI_PRODUCT_NAME, "GV601"),
> > +               },
> > +       },
> >         {}
> >   };
> >   
> 
> Hey Luke,
> 
> The series that was under development has been merged for 6.1.  At
> this 
> point, can you just make a proper patch with a S-o-b on top of 
> linux-pm/bleeding-edge for the new model to add to the list and send
> it out?
> 
> In addition to that, if you can please add a Link: to the acpidump
> and 
> dmesg if available?
> 
> Thanks

Sure no problem at all
diff mbox series

Patch

diff --git a/drivers/acpi/x86/s2idle.c b/drivers/acpi/x86/s2idle.c
index c811eeed42cd..eedd21d8a284 100644
--- a/drivers/acpi/x86/s2idle.c
+++ b/drivers/acpi/x86/s2idle.c
@@ -440,6 +440,17 @@  static const struct dmi_system_id s2idle_dmi_table[] __initconst = {
 			DMI_MATCH(DMI_PRODUCT_NAME, "82"),
 		},
 	},
+	{
+		/*
+		 * ASUSTeK COMPUTER INC. ROG Flow X13 GV301RE_GV301RE
+		 * https://gitlab.freedesktop.org/drm/amd/-/issues/2148
+		 */
+		.callback = lps0_prefer_microsoft,
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
+			DMI_MATCH(DMI_PRODUCT_NAME, "ROG Flow X13 GV301"),
+		},
+	},
 	{}
 };