| Message ID | 20220927100347.176606-7-jean-philippe@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | hw/arm/virt: Fix dt-schema warnings | expand |
On Tue, 27 Sept 2022 at 11:12, Jean-Philippe Brucker <jean-philippe@linaro.org> wrote: > > The SMMUv3 node isn't expected to have clock properties. Fix the > corresponding dt-validate warning: > > smmuv3@9050000: 'clock-names', 'clocks' do not match any of the regexes: 'pinctrl-[0-9]+' > From schema: linux/Documentation/devicetree/bindings/iommu/arm,smmu-v3.yaml > > Signed-off-by: Jean-Philippe Brucker <jean-philippe@linaro.org> > --- > hw/arm/virt.c | 2 -- > 1 file changed, 2 deletions(-) > Reviewed-by: Peter Maydell <peter.maydell@linaro.org> thanks -- PMM
Hi Jean, you may add: as opposed to SMMUv2, ... > The SMMUv3 node isn't expected to have clock properties. Fix the > corresponding dt-validate warning: > > smmuv3@9050000: 'clock-names', 'clocks' do not match any of the regexes: 'pinctrl-[0-9]+' > From schema: linux/Documentation/devicetree/bindings/iommu/arm,smmu-v3.yaml > > Signed-off-by: Jean-Philippe Brucker <jean-philippe@linaro.org> Reviewed-by: Eric Auger <eric.auger@redhat.com> Thanks! Eric > --- > hw/arm/virt.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/hw/arm/virt.c b/hw/arm/virt.c > index 10ce66c722..2de16f6324 100644 > --- a/hw/arm/virt.c > +++ b/hw/arm/virt.c > @@ -1362,8 +1362,6 @@ static void create_smmu(const VirtMachineState *vms, > qemu_fdt_setprop(ms->fdt, node, "interrupt-names", irq_names, > sizeof(irq_names)); > > - qemu_fdt_setprop_cell(ms->fdt, node, "clocks", vms->clock_phandle); > - qemu_fdt_setprop_string(ms->fdt, node, "clock-names", "apb_pclk"); > qemu_fdt_setprop(ms->fdt, node, "dma-coherent", NULL, 0); > > qemu_fdt_setprop_cell(ms->fdt, node, "#iommu-cells", 1);
diff --git a/hw/arm/virt.c b/hw/arm/virt.c index 10ce66c722..2de16f6324 100644 --- a/hw/arm/virt.c +++ b/hw/arm/virt.c @@ -1362,8 +1362,6 @@ static void create_smmu(const VirtMachineState *vms, qemu_fdt_setprop(ms->fdt, node, "interrupt-names", irq_names, sizeof(irq_names)); - qemu_fdt_setprop_cell(ms->fdt, node, "clocks", vms->clock_phandle); - qemu_fdt_setprop_string(ms->fdt, node, "clock-names", "apb_pclk"); qemu_fdt_setprop(ms->fdt, node, "dma-coherent", NULL, 0); qemu_fdt_setprop_cell(ms->fdt, node, "#iommu-cells", 1);
The SMMUv3 node isn't expected to have clock properties. Fix the corresponding dt-validate warning: smmuv3@9050000: 'clock-names', 'clocks' do not match any of the regexes: 'pinctrl-[0-9]+' From schema: linux/Documentation/devicetree/bindings/iommu/arm,smmu-v3.yaml Signed-off-by: Jean-Philippe Brucker <jean-philippe@linaro.org> --- hw/arm/virt.c | 2 -- 1 file changed, 2 deletions(-)