| Message ID | 20220924090108.166934-1-dmitry.baryshkov@linaro.org |
|---|---|
| Headers | show |
| Series | arm: dts: qcom: rename DSI PHY nodes | expand |
On 24/09/2022 12:11, Krzysztof Kozlowski wrote: > On 24/09/2022 11:00, Dmitry Baryshkov wrote: >> Historically DSI PHY device tree nodes used the dsi-phy@ names. Replace >> them with generic phy@ names. >> >> Dmitry Baryshkov (9): >> ARM: dts: qcom-apq8064: change DSI PHY node name to generic one > > dsi-phy is similar to other generic names (usb-phy, ethernet-phy) [1] so > it could stay. Is there particular need for this, like coming from DT > schema? No, there is no requirement from the DT schema. However: 1) The resent qcom DT files already use just phy@ for most of PHY nodes 2) The recommended list mentions usb-phy/ethernet-phy, but not <anything>-phy, so I'd think that those two are mostly for backwards compatibility. 3) I liked the example of sc7280 which switched all MDSS PHYs to just phy@ (this includes DSI PHY, eDP PHY and, by extension, the HDMI PHY). > > [1] > https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation > > > Best regards, > Krzysztof >
On 24/09/2022 11:20, Dmitry Baryshkov wrote: > On 24/09/2022 12:11, Krzysztof Kozlowski wrote: >> On 24/09/2022 11:00, Dmitry Baryshkov wrote: >>> Historically DSI PHY device tree nodes used the dsi-phy@ names. Replace >>> them with generic phy@ names. >>> >>> Dmitry Baryshkov (9): >>> ARM: dts: qcom-apq8064: change DSI PHY node name to generic one >> >> dsi-phy is similar to other generic names (usb-phy, ethernet-phy) [1] so >> it could stay. Is there particular need for this, like coming from DT >> schema? > > No, there is no requirement from the DT schema. However: > 1) The resent qcom DT files already use just phy@ for most of PHY nodes > 2) The recommended list mentions usb-phy/ethernet-phy, but not > <anything>-phy, so I'd think that those two are mostly for backwards > compatibility. > 3) I liked the example of sc7280 which switched all MDSS PHYs to just > phy@ (this includes DSI PHY, eDP PHY and, by extension, the HDMI PHY). Good explanation. If there is going to be resent/submit, please add it to cover letter. :) Best regards, Krzysztof
On 24/09/2022 11:01, Dmitry Baryshkov wrote: > Change DSI PHY node names from custom 'dsi-phy' to the generic 'phy'. > > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On 24/09/2022 12:29, Krzysztof Kozlowski wrote: > On 24/09/2022 11:20, Dmitry Baryshkov wrote: >> On 24/09/2022 12:11, Krzysztof Kozlowski wrote: >>> On 24/09/2022 11:00, Dmitry Baryshkov wrote: >>>> Historically DSI PHY device tree nodes used the dsi-phy@ names. Replace >>>> them with generic phy@ names. >>>> >>>> Dmitry Baryshkov (9): >>>> ARM: dts: qcom-apq8064: change DSI PHY node name to generic one >>> >>> dsi-phy is similar to other generic names (usb-phy, ethernet-phy) [1] so >>> it could stay. Is there particular need for this, like coming from DT >>> schema? >> >> No, there is no requirement from the DT schema. However: >> 1) The resent qcom DT files already use just phy@ for most of PHY nodes >> 2) The recommended list mentions usb-phy/ethernet-phy, but not >> <anything>-phy, so I'd think that those two are mostly for backwards >> compatibility. >> 3) I liked the example of sc7280 which switched all MDSS PHYs to just >> phy@ (this includes DSI PHY, eDP PHY and, by extension, the HDMI PHY). > > Good explanation. If there is going to be resent/submit, please add it > to cover letter. :) I hope, there will be no v2. For now I have included this explanation into the HDMI PHY counterpart.
On 9/24/22 4:01 AM, Dmitry Baryshkov wrote: > Change DSI PHY node names from custom 'dsi-phy' to the generic 'phy'. > > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > --- > arch/arm64/boot/dts/qcom/sdm845.dtsi | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi > index f0e286715d1b..df6427ba2284 100644 > --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi > +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi > @@ -4537,7 +4537,7 @@ dsi0_out: endpoint { > }; > }; > > - dsi0_phy: dsi-phy@ae94400 { > + dsi0_phy: phy@ae94400 { > compatible = "qcom,dsi-phy-10nm"; > reg = <0 0x0ae94400 0 0x200>, > <0 0x0ae94600 0 0x280>, > @@ -4609,7 +4609,7 @@ dsi1_out: endpoint { > }; > }; > > - dsi1_phy: dsi-phy@ae96400 { > + dsi1_phy: phy@ae96400 { > compatible = "qcom,dsi-phy-10nm"; > reg = <0 0x0ae96400 0 0x200>, > <0 0x0ae96600 0 0x280>, Tested on Lenovo Yoga C630 Tested-by: Steev Klimaszewski <steev@kali.org>