Message ID | 20220921123450.671459-1-mathias.nyman@linux.intel.com |
---|---|
Headers | show |
Series | xhci features and fixes for usb-next | expand |
On Wed, Sep 21, 2022 at 03:34:44PM +0300, Mathias Nyman wrote: > Hi Greg > > Some xhci features and fixes for usb-next. > Both fixing some possible memory leaks that are too late for usb-linus, > and simple code cleanups for usb-next Did you miss this one: https://lore.kernel.org/r/20220915011134.58400-1-liulongfang@huawei.com or was there some issue with it? thanks, greg k-h
On 22.9.2022 15.08, Greg KH wrote: > On Wed, Sep 21, 2022 at 03:34:44PM +0300, Mathias Nyman wrote: >> Hi Greg >> >> Some xhci features and fixes for usb-next. >> Both fixing some possible memory leaks that are too late for usb-linus, >> and simple code cleanups for usb-next > > Did you miss this one: > https://lore.kernel.org/r/20220915011134.58400-1-liulongfang@huawei.com > > or was there some issue with it? Got distracted while looking at it. Can be added but probably not that useful. In a host controller error (HCE) case all host activity stops, so it would make more sense to check HCE bit in timeout cases than in interrupt handler. -Mathias
On Thu, Sep 22, 2022 at 03:43:04PM +0300, Mathias Nyman wrote: > On 22.9.2022 15.08, Greg KH wrote: > > On Wed, Sep 21, 2022 at 03:34:44PM +0300, Mathias Nyman wrote: > > > Hi Greg > > > > > > Some xhci features and fixes for usb-next. > > > Both fixing some possible memory leaks that are too late for usb-linus, > > > and simple code cleanups for usb-next > > > > Did you miss this one: > > https://lore.kernel.org/r/20220915011134.58400-1-liulongfang@huawei.com > > > > or was there some issue with it? > > Got distracted while looking at it. > > Can be added but probably not that useful. > > In a host controller error (HCE) case all host activity stops, so it would > make more sense to check HCE bit in timeout cases than in interrupt handler. Ok, no worries, I'll drop it from my review queue, but you should respond to the patch submission with this information. thanks, greg k-h