| Message ID | 20220920120802.14321-1-quic_ppareek@quicinc.com |
|---|---|
| Headers | show |
| Series | arm64: dts: qcom: add dts for sa8540p-ride board | expand |
On Tue, Sep 20, 2022 at 05:37:59PM +0530, Parikshit Pareek wrote: > This series introduces the Qualcom sa8540p-ride automotive development > board, also called as Qdrive-3 board. > > Changes in v4: > - Removed the ufs_card_hc node, as it is not mounted on Qdrive-3 board. > - Removed usb_1 related nodes, as usb1 doesn't have any port connected on > Qdrive3 board. Please include the full change log here (also for earlier versions). Also, please try to remember to CC people who have commented on earlier versions of the series when resending. > - Added Reported-by tag for Shazad(for ufs and usb_1 node removals) This is generally not how we use Reported-by tags (even if the kbuild robot sometimes gets credit for finding things during review this way). You can give credit to reviewers by for example putting their name in parentheses after the corresponding changelog entry (or just spelling out who suggested the change). > Parikshit Pareek (3): > dt-bindings: arm: qcom: Document additional sa8540p device > arm64: dts: qcom: sa8295p: move common nodes to dtsi > arm64: dts: qcom: introduce sa8540p-ride dts > > .../devicetree/bindings/arm/qcom.yaml | 1 + > arch/arm64/boot/dts/qcom/Makefile | 1 + > arch/arm64/boot/dts/qcom/sa8295p-adp.dts | 392 +----------------- > arch/arm64/boot/dts/qcom/sa8540p-adp-ride.dts | 15 + > .../{sa8295p-adp.dts => sa8540p-adp.dtsi} | 0 > 5 files changed, 31 insertions(+), 378 deletions(-) > rewrite arch/arm64/boot/dts/qcom/sa8295p-adp.dts (96%) > create mode 100644 arch/arm64/boot/dts/qcom/sa8540p-adp-ride.dts > copy arch/arm64/boot/dts/qcom/{sa8295p-adp.dts => sa8540p-adp.dtsi} (100%) Johan
On Tue, Sep 20, 2022 at 05:38:02PM +0530, Parikshit Pareek wrote: > Create new dts file specific for Qdrive board based on sa8540p chipset. > Introduce common dtsi file sa8295p-adp.dtsi, to be included for adp and > Qdrive board. > > This is quite similar to sa8295 ADP development board. Main differences > are related to connectors, and interface cards, like USB external ports, > ethernet-switch, and PCIe switch etc. > > Signed-off-by: Parikshit Pareek <quic_ppareek@quicinc.com> > Reported-by: Shazad Hussain <quic_shazhuss@quicinc.com> > --- > diff --git a/arch/arm64/boot/dts/qcom/sa8540p-adp-ride.dts b/arch/arm64/boot/dts/qcom/sa8540p-adp-ride.dts > new file mode 100644 > index 000000000000..bd79866b80e1 > --- /dev/null > +++ b/arch/arm64/boot/dts/qcom/sa8540p-adp-ride.dts > @@ -0,0 +1,31 @@ > +// SPDX-License-Identifier: BSD-3-Clause > +/* > + * Copyright (c) 2021, The Linux Foundation. All rights reserved. > + * Copyright (c) 2022, Linaro Limited > + * Copyright (c) 2022, Qualcomm Innovation Center, Inc. All rights reserved. > + */ > + > +/dts-v1/; > + > +#include "sa8540p-adp.dtsi" > + > +/ { > + model = "Qualcomm SA8540 ADP"; > + compatible = "qcom,sa8540p-adp-ride", "qcom,sa8540p"; > +}; > + > +&ufs_card_hc { > + status = "disabled"; > +}; What about the UFS phy, etc? This opt-out scheme seems quite fragile. > +&usb_1 { > + status = "disabled"; > +}; > + > +&usb_1_hsphy { > + status = "disabled"; > +}; > + > +&usb_1_qmpphy { > + status = "disabled"; > +}; Johan
On Wed, Sep 21, 2022 at 08:51:32AM +0200, Johan Hovold wrote: > On Tue, Sep 20, 2022 at 05:38:02PM +0530, Parikshit Pareek wrote: > > Create new dts file specific for Qdrive board based on sa8540p chipset. > > Introduce common dtsi file sa8295p-adp.dtsi, to be included for adp and > > Qdrive board. > > > > This is quite similar to sa8295 ADP development board. Main differences > > are related to connectors, and interface cards, like USB external ports, > > ethernet-switch, and PCIe switch etc. > > > > Signed-off-by: Parikshit Pareek <quic_ppareek@quicinc.com> > > Reported-by: Shazad Hussain <quic_shazhuss@quicinc.com> > > --- > > > diff --git a/arch/arm64/boot/dts/qcom/sa8540p-adp-ride.dts b/arch/arm64/boot/dts/qcom/sa8540p-adp-ride.dts > > new file mode 100644 > > index 000000000000..bd79866b80e1 > > --- /dev/null > > +++ b/arch/arm64/boot/dts/qcom/sa8540p-adp-ride.dts > > @@ -0,0 +1,31 @@ > > +// SPDX-License-Identifier: BSD-3-Clause > > +/* > > + * Copyright (c) 2021, The Linux Foundation. All rights reserved. > > + * Copyright (c) 2022, Linaro Limited > > + * Copyright (c) 2022, Qualcomm Innovation Center, Inc. All rights reserved. > > + */ > > + > > +/dts-v1/; > > + > > +#include "sa8540p-adp.dtsi" > > + > > +/ { > > + model = "Qualcomm SA8540 ADP"; > > + compatible = "qcom,sa8540p-adp-ride", "qcom,sa8540p"; > > +}; > > + > > +&ufs_card_hc { > > + status = "disabled"; > > +}; > > What about the UFS phy, etc? Really missed that. Will add phy nodes too. > > This opt-out scheme seems quite fragile. > > > +&usb_1 { > > + status = "disabled"; > > +}; > > + > > +&usb_1_hsphy { > > + status = "disabled"; > > +}; > > + > > +&usb_1_qmpphy { > > + status = "disabled"; > > +}; > > Johan Regards, Parikshit Pareek
This series introduces the Qualcom sa8540p-ride automotive development board, also called as Qdrive-3 board. Changes in v4: - Removed the ufs_card_hc node, as it is not mounted on Qdrive-3 board. - Removed usb_1 related nodes, as usb1 doesn't have any port connected on Qdrive3 board. - Added Reported-by tag for Shazad(for ufs and usb_1 node removals) Parikshit Pareek (3): dt-bindings: arm: qcom: Document additional sa8540p device arm64: dts: qcom: sa8295p: move common nodes to dtsi arm64: dts: qcom: introduce sa8540p-ride dts .../devicetree/bindings/arm/qcom.yaml | 1 + arch/arm64/boot/dts/qcom/Makefile | 1 + arch/arm64/boot/dts/qcom/sa8295p-adp.dts | 392 +----------------- arch/arm64/boot/dts/qcom/sa8540p-adp-ride.dts | 15 + .../{sa8295p-adp.dts => sa8540p-adp.dtsi} | 0 5 files changed, 31 insertions(+), 378 deletions(-) rewrite arch/arm64/boot/dts/qcom/sa8295p-adp.dts (96%) create mode 100644 arch/arm64/boot/dts/qcom/sa8540p-adp-ride.dts copy arch/arm64/boot/dts/qcom/{sa8295p-adp.dts => sa8540p-adp.dtsi} (100%)