| Message ID | 20220908131548.48120-6-jeff@labundy.com |
|---|---|
| State | Accepted |
| Commit | 10e629d31aacb2348a1e9110c31a29e98b31ce38 |
| Headers | show |
| Series | Additional fixes for Azoteq IQS7222A/B/C | expand |
On Thu, Sep 08, 2022 at 08:15:42AM -0500, Jeff LaBundy wrote: > According to the datasheets, writing only 0xFF is sufficient to > elicit a communication window. Remove the superfluous 0x00 from > the force communication command. > > Fixes: e505edaedcb9 ("Input: add support for Azoteq IQS7222A/B/C") > Signed-off-by: Jeff LaBundy <jeff@labundy.com> Applied, thank you.
Hi Dmitry, On Thu, Sep 08, 2022 at 02:24:10PM -0700, Dmitry Torokhov wrote: > On Thu, Sep 08, 2022 at 08:15:42AM -0500, Jeff LaBundy wrote: > > According to the datasheets, writing only 0xFF is sufficient to > > elicit a communication window. Remove the superfluous 0x00 from > > the force communication command. > > > > Fixes: e505edaedcb9 ("Input: add support for Azoteq IQS7222A/B/C") > > Signed-off-by: Jeff LaBundy <jeff@labundy.com> > > Applied, thank you. I didn't happen to see this one hit your tree, so I can simply include it in v2 coming soon. In case I have misunderstood, please let me know. > > -- > Dmitry Kind regards, Jeff LaBundy
On Tue, Sep 13, 2022 at 04:24:54PM -0500, Jeff LaBundy wrote: > Hi Dmitry, > > On Thu, Sep 08, 2022 at 02:24:10PM -0700, Dmitry Torokhov wrote: > > On Thu, Sep 08, 2022 at 08:15:42AM -0500, Jeff LaBundy wrote: > > > According to the datasheets, writing only 0xFF is sufficient to > > > elicit a communication window. Remove the superfluous 0x00 from > > > the force communication command. > > > > > > Fixes: e505edaedcb9 ("Input: add support for Azoteq IQS7222A/B/C") > > > Signed-off-by: Jeff LaBundy <jeff@labundy.com> > > > > Applied, thank you. > > I didn't happen to see this one hit your tree, so I can simply include > it in v2 coming soon. In case I have misunderstood, please let me know. Should be there now. Thanks.
diff --git a/drivers/input/misc/iqs7222.c b/drivers/input/misc/iqs7222.c index ba12c49e972c..365e59f78f1a 100644 --- a/drivers/input/misc/iqs7222.c +++ b/drivers/input/misc/iqs7222.c @@ -1077,7 +1077,7 @@ static int iqs7222_hard_reset(struct iqs7222_private *iqs7222) static int iqs7222_force_comms(struct iqs7222_private *iqs7222) { - u8 msg_buf[] = { 0xFF, 0x00, }; + u8 msg_buf[] = { 0xFF, }; int ret; /*
According to the datasheets, writing only 0xFF is sufficient to elicit a communication window. Remove the superfluous 0x00 from the force communication command. Fixes: e505edaedcb9 ("Input: add support for Azoteq IQS7222A/B/C") Signed-off-by: Jeff LaBundy <jeff@labundy.com> --- drivers/input/misc/iqs7222.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)