| Message ID | 20220731100228.32920-1-hdegoede@redhat.com |
|---|---|
| State | Accepted |
| Commit | 04f7c7df96de7a2e9a72e53e8082754b13495813 |
| Headers | show |
| Series | power: supply: bq25890: Disable PUMPX_EN on errors | expand |
Hi, On Sun, Jul 31, 2022 at 12:02:28PM +0200, Hans de Goede wrote: > When bq25890_pump_express_work encounters an errors disable > the PUMPX_EN flag, just like the work does on a successful exit. > > Signed-off-by: Hans de Goede <hdegoede@redhat.com> > --- Thanks, queued to power-supply's for-next branch. -- Sebastian > drivers/power/supply/bq25890_charger.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/power/supply/bq25890_charger.c b/drivers/power/supply/bq25890_charger.c > index 852a6fec4339..056260b2cb76 100644 > --- a/drivers/power/supply/bq25890_charger.c > +++ b/drivers/power/supply/bq25890_charger.c > @@ -946,6 +946,7 @@ static void bq25890_pump_express_work(struct work_struct *data) > > return; > error_print: > + bq25890_field_write(bq, F_PUMPX_EN, 0); > dev_err(bq->dev, "Failed to request hi-voltage charging\n"); > } > > -- > 2.37.1 >
diff --git a/drivers/power/supply/bq25890_charger.c b/drivers/power/supply/bq25890_charger.c index 852a6fec4339..056260b2cb76 100644 --- a/drivers/power/supply/bq25890_charger.c +++ b/drivers/power/supply/bq25890_charger.c @@ -946,6 +946,7 @@ static void bq25890_pump_express_work(struct work_struct *data) return; error_print: + bq25890_field_write(bq, F_PUMPX_EN, 0); dev_err(bq->dev, "Failed to request hi-voltage charging\n"); }
When bq25890_pump_express_work encounters an errors disable the PUMPX_EN flag, just like the work does on a successful exit. Signed-off-by: Hans de Goede <hdegoede@redhat.com> --- drivers/power/supply/bq25890_charger.c | 1 + 1 file changed, 1 insertion(+)