mbox series

[00/11] qcom,mdss-dsi-ctrl: Remove redundant phy-names from yaml and dtsi

Message ID 20220907000105.786265-1-bryan.odonoghue@linaro.org
Headers show
Series qcom,mdss-dsi-ctrl: Remove redundant phy-names from yaml and dtsi | expand

Message

Bryan O'Donoghue Sept. 7, 2022, midnight UTC
phy-names is both inconsistently used and not actually required by the driver.

Previous discussion with Krzysztof and Rob suggested to remove the property.

https://www.spinics.net/lists/linux-arm-msm/msg116525.html

- Mark as deprecated and not required in yaml
- Drop from associated dtsi files => grep -r mdss-dsi arch/arm* | grep qcom

Bryan O'Donoghue (11):
  dt-bindings: msm: dsi-controller-main: Drop redundant phy-names
  ARM: dts: qcom: apq8064: Drop redundant phy-names from DSI controller
  ARM: dts: qcom: msm8974: Drop redundant phy-names from DSI controller
  arm64: dts: qcom: msm8916: Drop redundant phy-names from DSI
    controller
  arm64: dts: qcom: msm8996: Drop redundant phy-names from DSI
    controller
  arm64: dts: qcom: sc7180: Drop redundant phy-names from DSI controller
  arm64: dts: qcom: sc7280: Drop redundant phy-names from DSI controller
  arm64: dts: qcom: sdm660: Drop redundant phy-names from DSI controller
  arm64: dts: qcom: sdm630: Drop redundant phy-names from DSI controller
  arm64: dts: qcom: sdm845: Drop redundant phy-names from DSI controller
  arm64: dts: qcom: sm8250: Drop redundant phy-names from DSI controller

 .../devicetree/bindings/display/msm/dsi-controller-main.yaml    | 2 +-
 arch/arm/boot/dts/qcom-apq8064.dtsi                             | 1 -
 arch/arm/boot/dts/qcom-msm8974.dtsi                             | 1 -
 arch/arm64/boot/dts/qcom/msm8916.dtsi                           | 1 -
 arch/arm64/boot/dts/qcom/msm8996.dtsi                           | 2 --
 arch/arm64/boot/dts/qcom/sc7180.dtsi                            | 1 -
 arch/arm64/boot/dts/qcom/sc7280.dtsi                            | 1 -
 arch/arm64/boot/dts/qcom/sdm630.dtsi                            | 1 -
 arch/arm64/boot/dts/qcom/sdm660.dtsi                            | 1 -
 arch/arm64/boot/dts/qcom/sdm845.dtsi                            | 2 --
 arch/arm64/boot/dts/qcom/sm8250.dtsi                            | 2 --
 11 files changed, 1 insertion(+), 14 deletions(-)

Comments

Krzysztof Kozlowski Sept. 8, 2022, 2:11 p.m. UTC | #1
On 07/09/2022 02:00, Bryan O'Donoghue wrote:
> Adding in msm8939 which is based msm8916 dtsi I stumbled across a binding
> check complaining about the phy name for msm8916 which we were reusing for
> msm8939.
> 
> The currently inconsistent upstream dtsi naming of "dsi" and "dsi-phy" is
> not captured in the yaml for this driver.
> 
> The driver however doesn't care about the name of DSI phy, hence the yaml
> check is redundant.
> 
> Both Krzysztof and Rob suggested we could drop the phy-names entirely if it
> really isn't a dependency.
> 
> So, drop the inconsistent and unnecessary phy-names field from the yaml.
> 
> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>


Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>


Best regards,
Krzysztof
Krzysztof Kozlowski Sept. 8, 2022, 2:12 p.m. UTC | #2
On 07/09/2022 02:00, Bryan O'Donoghue wrote:
> phy-names has been marked deprecated. Remove it from the msm8974 DSI
> controller block.
> 
> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
> ---


Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>


Best regards,
Krzysztof
Krzysztof Kozlowski Sept. 8, 2022, 2:12 p.m. UTC | #3
On 07/09/2022 02:00, Bryan O'Donoghue wrote:
> phy-names has been marked deprecated. Remove it from the msm8996 DSI
> controller block.
> 
> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>


Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>


Best regards,
Krzysztof
Krzysztof Kozlowski Sept. 8, 2022, 2:12 p.m. UTC | #4
On 07/09/2022 02:01, Bryan O'Donoghue wrote:
> phy-names has been marked deprecated. Remove it from the sc7280 DSI
> controller block.
> 
> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
> ---


Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>


Best regards,
Krzysztof
Krzysztof Kozlowski Sept. 8, 2022, 2:13 p.m. UTC | #5
On 07/09/2022 02:01, Bryan O'Donoghue wrote:
> phy-names has been marked deprecated. Remove it from the sdm630 DSI
> controller block.
> 
> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>


Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>


Best regards,
Krzysztof
Krzysztof Kozlowski Sept. 8, 2022, 2:13 p.m. UTC | #6
On 07/09/2022 02:01, Bryan O'Donoghue wrote:
> phy-names has been marked deprecated. Remove it from the sm8250 DSI
> controller block.
> 


Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>


Best regards,
Krzysztof
Dmitry Baryshkov Sept. 8, 2022, 10:31 p.m. UTC | #7
On 07/09/2022 03:00, Bryan O'Donoghue wrote:
> Adding in msm8939 which is based msm8916 dtsi I stumbled across a binding
> check complaining about the phy name for msm8916 which we were reusing for
> msm8939.
> 
> The currently inconsistent upstream dtsi naming of "dsi" and "dsi-phy" is
> not captured in the yaml for this driver.
> 
> The driver however doesn't care about the name of DSI phy, hence the yaml
> check is redundant.
> 
> Both Krzysztof and Rob suggested we could drop the phy-names entirely if it
> really isn't a dependency.
> 
> So, drop the inconsistent and unnecessary phy-names field from the yaml.
> 
> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>

> ---
>   .../devicetree/bindings/display/msm/dsi-controller-main.yaml    | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml b/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml
> index 880bfe930830c..3742e2ab4fb1d 100644
> --- a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml
> +++ b/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml
> @@ -49,6 +49,7 @@ properties:
>       maxItems: 1
>   
>     phy-names:
> +    deprecated: true
>       const: dsi
>   
>     "#address-cells": true
> @@ -133,7 +134,6 @@ required:
>     - clocks
>     - clock-names
>     - phys
> -  - phy-names
>     - assigned-clocks
>     - assigned-clock-parents
>     - power-domains
Bryan O'Donoghue Sept. 26, 2022, 11:18 a.m. UTC | #8
On 07/09/2022 01:00, Bryan O'Donoghue wrote:
> phy-names is both inconsistently used and not actually required by the driver.
> 
> Previous discussion with Krzysztof and Rob suggested to remove the property.
> 
> https://www.spinics.net/lists/linux-arm-msm/msg116525.html
> 
> - Mark as deprecated and not required in yaml
> - Drop from associated dtsi files => grep -r mdss-dsi arch/arm* | grep qcom
> 
> Bryan O'Donoghue (11):
>    dt-bindings: msm: dsi-controller-main: Drop redundant phy-names
>    ARM: dts: qcom: apq8064: Drop redundant phy-names from DSI controller
>    ARM: dts: qcom: msm8974: Drop redundant phy-names from DSI controller
>    arm64: dts: qcom: msm8916: Drop redundant phy-names from DSI
>      controller
>    arm64: dts: qcom: msm8996: Drop redundant phy-names from DSI
>      controller
>    arm64: dts: qcom: sc7180: Drop redundant phy-names from DSI controller
>    arm64: dts: qcom: sc7280: Drop redundant phy-names from DSI controller
>    arm64: dts: qcom: sdm660: Drop redundant phy-names from DSI controller
>    arm64: dts: qcom: sdm630: Drop redundant phy-names from DSI controller
>    arm64: dts: qcom: sdm845: Drop redundant phy-names from DSI controller
>    arm64: dts: qcom: sm8250: Drop redundant phy-names from DSI controller
> 
>   .../devicetree/bindings/display/msm/dsi-controller-main.yaml    | 2 +-
>   arch/arm/boot/dts/qcom-apq8064.dtsi                             | 1 -
>   arch/arm/boot/dts/qcom-msm8974.dtsi                             | 1 -
>   arch/arm64/boot/dts/qcom/msm8916.dtsi                           | 1 -
>   arch/arm64/boot/dts/qcom/msm8996.dtsi                           | 2 --
>   arch/arm64/boot/dts/qcom/sc7180.dtsi                            | 1 -
>   arch/arm64/boot/dts/qcom/sc7280.dtsi                            | 1 -
>   arch/arm64/boot/dts/qcom/sdm630.dtsi                            | 1 -
>   arch/arm64/boot/dts/qcom/sdm660.dtsi                            | 1 -
>   arch/arm64/boot/dts/qcom/sdm845.dtsi                            | 2 --
>   arch/arm64/boot/dts/qcom/sm8250.dtsi                            | 2 --
>   11 files changed, 1 insertion(+), 14 deletions(-)
> 

Ping.

https://lore.kernel.org/lkml/20220925172443.92900-1-luca@z3ntu.xyz/T/

---
bod