diff mbox series

USB: hcd: remove unused hcd_name variables

Message ID 20220831073032.1409291-1-gregkh@linuxfoundation.org
State New
Headers show
Series USB: hcd: remove unused hcd_name variables | expand

Commit Message

Greg KH Aug. 31, 2022, 7:30 a.m. UTC
In the commit 10174220f55a ("usb: reduce kernel log spam on driver
registration") a lot of unneeded kernel log messages were removed, but
that caused a few build warnings to show up where the variable
`hcd_name` was being set but never used anymore.

Resolve this by just removing these variables as they are not needed
anymore

Reported-by: kernel test robot <lkp@intel.com>
Cc: Ard Biesheuvel <ardb@kernel.org>
Cc: Alan Stern <stern@rowland.harvard.edu>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Alim Akhtar <alim.akhtar@samsung.com>
Cc: Rob Herring <robh@kernel.org>
Cc: linux-usb@vger.kernel.org
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-samsung-soc@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Fixes: 10174220f55a ("usb: reduce kernel log spam on driver registration")
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
 drivers/usb/host/ehci-exynos.c   | 1 -
 drivers/usb/host/ehci-platform.c | 2 --
 drivers/usb/host/ohci-platform.c | 2 --
 3 files changed, 5 deletions(-)

Comments

Alan Stern Aug. 31, 2022, 2:21 p.m. UTC | #1
On Wed, Aug 31, 2022 at 09:30:32AM +0200, Greg Kroah-Hartman wrote:
> In the commit 10174220f55a ("usb: reduce kernel log spam on driver
> registration") a lot of unneeded kernel log messages were removed, but
> that caused a few build warnings to show up where the variable
> `hcd_name` was being set but never used anymore.
> 
> Resolve this by just removing these variables as they are not needed
> anymore
> 
> Reported-by: kernel test robot <lkp@intel.com>
> Cc: Ard Biesheuvel <ardb@kernel.org>
> Cc: Alan Stern <stern@rowland.harvard.edu>
> Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Cc: Alim Akhtar <alim.akhtar@samsung.com>
> Cc: Rob Herring <robh@kernel.org>
> Cc: linux-usb@vger.kernel.org
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: linux-samsung-soc@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> Fixes: 10174220f55a ("usb: reduce kernel log spam on driver registration")
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> ---
>  drivers/usb/host/ehci-exynos.c   | 1 -
>  drivers/usb/host/ehci-platform.c | 2 --
>  drivers/usb/host/ohci-platform.c | 2 --
>  3 files changed, 5 deletions(-)

This isn't enough, as you can see from this kernel test robot excerpt:

clang_recent_errors
|-- arm-s5pv210_defconfig
|   |-- drivers-usb-host-ehci-exynos.c:warning:unused-variable-hcd_name
|   `-- drivers-usb-host-ohci-exynos.c:warning:unused-variable-hcd_name
|-- hexagon-randconfig-r024-20220830
|   |-- drivers-usb-host-ehci-atmel.c:warning:unused-variable-hcd_name
|   |-- drivers-usb-host-ehci-exynos.c:warning:unused-variable-hcd_name
|   |-- drivers-usb-host-ehci-orion.c:warning:unused-variable-hcd_name
|   |-- 
drivers-usb-host-ehci-platform.c:warning:unused-variable-hcd_name
|   |-- drivers-usb-host-ehci-spear.c:warning:unused-variable-hcd_name
|   `-- 
drivers-usb-host-ohci-platform.c:warning:unused-variable-hcd_name
|-- hexagon-randconfig-r036-20220830
|   |-- drivers-usb-host-ehci-atmel.c:warning:unused-variable-hcd_name
|   |-- drivers-usb-host-ehci-npcm7xx.c:warning:unused-variable-hcd_name
|   |-- 
drivers-usb-host-ehci-platform.c:warning:unused-variable-hcd_name
|   |-- drivers-usb-host-ehci-st.c:warning:unused-variable-hcd_name
|   |-- drivers-usb-host-ohci-at91.c:warning:unused-variable-hcd_name
|   |-- 
drivers-usb-host-ohci-platform.c:warning:unused-variable-hcd_name
|   |-- drivers-usb-host-ohci-s3c2410.c:warning:unused-variable-hcd_name
|   |-- drivers-usb-host-ohci-spear.c:warning:unused-variable-hcd_name
|   `-- drivers-usb-host-ohci-st.c:warning:unused-variable-hcd_name

Yes, it has duplicates and your patch handles some of these.  But there 
are others that still need to be fixed.  Also, this list is missing 
ohci-pxa27x.c.

Alan Stern
Greg KH Sept. 1, 2022, 1:53 p.m. UTC | #2
On Wed, Aug 31, 2022 at 10:21:36AM -0400, Alan Stern wrote:
> On Wed, Aug 31, 2022 at 09:30:32AM +0200, Greg Kroah-Hartman wrote:
> > In the commit 10174220f55a ("usb: reduce kernel log spam on driver
> > registration") a lot of unneeded kernel log messages were removed, but
> > that caused a few build warnings to show up where the variable
> > `hcd_name` was being set but never used anymore.
> > 
> > Resolve this by just removing these variables as they are not needed
> > anymore
> > 
> > Reported-by: kernel test robot <lkp@intel.com>
> > Cc: Ard Biesheuvel <ardb@kernel.org>
> > Cc: Alan Stern <stern@rowland.harvard.edu>
> > Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> > Cc: Alim Akhtar <alim.akhtar@samsung.com>
> > Cc: Rob Herring <robh@kernel.org>
> > Cc: linux-usb@vger.kernel.org
> > Cc: linux-arm-kernel@lists.infradead.org
> > Cc: linux-samsung-soc@vger.kernel.org
> > Cc: linux-kernel@vger.kernel.org
> > Fixes: 10174220f55a ("usb: reduce kernel log spam on driver registration")
> > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > ---
> >  drivers/usb/host/ehci-exynos.c   | 1 -
> >  drivers/usb/host/ehci-platform.c | 2 --
> >  drivers/usb/host/ohci-platform.c | 2 --
> >  3 files changed, 5 deletions(-)
> 
> This isn't enough, as you can see from this kernel test robot excerpt:
> 
> clang_recent_errors
> |-- arm-s5pv210_defconfig
> |   |-- drivers-usb-host-ehci-exynos.c:warning:unused-variable-hcd_name
> |   `-- drivers-usb-host-ohci-exynos.c:warning:unused-variable-hcd_name
> |-- hexagon-randconfig-r024-20220830
> |   |-- drivers-usb-host-ehci-atmel.c:warning:unused-variable-hcd_name
> |   |-- drivers-usb-host-ehci-exynos.c:warning:unused-variable-hcd_name
> |   |-- drivers-usb-host-ehci-orion.c:warning:unused-variable-hcd_name
> |   |-- 
> drivers-usb-host-ehci-platform.c:warning:unused-variable-hcd_name
> |   |-- drivers-usb-host-ehci-spear.c:warning:unused-variable-hcd_name
> |   `-- 
> drivers-usb-host-ohci-platform.c:warning:unused-variable-hcd_name
> |-- hexagon-randconfig-r036-20220830
> |   |-- drivers-usb-host-ehci-atmel.c:warning:unused-variable-hcd_name
> |   |-- drivers-usb-host-ehci-npcm7xx.c:warning:unused-variable-hcd_name
> |   |-- 
> drivers-usb-host-ehci-platform.c:warning:unused-variable-hcd_name
> |   |-- drivers-usb-host-ehci-st.c:warning:unused-variable-hcd_name
> |   |-- drivers-usb-host-ohci-at91.c:warning:unused-variable-hcd_name
> |   |-- 
> drivers-usb-host-ohci-platform.c:warning:unused-variable-hcd_name
> |   |-- drivers-usb-host-ohci-s3c2410.c:warning:unused-variable-hcd_name
> |   |-- drivers-usb-host-ohci-spear.c:warning:unused-variable-hcd_name
> |   `-- drivers-usb-host-ohci-st.c:warning:unused-variable-hcd_name
> 
> Yes, it has duplicates and your patch handles some of these.  But there 
> are others that still need to be fixed.  Also, this list is missing 
> ohci-pxa27x.c.

Ick, ok, I went off of a different kbuild report.  Let me fix this up
later today...

greg k-h
diff mbox series

Patch

diff --git a/drivers/usb/host/ehci-exynos.c b/drivers/usb/host/ehci-exynos.c
index a65e365e3a04..c8e152c2e0ce 100644
--- a/drivers/usb/host/ehci-exynos.c
+++ b/drivers/usb/host/ehci-exynos.c
@@ -32,7 +32,6 @@ 
 	(EHCI_INSNREG00_ENA_INCR16 | EHCI_INSNREG00_ENA_INCR8 |	\
 	 EHCI_INSNREG00_ENA_INCR4 | EHCI_INSNREG00_ENA_INCRX_ALIGN)
 
-static const char hcd_name[] = "ehci-exynos";
 static struct hc_driver __read_mostly exynos_ehci_hc_driver;
 
 #define PHY_NUMBER 3
diff --git a/drivers/usb/host/ehci-platform.c b/drivers/usb/host/ehci-platform.c
index 50491eea9409..fe497c876d76 100644
--- a/drivers/usb/host/ehci-platform.c
+++ b/drivers/usb/host/ehci-platform.c
@@ -53,8 +53,6 @@  struct ehci_platform_priv {
 	struct delayed_work poll_work;
 };
 
-static const char hcd_name[] = "ehci-platform";
-
 static int ehci_platform_reset(struct usb_hcd *hcd)
 {
 	struct platform_device *pdev = to_platform_device(hcd->self.controller);
diff --git a/drivers/usb/host/ohci-platform.c b/drivers/usb/host/ohci-platform.c
index 6d56b52966c7..4e7946024ce7 100644
--- a/drivers/usb/host/ohci-platform.c
+++ b/drivers/usb/host/ohci-platform.c
@@ -41,8 +41,6 @@  struct ohci_platform_priv {
 	struct reset_control *resets;
 };
 
-static const char hcd_name[] = "ohci-platform";
-
 static int ohci_platform_power_on(struct platform_device *dev)
 {
 	struct usb_hcd *hcd = platform_get_drvdata(dev);