| Message ID | 20220825072744.229231-1-ye.xingchen@zte.com.cn |
|---|---|
| State | New |
| Headers | show |
| Series | [linux-next] ACPI: EC: Remove the unneeded result variable | expand |
On Thu, Aug 25, 2022 at 9:27 AM <cgel.zte@gmail.com> wrote: > > From: ye xingchen <ye.xingchen@zte.com.cn> > > Return the value acpi_ec_write() directly instead of storing it in > another redundant variable. > > Reported-by: Zeal Robot <zealci@zte.com.cn> > Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn> > --- > drivers/acpi/ec.c | 6 +----- > 1 file changed, 1 insertion(+), 5 deletions(-) > > diff --git a/drivers/acpi/ec.c b/drivers/acpi/ec.c > index c95e535035a0..9b42628cf21b 100644 > --- a/drivers/acpi/ec.c > +++ b/drivers/acpi/ec.c > @@ -917,14 +917,10 @@ EXPORT_SYMBOL(ec_read); > > int ec_write(u8 addr, u8 val) > { > - int err; > - > if (!first_ec) > return -ENODEV; > > - err = acpi_ec_write(first_ec, addr, val); > - > - return err; > + return acpi_ec_write(first_ec, addr, val); > } > EXPORT_SYMBOL(ec_write); > > -- Applied as 6.1 material with some edits in the subject and changelog. Thanks!
diff --git a/drivers/acpi/ec.c b/drivers/acpi/ec.c index c95e535035a0..9b42628cf21b 100644 --- a/drivers/acpi/ec.c +++ b/drivers/acpi/ec.c @@ -917,14 +917,10 @@ EXPORT_SYMBOL(ec_read); int ec_write(u8 addr, u8 val) { - int err; - if (!first_ec) return -ENODEV; - err = acpi_ec_write(first_ec, addr, val); - - return err; + return acpi_ec_write(first_ec, addr, val); } EXPORT_SYMBOL(ec_write);