mbox series

[v3,0/2] add power-supply control to enable eeprom usage

Message ID 20220828154904.20477-1-farbere@amazon.com
Headers show
Series add power-supply control to enable eeprom usage | expand

Message

Farber, Eliav Aug. 28, 2022, 3:49 p.m. UTC 
First patch describes the new binding property.
Second patch adds the functionality to the driver.

Change between v3 and v2:
- Apply on top of v6.0-rc1.

Change between v2 and v1:
- Use a gpio regulator for power-supply control.

Eliav Farber (2):
  dt-bindings: at24: add new optional power-supply property
  eeprom: at24: add support for power-supply control

 .../devicetree/bindings/eeprom/at24.yaml      |  4 ++
 drivers/misc/eeprom/at24.c                    | 40 +++++++++++++++++++
 2 files changed, 44 insertions(+)

Comments

Bartosz Golaszewski Aug. 31, 2022, 1 p.m. UTC | #1 
On Sun, Aug 28, 2022 at 5:49 PM Eliav Farber <farbere@amazon.com> wrote:
>
> First patch describes the new binding property.
> Second patch adds the functionality to the driver.
>
> Change between v3 and v2:
> - Apply on top of v6.0-rc1.
>
> Change between v2 and v1:
> - Use a gpio regulator for power-supply control.
>
> Eliav Farber (2):
>   dt-bindings: at24: add new optional power-supply property
>   eeprom: at24: add support for power-supply control
>
>  .../devicetree/bindings/eeprom/at24.yaml      |  4 ++
>  drivers/misc/eeprom/at24.c                    | 40 +++++++++++++++++++
>  2 files changed, 44 insertions(+)
>
> --
> 2.37.1
>

What is the difference between this and the existing "vcc" regulator?
Why are you going through all the hoops in probe if a regular
regulator_get() will return a dummy regulator if the supply is not
found?

Bart