mbox series

[0/7] configure: fix misc shellcheck warnings

Message ID 20220825150703.4074125-1-peter.maydell@linaro.org
Headers show
Series configure: fix misc shellcheck warnings | expand

Message

Peter Maydell Aug. 25, 2022, 3:06 p.m. UTC 
Currently if you run shellcheck on our configure script it
generates a ton of warnings. This patchset fixes some of the
easier ones. I wasn't aiming for completeness or consistency;
I just wanted to zap some of the ones where the fix is clear
and didn't take long to write and is hopefully easy to review.
We can always come back and take another swing at it later.

thanks
-- PMM

Peter Maydell (7):
  configure: Remove unused python_version variable
  configure: Remove unused meson_args variable
  configure: Add missing quoting for some easy cases
  configure: Add './' on front of glob of */config-devices.mak.d
  configure: Remove use of backtick `...` syntax
  configure: Check mkdir result directly, not via $?
  configure: Avoid use of 'local' as it is non-POSIX

 configure | 82 ++++++++++++++++++++++++++-----------------------------
 1 file changed, 38 insertions(+), 44 deletions(-)

Comments

Marc-André Lureau Aug. 26, 2022, 8:53 a.m. UTC | #1 
Hi

On Thu, Aug 25, 2022 at 7:09 PM Peter Maydell <peter.maydell@linaro.org>
wrote:

> Currently if you run shellcheck on our configure script it
> generates a ton of warnings. This patchset fixes some of the
> easier ones. I wasn't aiming for completeness or consistency;
> I just wanted to zap some of the ones where the fix is clear
> and didn't take long to write and is hopefully easy to review.
> We can always come back and take another swing at it later.
>
> thanks
> -- PMM
>
> Peter Maydell (7):
>   configure: Remove unused python_version variable
>   configure: Remove unused meson_args variable
>   configure: Add missing quoting for some easy cases
>   configure: Add './' on front of glob of */config-devices.mak.d
>   configure: Remove use of backtick `...` syntax
>   configure: Check mkdir result directly, not via $?
>   configure: Avoid use of 'local' as it is non-POSIX
>
>  configure | 82 ++++++++++++++++++++++++++-----------------------------
>  1 file changed, 38 insertions(+), 44 deletions(-)
>
> --
> 2.25.1
>
>
>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Philippe Mathieu-Daudé Aug. 30, 2022, 12:16 p.m. UTC | #2 
On 25/8/22 17:06, Peter Maydell wrote:
> Currently if you run shellcheck on our configure script it
> generates a ton of warnings. This patchset fixes some of the
> easier ones. I wasn't aiming for completeness or consistency;
> I just wanted to zap some of the ones where the fix is clear
> and didn't take long to write and is hopefully easy to review.
> We can always come back and take another swing at it later.
> 
> thanks
> -- PMM
> 
> Peter Maydell (7):
>    configure: Remove unused python_version variable
>    configure: Remove unused meson_args variable
>    configure: Add missing quoting for some easy cases
>    configure: Add './' on front of glob of */config-devices.mak.d
>    configure: Remove use of backtick `...` syntax
>    configure: Check mkdir result directly, not via $?
>    configure: Avoid use of 'local' as it is non-POSIX

Series:
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Peter Maydell Sept. 22, 2022, 2:15 p.m. UTC | #3 
On Thu, 25 Aug 2022 at 16:07, Peter Maydell <peter.maydell@linaro.org> wrote:
>
> Currently if you run shellcheck on our configure script it
> generates a ton of warnings. This patchset fixes some of the
> easier ones. I wasn't aiming for completeness or consistency;
> I just wanted to zap some of the ones where the fix is clear
> and didn't take long to write and is hopefully easy to review.
> We can always come back and take another swing at it later.
>
> thanks
> -- PMM
>
> Peter Maydell (7):
>   configure: Remove unused python_version variable
>   configure: Remove unused meson_args variable
>   configure: Add missing quoting for some easy cases
>   configure: Add './' on front of glob of */config-devices.mak.d
>   configure: Remove use of backtick `...` syntax
>   configure: Check mkdir result directly, not via $?
>   configure: Avoid use of 'local' as it is non-POSIX

Thanks to all for the review; I'll take these via target-arm.next
unless anybody has a preference otherwise.

-- PMM