| Message ID | 20220825150703.4074125-5-peter.maydell@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | configure: fix misc shellcheck warnings | expand |
On 25/8/22 17:07, Peter Maydell wrote: > Shellcheck warns that in > rm -f */config-devices.mak.d > the glob might expand to something with a '-' in it, which would > then be misinterpreted as an option to rm. Interesting, TIL. Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org> > Fix this by adding './'. > > Signed-off-by: Peter Maydell <peter.maydell@linaro.org> > --- > configure | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/configure b/configure > index 894642554c3..d5b6546ae81 100755 > --- a/configure > +++ b/configure > @@ -1093,7 +1093,7 @@ exit 0 > fi > > # Remove old dependency files to make sure that they get properly regenerated > -rm -f */config-devices.mak.d > +rm -f ./*/config-devices.mak.d > > if test -z "$python" > then
diff --git a/configure b/configure index 894642554c3..d5b6546ae81 100755 --- a/configure +++ b/configure @@ -1093,7 +1093,7 @@ exit 0 fi # Remove old dependency files to make sure that they get properly regenerated -rm -f */config-devices.mak.d +rm -f ./*/config-devices.mak.d if test -z "$python" then
Shellcheck warns that in rm -f */config-devices.mak.d the glob might expand to something with a '-' in it, which would then be misinterpreted as an option to rm. Fix this by adding './'. Signed-off-by: Peter Maydell <peter.maydell@linaro.org> --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)