mbox series

[v6,0/8] dt-bindings: YAMLify pci/qcom,pcie schema

Message ID 20220506152107.1527552-1-dmitry.baryshkov@linaro.org
Headers show
Series dt-bindings: YAMLify pci/qcom,pcie schema | expand

Message

Dmitry Baryshkov May 6, 2022, 3:20 p.m. UTC
Convert pci/qcom,pcie schema to YAML description. The first patch
introduces several warnings which are fixed by the other patches in the
series.

Note regarding the snps,dw-pcie compatibility. The Qualcomm PCIe
controller uses Synopsys PCIe IP core. However it is not just fused to
the address space. Accessing PCIe registers requires several clocks and
regulators to be powered up. Thus it can be assumed that the qcom,pcie
bindings are not fully compatible with the snps,dw-pcie schema.

Changes since v5:
 - s/stance/stanza (pointed out by Bjorn Helgaas)

Changes since v4:
 - Change subjects to follow convention (suggested by Bjorn Helgaas)

Changes since v3:
 - Rebase on linux-next to include sm8150 patches

Changes since v2 (still kudos to Krzyshtof):
 - Readded reg-names conversion patch
 - Mention wake-gpio update in the commit message
 - Remove extra quotes in the schema

Changes since v1 (all kudos to Krzyshtof):
 - Dropped the reg-names patch. It will be handled separately
 - Squashed the snps,dw-pcie removal (from schema) into the first patch
 - Replaced deprecated perst-gpio and wake-gpio with perst-gpios and
   wake-gpios in the examples and in DT files
 - Moved common clocks/clock-names, resets/reset-names and power-domains
   properties to the top level of the schema, leaving only platform
   specifics in the conditional branches
 - Dropped iommu-map/iommu-map-mask for now
 - Added (missed) interrupt-cells, clocks, clock-names, resets,
   reset-names properties to the required list (resets/reset-names are
   removed in the next patch, as they are not used on msm8996)
 - Fixed IRQ flags in the examples
 - Merged apq8064/ipq8064 into the single condition statement
 - Added extra empty lines

Dmitry Baryshkov (8):
  dt-bindings: PCI: qcom: Convert to YAML
  dt-bindings: PCI: qcom: Do not require resets on msm8996 platforms
  dt-bindings: PCI: qcom: Specify reg-names explicitly
  dt-bindings: PCI: qcom: Add schema for sc7280 chipset
  arm64: dts: qcom: stop using snps,dw-pcie falback
  arm: dts: qcom: stop using snps,dw-pcie falback
  arm: dts: qcom-*: replace deprecated perst-gpio with perst-gpios
  arm64: dts: qcom: replace deprecated perst-gpio with perst-gpios

 .../devicetree/bindings/pci/qcom,pcie.txt     | 398 ----------
 .../devicetree/bindings/pci/qcom,pcie.yaml    | 714 ++++++++++++++++++
 arch/arm/boot/dts/qcom-apq8064-cm-qs600.dts   |   2 +-
 arch/arm/boot/dts/qcom-apq8064-ifc6410.dts    |   2 +-
 arch/arm/boot/dts/qcom-apq8064.dtsi           |   2 +-
 arch/arm/boot/dts/qcom-ipq4019-ap.dk04.1.dtsi |   2 +-
 .../boot/dts/qcom-ipq4019-ap.dk07.1-c1.dts    |   2 +-
 arch/arm/boot/dts/qcom-ipq4019.dtsi           |   2 +-
 arch/arm/boot/dts/qcom-ipq8064.dtsi           |   6 +-
 arch/arm64/boot/dts/qcom/apq8096-db820c.dts   |   6 +-
 arch/arm64/boot/dts/qcom/ipq8074-hk01.dts     |   4 +-
 arch/arm64/boot/dts/qcom/ipq8074-hk10.dtsi    |   4 +-
 .../dts/qcom/msm8996-sony-xperia-tone.dtsi    |   4 +-
 arch/arm64/boot/dts/qcom/msm8996.dtsi         |   6 +-
 arch/arm64/boot/dts/qcom/qcs404-evb.dtsi      |   2 +-
 arch/arm64/boot/dts/qcom/qcs404.dtsi          |   2 +-
 .../arm64/boot/dts/qcom/sc7280-herobrine.dtsi |   2 +-
 arch/arm64/boot/dts/qcom/sc7280-idp.dtsi      |   2 +-
 arch/arm64/boot/dts/qcom/sdm845-db845c.dts    |   4 +-
 arch/arm64/boot/dts/qcom/sdm845.dtsi          |   4 +-
 arch/arm64/boot/dts/qcom/sm8250.dtsi          |   6 +-
 21 files changed, 746 insertions(+), 430 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/pci/qcom,pcie.txt
 create mode 100644 Documentation/devicetree/bindings/pci/qcom,pcie.yaml

Comments

Rob Herring (Arm) May 10, 2022, 4:50 p.m. UTC | #1
On Fri, May 06, 2022 at 06:20:59PM +0300, Dmitry Baryshkov wrote:
> Convert pci/qcom,pcie schema to YAML description. The first patch
> introduces several warnings which are fixed by the other patches in the
> series.
> 
> Note regarding the snps,dw-pcie compatibility. The Qualcomm PCIe
> controller uses Synopsys PCIe IP core. However it is not just fused to
> the address space. Accessing PCIe registers requires several clocks and
> regulators to be powered up. Thus it can be assumed that the qcom,pcie
> bindings are not fully compatible with the snps,dw-pcie schema.
> 
> Changes since v5:
>  - s/stance/stanza (pointed out by Bjorn Helgaas)
> 
> Changes since v4:
>  - Change subjects to follow convention (suggested by Bjorn Helgaas)
> 
> Changes since v3:
>  - Rebase on linux-next to include sm8150 patches
> 
> Changes since v2 (still kudos to Krzyshtof):
>  - Readded reg-names conversion patch
>  - Mention wake-gpio update in the commit message
>  - Remove extra quotes in the schema
> 
> Changes since v1 (all kudos to Krzyshtof):
>  - Dropped the reg-names patch. It will be handled separately
>  - Squashed the snps,dw-pcie removal (from schema) into the first patch
>  - Replaced deprecated perst-gpio and wake-gpio with perst-gpios and
>    wake-gpios in the examples and in DT files
>  - Moved common clocks/clock-names, resets/reset-names and power-domains
>    properties to the top level of the schema, leaving only platform
>    specifics in the conditional branches
>  - Dropped iommu-map/iommu-map-mask for now
>  - Added (missed) interrupt-cells, clocks, clock-names, resets,
>    reset-names properties to the required list (resets/reset-names are
>    removed in the next patch, as they are not used on msm8996)
>  - Fixed IRQ flags in the examples
>  - Merged apq8064/ipq8064 into the single condition statement
>  - Added extra empty lines
> 
> Dmitry Baryshkov (8):
>   dt-bindings: PCI: qcom: Convert to YAML
>   dt-bindings: PCI: qcom: Do not require resets on msm8996 platforms
>   dt-bindings: PCI: qcom: Specify reg-names explicitly
>   dt-bindings: PCI: qcom: Add schema for sc7280 chipset
>   arm64: dts: qcom: stop using snps,dw-pcie falback
>   arm: dts: qcom: stop using snps,dw-pcie falback
>   arm: dts: qcom-*: replace deprecated perst-gpio with perst-gpios
>   arm64: dts: qcom: replace deprecated perst-gpio with perst-gpios
> 
>  .../devicetree/bindings/pci/qcom,pcie.txt     | 398 ----------
>  .../devicetree/bindings/pci/qcom,pcie.yaml    | 714 ++++++++++++++++++

What tree do these apply to because they don't apply to rc1. I'm 
assuming the PCI tree and Lorenzo should take them.

Rob
Bjorn Andersson Aug. 29, 2022, 11:45 p.m. UTC | #2
On Fri, 6 May 2022 18:20:59 +0300, Dmitry Baryshkov wrote:
> Convert pci/qcom,pcie schema to YAML description. The first patch
> introduces several warnings which are fixed by the other patches in the
> series.
> 
> Note regarding the snps,dw-pcie compatibility. The Qualcomm PCIe
> controller uses Synopsys PCIe IP core. However it is not just fused to
> the address space. Accessing PCIe registers requires several clocks and
> regulators to be powered up. Thus it can be assumed that the qcom,pcie
> bindings are not fully compatible with the snps,dw-pcie schema.
> 
> [...]

Applied, thanks!

[5/8] arm64: dts: qcom: stop using snps,dw-pcie falback
      commit: 3e4fec3bc8f8d1366cf2d8d8a054ed37e5a41cba
[8/8] arm64: dts: qcom: replace deprecated perst-gpio with perst-gpios
      commit: f3f5fb3184ec0cd7f98267a8dc1c0538575fbb77

Best regards,