| Message ID | 20220823102800.kernel.v3.1.I1d10fc551cadae988dcf2fc66ad8c9eec2d7026b@changeid |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Bluetooth: hci_sync: hold hdev->lock when cleanup hci_conn | expand |
This is automated email and please do not reply to this email! Dear submitter, Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series: PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=670367 ---Test result--- Test Summary: CheckPatch PASS 0.90 seconds GitLint PASS 0.50 seconds SubjectPrefix PASS 0.31 seconds BuildKernel PASS 41.03 seconds BuildKernel32 PASS 37.01 seconds Incremental Build with patchesPASS 52.46 seconds TestRunner: Setup PASS 590.16 seconds TestRunner: l2cap-tester PASS 19.08 seconds TestRunner: bnep-tester PASS 7.51 seconds TestRunner: mgmt-tester PASS 122.65 seconds TestRunner: rfcomm-tester PASS 12.16 seconds TestRunner: sco-tester PASS 11.78 seconds TestRunner: smp-tester PASS 11.16 seconds TestRunner: userchan-tester PASS 7.64 seconds --- Regards, Linux Bluetooth
diff --git a/net/bluetooth/hci_sync.c b/net/bluetooth/hci_sync.c index 74a0cd5d0b37f..e08c0503027d8 100644 --- a/net/bluetooth/hci_sync.c +++ b/net/bluetooth/hci_sync.c @@ -5034,9 +5034,11 @@ int hci_abort_conn_sync(struct hci_dev *hdev, struct hci_conn *conn, u8 reason) /* Cleanup hci_conn object if it cannot be cancelled as it * likelly means the controller and host stack are out of sync. */ - if (err) + if (err) { + hci_dev_lock(hdev); hci_conn_failed(conn, err); - + hci_dev_unlock(hdev); + } return err; case BT_CONNECT2: return hci_reject_conn_sync(hdev, conn, reason);
When disconnecting all devices, hci_conn_failed is used to cleanup hci_conn object when the hci_conn object cannot be aborted. The function hci_conn_failed requires the caller holds hdev->lock. Fixes: 9b3628d79b46f ("Bluetooth: hci_sync: Cleanup hci_conn if it cannot be aborted") Signed-off-by: Zhengping Jiang <jiangzp@google.com> --- Changes in v3: - Remove an empty line in commit message between Fixes and SoB Changes in v2: - Update commit message Changes in v1: - Hold hdev->lock for hci_conn_failed net/bluetooth/hci_sync.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)