| Message ID | 20220710084133.30976-9-dmitry.baryshkov@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | dt-bindings: msm/dp: cleanup Qualcomm DP and eDP bidndings | expand |
On Sun, Jul 10, 2022 at 11:41:32AM +0300, Dmitry Baryshkov wrote: > Document missing definitions for opp-table (DP controller OPPs), aux-bus > (DP AUX BUS) and data-lanes (DP/eDP lanes mapping) properties. > > Reviewed-by: Stephen Boyd <swboyd@chromium.org> > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > --- > .../bindings/display/msm/dp-controller.yaml | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml > index 391910d91e43..52cbf00df0ba 100644 > --- a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml > +++ b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml > @@ -70,9 +70,21 @@ properties: > operating-points-v2: > maxItems: 1 > > + opp-table: true > + > power-domains: > maxItems: 1 > > + aux-bus: > + $ref: /schemas/display/dp-aux-bus.yaml# > + > + data-lanes: But this is the wrong location for 'data-lanes'. It belongs in an endpoint node. > + $ref: /schemas/types.yaml#/definitions/uint32-array > + minItems: 1 > + maxItems: 4 > + items: > + maximum: 3 > + > "#sound-dai-cells": > const: 0 > > -- > 2.35.1 > >
On Tue, 12 Jul 2022 at 02:16, Rob Herring <robh@kernel.org> wrote: > > On Sun, Jul 10, 2022 at 11:41:32AM +0300, Dmitry Baryshkov wrote: > > Document missing definitions for opp-table (DP controller OPPs), aux-bus > > (DP AUX BUS) and data-lanes (DP/eDP lanes mapping) properties. > > > > Reviewed-by: Stephen Boyd <swboyd@chromium.org> > > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > > --- > > .../bindings/display/msm/dp-controller.yaml | 12 ++++++++++++ > > 1 file changed, 12 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml > > index 391910d91e43..52cbf00df0ba 100644 > > --- a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml > > +++ b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml > > @@ -70,9 +70,21 @@ properties: > > operating-points-v2: > > maxItems: 1 > > > > + opp-table: true > > + > > power-domains: > > maxItems: 1 > > > > + aux-bus: > > + $ref: /schemas/display/dp-aux-bus.yaml# > > + > > + data-lanes: > > But this is the wrong location for 'data-lanes'. It belongs in an > endpoint node. Ack. Then I'll drop this for v3. > > > + $ref: /schemas/types.yaml#/definitions/uint32-array > > + minItems: 1 > > + maxItems: 4 > > + items: > > + maximum: 3 > > + > > "#sound-dai-cells": > > const: 0 > > > > -- > > 2.35.1 > > > >
On 10/07/2022 10:41, Dmitry Baryshkov wrote: > Document missing definitions for opp-table (DP controller OPPs), aux-bus > (DP AUX BUS) and data-lanes (DP/eDP lanes mapping) properties. > > Reviewed-by: Stephen Boyd <swboyd@chromium.org> > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > --- > .../bindings/display/msm/dp-controller.yaml | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On 12/07/2022 02:16, Rob Herring wrote: > On Sun, Jul 10, 2022 at 11:41:32AM +0300, Dmitry Baryshkov wrote: >> Document missing definitions for opp-table (DP controller OPPs), aux-bus >> (DP AUX BUS) and data-lanes (DP/eDP lanes mapping) properties. >> >> Reviewed-by: Stephen Boyd <swboyd@chromium.org> >> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> >> --- >> .../bindings/display/msm/dp-controller.yaml | 12 ++++++++++++ >> 1 file changed, 12 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml >> index 391910d91e43..52cbf00df0ba 100644 >> --- a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml >> +++ b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml >> @@ -70,9 +70,21 @@ properties: >> operating-points-v2: >> maxItems: 1 >> >> + opp-table: true >> + >> power-domains: >> maxItems: 1 >> >> + aux-bus: >> + $ref: /schemas/display/dp-aux-bus.yaml# >> + >> + data-lanes: > > But this is the wrong location for 'data-lanes'. It belongs in an > endpoint node. I rechecked the existing device trees (sc7280-herobrine.dtsi). The data-lanes are already inside the main dp controller node. I'll take a glance on fixing the driver to check the dp_out endpoint (and update existing DT to move the property to the endpoint node), but to make schema compatible with the existing device trees we'd probably still need this property (which can be marked as deprecated once the proper endpoint property is supported). Does that sound plausible? > >> + $ref: /schemas/types.yaml#/definitions/uint32-array >> + minItems: 1 >> + maxItems: 4 >> + items: >> + maximum: 3 >> + >> "#sound-dai-cells": >> const: 0 >> >> -- >> 2.35.1 >> >>
Quoting Dmitry Baryshkov (2022-08-22 11:46:39) > On 12/07/2022 02:16, Rob Herring wrote: > > > > But this is the wrong location for 'data-lanes'. It belongs in an > > endpoint node. > > I rechecked the existing device trees (sc7280-herobrine.dtsi). The > data-lanes are already inside the main dp controller node. I'll take a > glance on fixing the driver to check the dp_out endpoint (and update > existing DT to move the property to the endpoint node), but to make > schema compatible with the existing device trees we'd probably still > need this property (which can be marked as deprecated once the proper > endpoint property is supported). Does that sound plausible? It would be nice if drm_of_get_data_lanes_count() took some port and endpoint number instead of a node pointer directly. Then you couldn't mess this up as easily.
diff --git a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml index 391910d91e43..52cbf00df0ba 100644 --- a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml +++ b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml @@ -70,9 +70,21 @@ properties: operating-points-v2: maxItems: 1 + opp-table: true + power-domains: maxItems: 1 + aux-bus: + $ref: /schemas/display/dp-aux-bus.yaml# + + data-lanes: + $ref: /schemas/types.yaml#/definitions/uint32-array + minItems: 1 + maxItems: 4 + items: + maximum: 3 + "#sound-dai-cells": const: 0