Message ID | 20220726180623.1668-5-prabhakar.mahadev-lad.rj@bp.renesas.com |
---|---|
State | New |
Headers | show |
Series | Add support for Renesas RZ/Five SoC | expand |
Hi Krzysztof, On Wed, Jul 27, 2022 at 2:37 PM Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > On 27/07/2022 14:21, Biju Das wrote: > >> Subject: Re: [PATCH 4/6] dt-bindings: riscv: Add DT binding > >> documentation for Renesas RZ/Five SoC and SMARC EVK > >> On 27/07/2022 13:37, Lad, Prabhakar wrote: > >>>>> I did run the dtbs_check test as per your suggestion (below is the > >>>>> log) and didn't see "no matching schema error" > >>>>> > >>>> > >>>> So you do not see any errors at all. Then it does not work, does it? > >>>> > >>> Right I reverted my changes I can see it complaining, dtb_check seems > >>> to have returned false positive in my case. > >>> > >>> What approach would you suggest to ignore the schema here? > >> > >> I don't think currently it would work with your approach. Instead, you > >> should select here all SoCs which the schema should match. > >> > >> This leads to my previous concern - you use the same SoC compatible for > >> two different architectures and different SoCs: ARMv8 and RISC-V. > > > > Or is it same SoC(R9A07G043) based on two different CPU architectures (ARMv8 and RISC-V) > > Then it is not the same SoC! Same means same, identical. CPU > architecture is one of the major differences, which means it is not the > same. > > > Using same SoM and Carrier board? > > It's like saying PC with x86 and ARMv8 board are the same because they > both use same "PC chassis". That's not a fair comparison: the "PC chassis" is passive, while the carrier board is an active PCB. So it is more akin to plugging any Intel LGA 1151 processor into any motherboard with an LGA 1151 socket. Do we have compatible values for all such possible combinations? ;-) The classic compatible scheme of an ordered list from most-specific to least-specific is not well-suited for this case of mere aggregation. That's why we have been decoupling board and SoC compatible values for a while, and identifying specific boards by a combination of a board-specific and an SoC-specific compatible value. New SoCs that are available with different core CPU families (and that are pin-compatible) are just the next step in the evolution.... At the DT validation level, I think the proper solution is to merge Documentation/devicetree/bindings/arm/renesas.yaml and Documentation/devicetree/bindings/riscv/renesas.yaml into a single file under Documentation/devicetree/bindings/soc/renesas/. What do other people think? Thanks! Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
On 11/08/2022 18:42, Geert Uytterhoeven wrote: > At the DT validation level, I think the proper solution is to > merge Documentation/devicetree/bindings/arm/renesas.yaml and > Documentation/devicetree/bindings/riscv/renesas.yaml into a single > file under Documentation/devicetree/bindings/soc/renesas/. > > What do other people think? I am ok with it. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/riscv/renesas.yaml b/Documentation/devicetree/bindings/riscv/renesas.yaml new file mode 100644 index 000000000000..f72f8aea6a82 --- /dev/null +++ b/Documentation/devicetree/bindings/riscv/renesas.yaml @@ -0,0 +1,49 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/riscv/renesas.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Renesas RZ/Five Platform Device Tree Bindings + +maintainers: + - Geert Uytterhoeven <geert+renesas@glider.be> + - Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> + +# We want to ignore this schema if the board is SMARC EVK based on ARM64 arch +select: + not: + properties: + compatible: + contains: + items: + - const: renesas,smarc-evk + - enum: + - renesas,r9a07g043u11 + - renesas,r9a07g043u12 + - renesas,r9a07g044c1 + - renesas,r9a07g044c2 + - renesas,r9a07g044l1 + - renesas,r9a07g044l2 + - renesas,r9a07g054l1 + - renesas,r9a07g054l2 + - enum: + - renesas,r9a07g043 + - renesas,r9a07g044 + - renesas,r9a07g054 + +properties: + $nodename: + const: '/' + compatible: + oneOf: + - description: RZ/Five (R9A07G043) + items: + - enum: + - renesas,smarc-evk # SMARC EVK + - const: renesas,r9a07g043f01 + - const: renesas,r9a07g043 + +additionalProperties: true + +...
Document Renesas RZ/Five (R9A07G043) SoC and SMARC EVK based on this SoC. Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> --- .../devicetree/bindings/riscv/renesas.yaml | 49 +++++++++++++++++++ 1 file changed, 49 insertions(+) create mode 100644 Documentation/devicetree/bindings/riscv/renesas.yaml