Message ID | 20220804151001.23612-1-johan+linaro@kernel.org |
---|---|
Headers | show |
Series | usb: dwc3: qcom: fix wakeup implementation | expand |
On Thu, Aug 04, 2022 at 05:09:52PM +0200, Johan Hovold wrote: > Changes in v2 > - add review and ack tags > - fix a gadget-only build breakage (new patch) > - fix a use-after-free on wakeup from runtime suspend (new patch) > - disable wakeup completely instead of falling back to the > "disconnected" host configuration when not acting as host > - disallow 'wakeup-source' in child node in the binding Forgot to mention that I also dropped the revert of the dt-binding commit adding 'wakeup-source' to the core node as Rob suggested. Johan
Hi John, On 8/4/22 08:09, Johan Hovold wrote: > A recent change added a dependency to the USB host stack and broke > gadget-only builds of the driver. > > Fixes: 6895ea55c385 ("usb: dwc3: qcom: Configure wakeup interrupts during suspend") > Reported-by: Randy Dunlap <rdunlap@infradead.org> > Signed-off-by: Johan Hovold <johan+linaro@kernel.org> LGTM. Thanks. Reviewed-by: Randy Dunlap <rdunlap@infradead.org> > --- > > Changes in v2 > - new patch > > drivers/usb/dwc3/dwc3-qcom.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/usb/dwc3/dwc3-qcom.c b/drivers/usb/dwc3/dwc3-qcom.c > index be2e3dd36440..e9364141661b 100644 > --- a/drivers/usb/dwc3/dwc3-qcom.c > +++ b/drivers/usb/dwc3/dwc3-qcom.c > @@ -310,8 +310,11 @@ static enum usb_device_speed dwc3_qcom_read_usb2_speed(struct dwc3_qcom *qcom) > * currently supports only 1 port per controller. So > * this is sufficient. > */ > +#ifdef CONFIG_USB > udev = usb_hub_find_child(hcd->self.root_hub, 1); > - > +#else > + udev = NULL; > +#endif > if (!udev) > return USB_SPEED_UNKNOWN; >