[RESEND,v6,2/3] leds: Add driver for the TLC5925 LED controller

Message ID	20220722081146.47262-3-jjhiblot@traphandler.com
State	New
Headers	show Return-Path: <linux-leds-owner@kernel.org> From: Jean-Jacques Hiblot <jjhiblot@traphandler.com> To: <pavel@ucw.cz>, <robh+dt@kernel.org>, <krzysztof.kozlowski+dt@linaro.org> CC: <andy.shevchenko@gmail.com>, <linux-leds@vger.kernel.org>, <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>, Jean-Jacques Hiblot <jjhiblot@traphandler.com> Subject: [RESEND PATCH v6 2/3] leds: Add driver for the TLC5925 LED controller Date: Fri, 22 Jul 2022 10:11:45 +0200 Message-ID: <20220722081146.47262-3-jjhiblot@traphandler.com> In-Reply-To: <20220722081146.47262-1-jjhiblot@traphandler.com> References: <20220722081146.47262-1-jjhiblot@traphandler.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII Precedence: bulk
Series	Add support for the TLC5925 \| expand [RESEND,v6,0/3] Add support for the TLC5925 [RESEND,v6,1/3] dt-bindings: leds: Add bindings for the TLC5925 controller [RESEND,v6,2/3] leds: Add driver for the TLC5925 LED controller [RESEND,v6,3/3] leds: tlc5925: Add support for non blocking operations

diff --git a/drivers/leds/Kconfig b/drivers/leds/Kconfig index eaba0a8347fa..197d2e4b6c72 100644 --- a/drivers/leds/Kconfig +++ b/drivers/leds/Kconfig @@ -658,6 +658,12 @@ config LEDS_TLC591XX This option enables support for Texas Instruments TLC59108 and TLC59116 LED controllers. +config LEDS_TLC5925 + tristate "LED driver for TLC5925 controller" + depends on LEDS_CLASS && SPI + help + This option enables support for Texas Instruments TLC5925. + config LEDS_MAX77650 tristate "LED support for Maxim MAX77650 PMIC" depends on LEDS_CLASS && MFD_MAX77650 diff --git a/drivers/leds/Makefile b/drivers/leds/Makefile index 4fd2f92cd198..9d15b88d482f 100644 --- a/drivers/leds/Makefile +++ b/drivers/leds/Makefile @@ -81,6 +81,7 @@ obj-$(CONFIG_LEDS_SYSCON) += leds-syscon.o obj-$(CONFIG_LEDS_TCA6507) += leds-tca6507.o obj-$(CONFIG_LEDS_TI_LMU_COMMON) += leds-ti-lmu-common.o obj-$(CONFIG_LEDS_TLC591XX) += leds-tlc591xx.o +obj-$(CONFIG_LEDS_TLC5925) += leds-tlc5925.o obj-$(CONFIG_LEDS_TPS6105X) += leds-tps6105x.o obj-$(CONFIG_LEDS_TURRIS_OMNIA) += leds-turris-omnia.o obj-$(CONFIG_LEDS_WM831X_STATUS) += leds-wm831x-status.o diff --git a/drivers/leds/leds-tlc5925.c b/drivers/leds/leds-tlc5925.c new file mode 100644 index 000000000000..797836354c74 --- /dev/null +++ b/drivers/leds/leds-tlc5925.c @@ -0,0 +1,148 @@ +// SPDX-License-Identifier: GPL-2.0-only +/* + * The driver supports controllers with a very simple SPI protocol: + * - the data is deserialized in a shift-register when CS is asserted + * - the data is latched when CS is de-asserted + * - the LED are either on or off (no control of the brightness) + * + * Supported devices: + * - "ti,tlc5925": Low-Power 16-Channel Constant-Current LED Sink Driver + * https://www.ti.com/lit/ds/symlink/tlc5925.pdf + */ + +#include <linux/container_of.h> +#include <linux/err.h> +#include <linux/gpio/consumer.h> +#include <linux/leds.h> +#include <linux/module.h> +#include <linux/property.h> +#include <linux/spi/spi.h> +#include <linux/types.h> + +#define TLC5925_SHIFT_REGISTER_LENGTH 16 + +struct single_led_priv { + struct led_classdev cdev; + int idx; +}; + +struct tlc5925_leds_priv { + int max_num_leds; + unsigned long *state; + struct single_led_priv leds[]; +}; + +static int tlc5925_brightness_set_blocking(struct led_classdev *cdev, + enum led_brightness brightness) +{ + struct spi_device *spi = to_spi_device(cdev->dev->parent); + struct tlc5925_leds_priv *priv = spi_get_drvdata(spi); + struct single_led_priv *led = + container_of(cdev, struct single_led_priv, cdev); + int index = led->idx; + + assign_bit(index, priv->state, !!brightness); + + return spi_write(spi, priv->state, BITS_TO_BYTES(priv->max_num_leds)); +} + +static int tlc5925_probe(struct spi_device *spi) +{ + struct device *dev = &spi->dev; + struct fwnode_handle *child; + struct tlc5925_leds_priv *priv; + int count; + int max_num_leds = TLC5925_SHIFT_REGISTER_LENGTH; + struct gpio_descs *gpios; + + /* Assert all the OE/ lines */ + gpios = devm_gpiod_get_array(dev, "output-enable-b", GPIOD_OUT_LOW); + if (IS_ERR(gpios)) + return dev_err_probe(dev, PTR_ERR(gpios), + "Unable to get the 'output-enable-b' gpios\n"); + + count = device_get_child_node_count(dev); + if (!count) + return dev_err_probe(dev, -ENODEV, "no led defined.\n"); + + device_property_read_u32(dev, "ti,shift-register-length", + &max_num_leds); + + if (max_num_leds % 8) + return dev_err_probe(dev, -EINVAL, + "'ti,shift-register-length' must be a multiple of 8\n"); + if (max_num_leds == 0) + return dev_err_probe(dev, -EINVAL, + "'ti,shift-register-length' must be greater than 0\n"); + + priv = devm_kzalloc(dev, struct_size(priv, leds, count), GFP_KERNEL); + if (!priv) + return -ENOMEM; + + priv->state = devm_bitmap_zalloc(dev, max_num_leds, GFP_KERNEL); + if (!priv->state) + return -ENOMEM; + + priv->max_num_leds = max_num_leds; + + device_for_each_child_node(dev, child) { + struct led_init_data init_data = { .fwnode = child }; + struct led_classdev *cdev; + u32 idx; + int ret; + + ret = fwnode_property_read_u32(child, "reg", &idx); + if (ret || idx >= max_num_leds) { + dev_warn(dev, "%pfwP: invalid reg value. Ignoring.\n", + child); + fwnode_handle_put(child); + continue; + } + + count--; + priv->leds[count].idx = idx; + cdev = &(priv->leds[count].cdev); + cdev->brightness = LED_OFF; + cdev->max_brightness = 1; + cdev->brightness_set_blocking = tlc5925_brightness_set_blocking; + + ret = devm_led_classdev_register_ext(dev, cdev, &init_data); + if (ret) { + dev_warn(dev, "%pfwP: cannot create LED device.\n", + child); + fwnode_handle_put(child); + continue; + } + } + + spi_set_drvdata(spi, priv); + + return 0; +} + +static const struct of_device_id tlc5925_dt_ids[] = { + { .compatible = "ti,tlc5925", }, + {} +}; +MODULE_DEVICE_TABLE(of, tlc5925_dt_ids); + +static const struct spi_device_id tlc5925_id[] = { + {"tlc5925", 0}, + {} +}; +MODULE_DEVICE_TABLE(spi, tlc5925_id); + +static struct spi_driver tlc5925_driver = { + .driver = { + .name = KBUILD_MODNAME, + .of_match_table = tlc5925_dt_ids, + }, + .id_table = tlc5925_id, + .probe = tlc5925_probe, +}; +module_spi_driver(tlc5925_driver); + +MODULE_AUTHOR("Jean-Jacques Hiblot <jjhiblot@traphandler.com>"); +MODULE_DESCRIPTION("TLC5925 LED driver"); +MODULE_LICENSE("GPL"); +MODULE_ALIAS("spi:tlc5925");

[RESEND,v6,2/3] leds: Add driver for the TLC5925 LED controller

Commit Message

Comments

Patch