Message ID | 20220722110330.13257-2-harini.katakam@xilinx.com |
---|---|
State | New |
Headers | show |
Series | Add Versal compatible string to Macb driver | expand |
Hi Rob, Krzysztof, > -----Original Message----- > From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Sent: Tuesday, July 26, 2022 1:10 AM > To: Rob Herring <robh@kernel.org>; Harini Katakam > <harini.katakam@xilinx.com> > Cc: nicolas.ferre@microchip.com; davem@davemloft.net; > claudiu.beznea@microchip.com; kuba@kernel.org; edumazet@google.com; > pabeni@redhat.com; krzysztof.kozlowski+dt@linaro.org; > netdev@vger.kernel.org; linux-kernel@vger.kernel.org; > michal.simek@xilinx.com; harinikatakamlinux@gmail.com; Katakam, Harini > <harini.katakam@amd.com>; devicetree@vger.kernel.org; > radhey.shyam.pandey@xilinx.com > Subject: Re: [PATCH v2 1/3] dt-bindings: net: cdns,macb: Add versal > compatible string > > On 25/07/2022 21:33, Rob Herring wrote: > > On Fri, Jul 22, 2022 at 04:33:28PM +0530, Harini Katakam wrote: <snip> > >> > >> - items: > >> - enum: > >> + - cdns,versal-gem # Xilinx Versal > >> - cdns,zynq-gem # Xilinx Zynq-7xxx SoC > >> - cdns,zynqmp-gem # Xilinx Zynq Ultrascale+ MPSoC > > > > Uh, how did we start this pattern? The vendor here is Xilinx, not > > Cadence. It should be xlnx,versal-gem instead. I'm not sure how the pattern started but I see that all the early versions of compatible strings added (Xilinx, Atmel, Microchip) has cdns prefix. Links for reference: https://lore.kernel.org/lkml/1432756728-6778-1-git-send-email-nathan.sullivan@ni.com/ https://lore.kernel.org/lkml/1432244845-29315-1-git-send-email-nathan.sullivan@ni.com/ https://lore.kernel.org/lkml/1430931438-32592-1-git-send-email-harinik@xilinx.com/ I can switch to xlnx,versal-gem now. Regards, Harini
diff --git a/Documentation/devicetree/bindings/net/cdns,macb.yaml b/Documentation/devicetree/bindings/net/cdns,macb.yaml index 9c92156869b2..762deccd3640 100644 --- a/Documentation/devicetree/bindings/net/cdns,macb.yaml +++ b/Documentation/devicetree/bindings/net/cdns,macb.yaml @@ -20,6 +20,7 @@ properties: - items: - enum: + - cdns,versal-gem # Xilinx Versal - cdns,zynq-gem # Xilinx Zynq-7xxx SoC - cdns,zynqmp-gem # Xilinx Zynq Ultrascale+ MPSoC - const: cdns,gem # Generic