| Message ID | 20220726102404.564498-1-gengcixi@gmail.com |
|---|---|
| Headers | show |
| Series | Add ums512 clocks and relative bindings file | expand |
On Tue, 26 Jul 2022 18:24:03 +0800, Cixi Geng wrote: > From: Chunyan Zhang <chunyan.zhang@unisoc.com> > > Add bindings for Unisoc system global register which provide register map > for clocks. > > Signed-off-by: Chunyan Zhang <chunyan.zhang@unisoc.com> > Signed-off-by: Cixi Geng <cixi.geng1@unisoc.com> > Reviewed-by: Rob Herring <robh@kernel.org> > --- > .../bindings/mfd/sprd,ums512-glbreg.yaml | 68 +++++++++++++++++++ > 1 file changed, 68 insertions(+) > create mode 100644 Documentation/devicetree/bindings/mfd/sprd,ums512-glbreg.yaml > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: ./Documentation/devicetree/bindings/mfd/sprd,ums512-glbreg.yaml: Unable to find schema file matching $id: http://devicetree.org/schemas/clock/sprd,ums512-clk.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mfd/sprd,ums512-glbreg.example.dtb: syscon@71000000: clock-controller@0: False schema does not allow {'compatible': ['sprd,ums512-apahb-gate'], 'reg': [[0, 8192]], '#clock-cells': [[1]]} From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mfd/sprd,ums512-glbreg.yaml Documentation/devicetree/bindings/mfd/sprd,ums512-glbreg.example.dtb:0:0: /example-0/syscon@71000000/clock-controller@0: failed to match any schema with compatible: ['sprd,ums512-apahb-gate'] doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/patch/ This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit.
On 26/07/2022 12:24, Cixi Geng wrote: > From: Cixi Geng <cixi.geng1@unisoc.com> > > This patchset is add the UMS512 clocks support > > v2 changes: > adjust description and add the "sprd,ums512-glbregs,syscon,simple-mfd" > compatibles to fix match failed logs in the dt_binding_check. > add the property license and copyright notice. > > v3 changes: > fix wrong indentation and hint: "maxItems" is not needed with an "items" > list when use the latest dtschema. > > v4 changes: > move the syscon bindins from clk to glbreg yaml file by pickup > chunyan's patch for global registers bindings > fix the comments from Krzysztof in v3 patchset > add the Acked-by: Krzysztof in patch v4 3/4 > fix the warning Prefer "GPL" over "GPL v2" > > v5 changes: > Add review tags. > fix the comments in ums512-glbreg.yaml. > > v6 changes: > No more send the patch 1/4 and 3/4 in V5 for applied by Stephen > change GPL to GPL v2 license > fix the lack of space in some "{" and "}" > add check error for sprd_clk_regmap_init. That's not good. That was a dependency here (for MFD bindings). You must describe the dependencies in cover letter so maintainers know how to do it. Your MFD patch is not applicable now... Best regards, Krzysztof
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> 于2022年7月27日周三 01:48写道： > > On 26/07/2022 12:24, Cixi Geng wrote: > > From: Chunyan Zhang <chunyan.zhang@unisoc.com> > > > > Add bindings for Unisoc system global register which provide register map > > for clocks. > > > > Signed-off-by: Chunyan Zhang <chunyan.zhang@unisoc.com> > > Signed-off-by: Cixi Geng <cixi.geng1@unisoc.com> > > Reviewed-by: Rob Herring <robh@kernel.org> > > --- > > .../bindings/mfd/sprd,ums512-glbreg.yaml | 68 +++++++++++++++++++ > > 1 file changed, 68 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/mfd/sprd,ums512-glbreg.yaml > > > > The patch depends on patch in clk tree, so either it goes via clk tree, > there is cross-tree merge or it must wait for v5.20-rc1. ok, I will resend this patchset after v5.20-rc1.thanks > > > Best regards, > Krzysztof
From: Cixi Geng <cixi.geng1@unisoc.com> This patchset is add the UMS512 clocks support v2 changes: adjust description and add the "sprd,ums512-glbregs,syscon,simple-mfd" compatibles to fix match failed logs in the dt_binding_check. add the property license and copyright notice. v3 changes: fix wrong indentation and hint: "maxItems" is not needed with an "items" list when use the latest dtschema. v4 changes: move the syscon bindins from clk to glbreg yaml file by pickup chunyan's patch for global registers bindings fix the comments from Krzysztof in v3 patchset add the Acked-by: Krzysztof in patch v4 3/4 fix the warning Prefer "GPL" over "GPL v2" v5 changes: Add review tags. fix the comments in ums512-glbreg.yaml. v6 changes: No more send the patch 1/4 and 3/4 in V5 for applied by Stephen change GPL to GPL v2 license fix the lack of space in some "{" and "}" add check error for sprd_clk_regmap_init. Chunyan Zhang (1): dt-bindings: mfd: sprd: Add bindings for ums512 global registers Cixi Geng (1): clk: sprd: Add clocks support for UMS512 .../bindings/mfd/sprd,ums512-glbreg.yaml | 68 + drivers/clk/sprd/Kconfig | 6 + drivers/clk/sprd/Makefile | 1 + drivers/clk/sprd/ums512-clk.c | 2202 +++++++++++++++++ 4 files changed, 2277 insertions(+) create mode 100644 Documentation/devicetree/bindings/mfd/sprd,ums512-glbreg.yaml create mode 100644 drivers/clk/sprd/ums512-clk.c