| Message ID | 20220721093422.2173982-2-marcus.folkesson@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | [1/2] gpio: gpio-74x164: add support for CDx4HC4094 | expand |
On 21/07/2022 11:34, Marcus Folkesson wrote: > Some shift registers (74hc4094 for example) has a strobe signal to latch > data from the serial input to the parallel output. > > Add an optional strobe-gpios property to support those chips. > > Signed-off-by: Marcus Folkesson <marcus.folkesson@gmail.com> > --- > .../devicetree/bindings/gpio/fairchild,74hc595.yaml | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/Documentation/devicetree/bindings/gpio/fairchild,74hc595.yaml b/Documentation/devicetree/bindings/gpio/fairchild,74hc595.yaml > index a99e7842ca17..9893df9ae22c 100644 > --- a/Documentation/devicetree/bindings/gpio/fairchild,74hc595.yaml > +++ b/Documentation/devicetree/bindings/gpio/fairchild,74hc595.yaml > @@ -14,6 +14,8 @@ properties: > enum: > - fairchild,74hc595 > - nxp,74lvc594 > + - ti,cd54hc4094 > + - ti,cd74hc4094 > > reg: > maxItems: 1 > @@ -33,6 +35,10 @@ properties: > description: GPIO connected to the OE (Output Enable) pin. > maxItems: 1 > > + strobe-gpios: > + description: GPIO connected to the STROBE pin > + maxItems: 1 This should be disallowed (in allOf:if:then) for variants which do not support it (or do not have even STROBE pin). Best regards, Krzysztof
On Thu, Jul 21, 2022 at 11:30 AM Marcus Folkesson <marcus.folkesson@gmail.com> wrote: > Some shift registers (74hc4094 for example) has a strobe signal to latch > data from the serial input to the parallel output. > > Add an optional strobe-gpios property to support those chips. > > Signed-off-by: Marcus Folkesson <marcus.folkesson@gmail.com> As pointed out in discussion with Andy, let's drop this and just use cs-gpios as-is. Yours, Linus Walleij
diff --git a/Documentation/devicetree/bindings/gpio/fairchild,74hc595.yaml b/Documentation/devicetree/bindings/gpio/fairchild,74hc595.yaml index a99e7842ca17..9893df9ae22c 100644 --- a/Documentation/devicetree/bindings/gpio/fairchild,74hc595.yaml +++ b/Documentation/devicetree/bindings/gpio/fairchild,74hc595.yaml @@ -14,6 +14,8 @@ properties: enum: - fairchild,74hc595 - nxp,74lvc594 + - ti,cd54hc4094 + - ti,cd74hc4094 reg: maxItems: 1 @@ -33,6 +35,10 @@ properties: description: GPIO connected to the OE (Output Enable) pin. maxItems: 1 + strobe-gpios: + description: GPIO connected to the STROBE pin + maxItems: 1 + spi-max-frequency: true patternProperties:
Some shift registers (74hc4094 for example) has a strobe signal to latch data from the serial input to the parallel output. Add an optional strobe-gpios property to support those chips. Signed-off-by: Marcus Folkesson <marcus.folkesson@gmail.com> --- .../devicetree/bindings/gpio/fairchild,74hc595.yaml | 6 ++++++ 1 file changed, 6 insertions(+)