diff mbox series

[v8] ASoc: dt-bindings: tas27xx: revise tas27xx format

Message ID 20220722105512.191-1-13691752556@139.com
State New
Headers show
Series [v8] ASoc: dt-bindings: tas27xx: revise tas27xx format | expand

Commit Message

Raphael-Xu July 22, 2022, 10:55 a.m. UTC
revise the format

Signed-off-by: Raphael-Xu <13691752556@139.com>
---
 .../devicetree/bindings/sound/tas27xx.yaml       | 16 +++++++++++-----
 1 file changed, 11 insertions(+), 5 deletions(-)

Comments

Rob Herring July 25, 2022, 10:52 p.m. UTC | #1
On Fri, Jul 22, 2022 at 06:55:12PM +0800, Raphael-Xu wrote:
> revise the format

Complete sentences.

And this is not v8. Each new change is v1.

> 
> Signed-off-by: Raphael-Xu <13691752556@139.com>
> ---
>  .../devicetree/bindings/sound/tas27xx.yaml       | 16 +++++++++++-----
>  1 file changed, 11 insertions(+), 5 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/sound/tas27xx.yaml b/Documentation/devicetree/bindings/sound/tas27xx.yaml
> index 66a0df8850ea..573652577462 100644
> --- a/Documentation/devicetree/bindings/sound/tas27xx.yaml
> +++ b/Documentation/devicetree/bindings/sound/tas27xx.yaml
> @@ -8,7 +8,7 @@ $schema: "http://devicetree.org/meta-schemas/core.yaml#"
>  title: Texas Instruments TAS2764/TAS2780 Smart PA
>  
>  maintainers:
> -  - Shenghao Ding <shenghao-ding@ti.com>
> +  - Raphael Xu <raphael-xu@ti.com>
>  
>  description: |
>    The TAS2764/TAS2780 is a mono, digital input Class-D audio amplifier
> @@ -23,17 +23,19 @@ properties:
>        - ti,tas2780
>  
>    reg:
> -    maxItems: 1
>      description: |
> -       I2C address of the device can be between 0x38 to 0x45.

0x40-0x45 is no longer valid?

> +       I2C address of the device can be between 0x38 to 0x3f.
> +    minimum: 0x38
> +    maximum: 0x3f
>  

>    reset-gpios:
> -    maxItems: 1
>      description: GPIO used to reset the device.
> +    maxItems: 1

Unnecessary change.

>  
>    shutdown-gpios:
> +    description: |

Don't need '|' if no formatting.

> +       GPIO used to control the state of the device.Only for TAS2764.

Space needed after period.

>      maxItems: 1
> -    description: GPIO used to control the state of the device.
>  
>    interrupts:
>      maxItems: 1
> @@ -41,10 +43,14 @@ properties:
>    ti,imon-slot-no:
>      $ref: /schemas/types.yaml#/definitions/uint32
>      description: TDM TX current sense time slot.
> +    minimum: 0
> +    maximum: 3
>  
>    ti,vmon-slot-no:
>      $ref: /schemas/types.yaml#/definitions/uint32
>      description: TDM TX voltage sense time slot.
> +    minimum: 0
> +    maximum: 3
>  
>    '#sound-dai-cells':
>      const: 1
> -- 
> 2.35.1
> 
> 
>
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/sound/tas27xx.yaml b/Documentation/devicetree/bindings/sound/tas27xx.yaml
index 66a0df8850ea..573652577462 100644
--- a/Documentation/devicetree/bindings/sound/tas27xx.yaml
+++ b/Documentation/devicetree/bindings/sound/tas27xx.yaml
@@ -8,7 +8,7 @@  $schema: "http://devicetree.org/meta-schemas/core.yaml#"
 title: Texas Instruments TAS2764/TAS2780 Smart PA
 
 maintainers:
-  - Shenghao Ding <shenghao-ding@ti.com>
+  - Raphael Xu <raphael-xu@ti.com>
 
 description: |
   The TAS2764/TAS2780 is a mono, digital input Class-D audio amplifier
@@ -23,17 +23,19 @@  properties:
       - ti,tas2780
 
   reg:
-    maxItems: 1
     description: |
-       I2C address of the device can be between 0x38 to 0x45.
+       I2C address of the device can be between 0x38 to 0x3f.
+    minimum: 0x38
+    maximum: 0x3f
 
   reset-gpios:
-    maxItems: 1
     description: GPIO used to reset the device.
+    maxItems: 1
 
   shutdown-gpios:
+    description: |
+       GPIO used to control the state of the device.Only for TAS2764.
     maxItems: 1
-    description: GPIO used to control the state of the device.
 
   interrupts:
     maxItems: 1
@@ -41,10 +43,14 @@  properties:
   ti,imon-slot-no:
     $ref: /schemas/types.yaml#/definitions/uint32
     description: TDM TX current sense time slot.
+    minimum: 0
+    maximum: 3
 
   ti,vmon-slot-no:
     $ref: /schemas/types.yaml#/definitions/uint32
     description: TDM TX voltage sense time slot.
+    minimum: 0
+    maximum: 3
 
   '#sound-dai-cells':
     const: 1