| Message ID | 20220723061033.1377061-1-Basavaraj.Natikar@amd.com |
|---|---|
| Headers | show |
| Series | Fixes to amd_sfh driver | expand |
On Sat, 23 Jul 2022, Basavaraj Natikar wrote: > Changes includes to handle "no sensors" case and fix of implicit > declaration error on i386. > > Link: https://lore.kernel.org/all/92ed10f9-2c84-ad42-20d1-f8a101f78f08@infradead.org/ > ''' > From: Randy Dunlap <rdunlap@infradead.org> > Changes since 20220721: > > on i386: > > ../drivers/hid/amd-sfh-hid/sfh1_1/amd_sfh_interface.c: In function ‘amd_stop_sensor’: > ../drivers/hid/amd-sfh-hid/sfh1_1/amd_sfh_interface.c:48:9: error: implicit declaration of function ‘writeq’; did you mean ‘writel’? [-Werror=implicit-function-declaration] > 48 | writeq(0x0, privdata->mmio + AMD_C2P_MSG(1)); > | ^~~~~~ > | writel > ''' > > Basavaraj Natikar (2): > HID: amd_sfh: Fix implicit declaration error on i386 > HID: amd_sfh: Handle condition of "no sensors" > > drivers/hid/amd-sfh-hid/amd_sfh_client.c | 2 ++ > drivers/hid/amd-sfh-hid/sfh1_1/amd_sfh_interface.c | 2 ++ > 2 files changed, 4 insertions(+) Queued in hid.git, thanks.
Changes includes to handle "no sensors" case and fix of implicit declaration error on i386. Link: https://lore.kernel.org/all/92ed10f9-2c84-ad42-20d1-f8a101f78f08@infradead.org/ ''' From: Randy Dunlap <rdunlap@infradead.org> Changes since 20220721: on i386: ../drivers/hid/amd-sfh-hid/sfh1_1/amd_sfh_interface.c: In function ‘amd_stop_sensor’: ../drivers/hid/amd-sfh-hid/sfh1_1/amd_sfh_interface.c:48:9: error: implicit declaration of function ‘writeq’; did you mean ‘writel’? [-Werror=implicit-function-declaration] 48 | writeq(0x0, privdata->mmio + AMD_C2P_MSG(1)); | ^~~~~~ | writel ''' Basavaraj Natikar (2): HID: amd_sfh: Fix implicit declaration error on i386 HID: amd_sfh: Handle condition of "no sensors" drivers/hid/amd-sfh-hid/amd_sfh_client.c | 2 ++ drivers/hid/amd-sfh-hid/sfh1_1/amd_sfh_interface.c | 2 ++ 2 files changed, 4 insertions(+)