| Message ID | 20220628074848.5036-1-sreekanth.reddy@broadcom.com |
|---|---|
| Headers | show |
| Series | mpi3mr: Use shared host tagset | expand |
On 28/06/2022 18:41, Sreekanth Reddy wrote: > On Tue, Jun 28, 2022 at 8:32 PM John Garry <john.garry@huawei.com> wrote: >> >> On 28/06/2022 08:48, Sreekanth Reddy wrote: >>> Enable shared host tagset to make sure that total outstanding >>> IOs count won't cross controller's can_queue. >>> >>> Signed-off-by: Sreekanth Reddy <sreekanth.reddy@broadcom.com> >>> --- >>> drivers/scsi/mpi3mr/mpi3mr_os.c | 2 ++ >>> 1 file changed, 2 insertions(+) >>> >>> diff --git a/drivers/scsi/mpi3mr/mpi3mr_os.c b/drivers/scsi/mpi3mr/mpi3mr_os.c >>> index d8c195b..da85eda 100644 >>> --- a/drivers/scsi/mpi3mr/mpi3mr_os.c >>> +++ b/drivers/scsi/mpi3mr/mpi3mr_os.c >>> @@ -4321,6 +4321,8 @@ mpi3mr_probe(struct pci_dev *pdev, const struct pci_device_id *id) >>> shost->max_channel = 0; >>> shost->max_id = 0xFFFFFFFF; >>> >>> + shost->host_tagset = 1; >>> + >> >> nit: any reason not to set the flag in the scsi_host_template instead? > > There is no specific reason. Please let me know if I need to repost > the patch with the host_tagset flag set in the scsi_host_template. > You don't need to repost just for me. I was just hinting that this can be set in the scsi_host_template, which is a bit neater. Thanks, John >> >>> if (prot_mask >= 0) >>> scsi_host_set_prot(shost, prot_mask); >>> else { >>
Sreekanth, > - Enabled the shared host tagset, > - Also increased the cmd_per_lun to 128. Applied to 5.20/scsi-staging, thanks!
On Tue, 28 Jun 2022 13:18:46 +0530, Sreekanth Reddy wrote: > - Enabled the shared host tagset, > - Also increased the cmd_per_lun to 128. > > Sreekanth Reddy (2): > mpi3mr: Enable shared host tagset > mpi3mr: Increase cmd_per_lun to 128 > > [...] Applied to 5.20/scsi-queue, thanks! [1/2] mpi3mr: Enable shared host tagset https://git.kernel.org/mkp/scsi/c/465191d6526a [2/2] mpi3mr: Increase cmd_per_lun to 128 https://git.kernel.org/mkp/scsi/c/d29ea7b71621