| Message ID | c31b9c213e7c3b344b299abdbef87b7d1bc29d57.1657638462.git.Perry.Yuan@amd.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | AMD Pstate Enhancement And Issue Fixs | expand |
On 12-07-22, 11:43, Perry Yuan wrote: > "acpi_cpc_valid" function already includes the acpi_disabled check and we can > remove the duplicated check here > > Signed-off-by: Perry Yuan <Perry.Yuan@amd.com> > --- > drivers/base/arch_topology.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/base/arch_topology.c b/drivers/base/arch_topology.c > index 579c851a2bd7..73a8cb31529d 100644 > --- a/drivers/base/arch_topology.c > +++ b/drivers/base/arch_topology.c > @@ -352,7 +352,7 @@ void topology_init_cpu_capacity_cppc(void) > struct cppc_perf_caps perf_caps; > int cpu; > > - if (likely(acpi_disabled || !acpi_cpc_valid())) > + if (likely(!acpi_cpc_valid())) > return; > > raw_capacity = kcalloc(num_possible_cpus(), sizeof(*raw_capacity), Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
On Tue, Jul 12, 2022 at 11:43:05AM -0400, Perry Yuan wrote: > "acpi_cpc_valid" function already includes the acpi_disabled check and we can > remove the duplicated check here > Acked-by: Sudeep Holla <sudeep.holla@arm.com>
diff --git a/drivers/base/arch_topology.c b/drivers/base/arch_topology.c index 579c851a2bd7..73a8cb31529d 100644 --- a/drivers/base/arch_topology.c +++ b/drivers/base/arch_topology.c @@ -352,7 +352,7 @@ void topology_init_cpu_capacity_cppc(void) struct cppc_perf_caps perf_caps; int cpu; - if (likely(acpi_disabled || !acpi_cpc_valid())) + if (likely(!acpi_cpc_valid())) return; raw_capacity = kcalloc(num_possible_cpus(), sizeof(*raw_capacity),
"acpi_cpc_valid" function already includes the acpi_disabled check and we can remove the duplicated check here Signed-off-by: Perry Yuan <Perry.Yuan@amd.com> --- drivers/base/arch_topology.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)