| Message ID | 20220628193906.36350-3-andriy.shevchenko@linux.intel.com |
|---|---|
| State | Accepted |
| Commit | 6169d76c56b30e57fcb080206edd5324d9cea296 |
| Headers | show |
| Series | None | expand |
> -----Original Message----- > From: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > Sent: Dienstag, 28. Juni 2022 21:39 > To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>; linux- > gpio@vger.kernel.org; linux-kernel@vger.kernel.org > Cc: Hennerich, Michael <Michael.Hennerich@analog.com>; Linus Walleij > <linus.walleij@linaro.org>; Bartosz Golaszewski <brgl@bgdev.pl> > Subject: [PATCH v1 3/3] gpio: adp5588: sort header inclusion alphabetically > > > Sort header inclusion alphabetically. Hi Andy, Thanks for the patches, they look good. However, Nuno is currently working on getting the irqchip support into the adp5588 input driver. In his patch series this driver is going away. https://lore.kernel.org/linux-input/YpMCh1Xje+jsny8j@google.com/ Michael > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > --- > drivers/gpio/gpio-adp5588.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpio/gpio-adp5588.c b/drivers/gpio/gpio-adp5588.c index > d6a229a67044..d49f12560cde 100644 > --- a/drivers/gpio/gpio-adp5588.c > +++ b/drivers/gpio/gpio-adp5588.c > @@ -6,15 +6,15 @@ > * Copyright 2009-2010 Analog Devices Inc. > */ > > -#include <linux/kernel.h> > -#include <linux/slab.h> > -#include <linux/init.h> > -#include <linux/i2c.h> > #include <linux/gpio/driver.h> > +#include <linux/i2c.h> > +#include <linux/init.h> > #include <linux/interrupt.h> > #include <linux/irq.h> > +#include <linux/kernel.h> > #include <linux/mod_devicetable.h> > #include <linux/module.h> > +#include <linux/slab.h> > > #include <linux/platform_data/adp5588.h> > > -- > 2.35.1
On Wed, Jun 29, 2022 at 10:50 AM Hennerich, Michael <Michael.Hennerich@analog.com> wrote: > > > > > -----Original Message----- > > From: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > > Sent: Dienstag, 28. Juni 2022 21:39 > > To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>; linux- > > gpio@vger.kernel.org; linux-kernel@vger.kernel.org > > Cc: Hennerich, Michael <Michael.Hennerich@analog.com>; Linus Walleij > > <linus.walleij@linaro.org>; Bartosz Golaszewski <brgl@bgdev.pl> > > Subject: [PATCH v1 3/3] gpio: adp5588: sort header inclusion alphabetically > > > > Sort header inclusion alphabetically. > > Thanks for the patches, they look good. > However, Nuno is currently working on getting the irqchip support into the > adp5588 input driver. In his patch series this driver is going away. > > https://lore.kernel.org/linux-input/YpMCh1Xje+jsny8j@google.com/ While that work is ongoing, and most likely won't make v5.20-rc1, for the v5.20-rc1 I think my patches are good to go to avoid a bad (or rather very old) example on how to do GPIO drivers. What do you think?
On Wed, Jun 29, 2022 at 12:33 PM Andy Shevchenko <andy.shevchenko@gmail.com> wrote: > > On Wed, Jun 29, 2022 at 12:10 PM Sa, Nuno <Nuno.Sa@analog.com> wrote: > > > From: Andy Shevchenko <andy.shevchenko@gmail.com> > > > Sent: Wednesday, June 29, 2022 12:00 PM > > > On Wed, Jun 29, 2022 at 10:50 AM Hennerich, Michael > > > <Michael.Hennerich@analog.com> wrote: > > > > > -----Original Message----- > > > > > From: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > > > > > Sent: Dienstag, 28. Juni 2022 21:39 > > ... > > > > > > Sort header inclusion alphabetically. > > > > > > > > Thanks for the patches, they look good. > > > > However, Nuno is currently working on getting the irqchip support > > > into the > > > > adp5588 input driver. In his patch series this driver is going away. > > > > > > > > https://urldefense.com/v3/__https://lore.kernel.org/linux- > > > input/YpMCh1Xje*jsny8j@google.com/__;Kw!!A3Ni8CS0y2Y!_Cb1uAs > > > D- > > > Z6iz_zSDfrd5Va6zLmdoxjv1vLYWQGHDOqYniaXVVHl3Ou2lOUQIjwhSN > > > Ku2aZkYrOb8xMi2cZtfmsv$ > > > > > > While that work is ongoing, and most likely won't make v5.20-rc1, for > > > the v5.20-rc1 I think my patches are good to go to avoid a bad (or > > > rather very old) example on how to do GPIO drivers. What do you > > > think? > > > > Just as note, If nothing unexpected happens, I'm planning in sending this > > out today. If you still think this makes sense, fine by me. It's a very minimal > > change that won't give much pain to deal with... > > Ah, Okay, I was thinking about a week or two from now. Let's see how > it will go and let Linus decide how to proceed. With all respect to Linus, I had to put Bart :-)
> -----Original Message----- > From: Andy Shevchenko <andy.shevchenko@gmail.com> > Sent: Wednesday, June 29, 2022 12:33 PM > To: Sa, Nuno <Nuno.Sa@analog.com> > Cc: Hennerich, Michael <Michael.Hennerich@analog.com>; Andy > Shevchenko <andriy.shevchenko@linux.intel.com>; linux- > gpio@vger.kernel.org; linux-kernel@vger.kernel.org; Linus Walleij > <linus.walleij@linaro.org>; Bartosz Golaszewski <brgl@bgdev.pl> > Subject: Re: [PATCH v1 3/3] gpio: adp5588: sort header inclusion > alphabetically > > [External] > > On Wed, Jun 29, 2022 at 12:10 PM Sa, Nuno <Nuno.Sa@analog.com> > wrote: > > > From: Andy Shevchenko <andy.shevchenko@gmail.com> > > > Sent: Wednesday, June 29, 2022 12:00 PM > > > On Wed, Jun 29, 2022 at 10:50 AM Hennerich, Michael > > > <Michael.Hennerich@analog.com> wrote: > > > > > -----Original Message----- > > > > > From: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > > > > > Sent: Dienstag, 28. Juni 2022 21:39 > > ... > > > > > > Sort header inclusion alphabetically. > > > > > > > > Thanks for the patches, they look good. > > > > However, Nuno is currently working on getting the irqchip > support > > > into the > > > > adp5588 input driver. In his patch series this driver is going away. > > > > > > > > https://urldefense.com/v3/__https://lore.kernel.org/linux- > > > > input/YpMCh1Xje*jsny8j@google.com/__;Kw!!A3Ni8CS0y2Y!_Cb1uAs > > > D- > > > > Z6iz_zSDfrd5Va6zLmdoxjv1vLYWQGHDOqYniaXVVHl3Ou2lOUQIjwhSN > > > Ku2aZkYrOb8xMi2cZtfmsv$ > > > > > > While that work is ongoing, and most likely won't make v5.20-rc1, > for > > > the v5.20-rc1 I think my patches are good to go to avoid a bad (or > > > rather very old) example on how to do GPIO drivers. What do you > > > think? > > > > Just as note, If nothing unexpected happens, I'm planning in sending > this > > out today. If you still think this makes sense, fine by me. It's a very > minimal > > change that won't give much pain to deal with... > > Ah, Okay, I was thinking about a week or two from now. Let's see how > it will go and let Linus decide how to proceed. > Yeah, if it does not happen today, I will only get into it again next Wednesday (so in this case, might make sense). - Nuno Sá
On Wed, Jun 29, 2022 at 10:40:00AM +0000, Sa, Nuno wrote: > > From: Andy Shevchenko <andy.shevchenko@gmail.com> > > Sent: Wednesday, June 29, 2022 12:33 PM > > On Wed, Jun 29, 2022 at 12:10 PM Sa, Nuno <Nuno.Sa@analog.com> > > wrote: ... > > Ah, Okay, I was thinking about a week or two from now. Let's see how > > it will go and let Linus decide how to proceed. > > Yeah, if it does not happen today, I will only get into it again next > Wednesday (so in this case, might make sense). If I'm not mistaken, that didn't happen. Bart, can you apply this series then?
On Wed, Jul 6, 2022 at 2:15 PM Andy Shevchenko <andy.shevchenko@gmail.com> wrote: > > On Wed, Jun 29, 2022 at 10:40:00AM +0000, Sa, Nuno wrote: > > > From: Andy Shevchenko <andy.shevchenko@gmail.com> > > > Sent: Wednesday, June 29, 2022 12:33 PM > > > On Wed, Jun 29, 2022 at 12:10 PM Sa, Nuno <Nuno.Sa@analog.com> > > > wrote: > > ... > > > > Ah, Okay, I was thinking about a week or two from now. Let's see how > > > it will go and let Linus decide how to proceed. > > > > Yeah, if it does not happen today, I will only get into it again next > > Wednesday (so in this case, might make sense). > > If I'm not mistaken, that didn't happen. > > Bart, can you apply this series then? > > -- > With Best Regards, > Andy Shevchenko > > Now queued. Bart
diff --git a/drivers/gpio/gpio-adp5588.c b/drivers/gpio/gpio-adp5588.c index d6a229a67044..d49f12560cde 100644 --- a/drivers/gpio/gpio-adp5588.c +++ b/drivers/gpio/gpio-adp5588.c @@ -6,15 +6,15 @@ * Copyright 2009-2010 Analog Devices Inc. */ -#include <linux/kernel.h> -#include <linux/slab.h> -#include <linux/init.h> -#include <linux/i2c.h> #include <linux/gpio/driver.h> +#include <linux/i2c.h> +#include <linux/init.h> #include <linux/interrupt.h> #include <linux/irq.h> +#include <linux/kernel.h> #include <linux/mod_devicetable.h> #include <linux/module.h> +#include <linux/slab.h> #include <linux/platform_data/adp5588.h>
Sort header inclusion alphabetically. Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> --- drivers/gpio/gpio-adp5588.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)