| Message ID | 20220707213204.2605816-3-dmitry.baryshkov@linaro.org |
|---|---|
| State | New |
| Headers | show |
| Series | dt-bindings: msm/dp: cleanup Qualcomm DP and eDP bidndings | expand |
Quoting Dmitry Baryshkov (2022-07-07 14:31:57) > The commit 687825c402f1 ("dt-bindings: msm/dp: Change reg definition") > changed reg property to list separate register blocks, which broke > validation of DT files using single register block. Restore > compatibility with older (single register block) DT files by declaring > it as a deprecated alternative. I think the intention was to quickly migrate the dts files to the multiple register regions. Why not just do that and drop this deprecation binding update?
On 08/07/2022 04:29, Stephen Boyd wrote: > Quoting Dmitry Baryshkov (2022-07-07 14:31:57) >> The commit 687825c402f1 ("dt-bindings: msm/dp: Change reg definition") >> changed reg property to list separate register blocks, which broke >> validation of DT files using single register block. Restore >> compatibility with older (single register block) DT files by declaring >> it as a deprecated alternative. > > I think the intention was to quickly migrate the dts files to the > multiple register regions. Why not just do that and drop this > deprecation binding update? Ack, will do in v2.
diff --git a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml index d6bbe58ef9e8..dde82d5f6610 100644 --- a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml +++ b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml @@ -24,11 +24,15 @@ properties: - qcom,sm8350-dp reg: - items: - - description: ahb register block - - description: aux register block - - description: link register block - - description: p0 register block + oneOf: + - items: + - description: ahb register block + - description: aux register block + - description: link register block + - description: p0 register block + - items: + - description: DP register block + deprecated: true interrupts: maxItems: 1
The commit 687825c402f1 ("dt-bindings: msm/dp: Change reg definition") changed reg property to list separate register blocks, which broke validation of DT files using single register block. Restore compatibility with older (single register block) DT files by declaring it as a deprecated alternative. Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> --- .../bindings/display/msm/dp-controller.yaml | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-)