| Message ID | 20220629164414.301813-1-viorel.suman@oss.nxp.com |
|---|---|
| Headers | show |
| Series | dt-bindings: arm: freescale: Switch fsl,scu from txt to yaml | expand |
On Wed, 29 Jun 2022 19:44:09 +0300, Viorel Suman (OSS) wrote: > From: Abel Vesa <abel.vesa@nxp.com> > > In order to replace the fsl,scu txt file from bindings/arm/freescale, > we need to split it between the right subsystems. This patch adds the > fsl,scu.yaml in the firmware bindings folder. This one is only for > the main SCU node. The old txt file will be removed only after all > the child nodes have been properly switch to yaml. > > Signed-off-by: Abel Vesa <abel.vesa@nxp.com> > Signed-off-by: Viorel Suman <viorel.suman@nxp.com> > --- > .../devicetree/bindings/firmware/fsl,scu.yaml | 160 ++++++++++++++++++ > 1 file changed, 160 insertions(+) > create mode 100644 Documentation/devicetree/bindings/firmware/fsl,scu.yaml > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: ./Documentation/devicetree/bindings/firmware/fsl,scu.yaml: Unable to find schema file matching $id: http://devicetree.org/schemas/clock/fsl,scu-clk.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/firmware/fsl,scu.example.dtb: system-controller: clock-controller: False schema does not allow {'compatible': ['fsl,imx8qxp-clk', 'fsl,scu-clk'], '#clock-cells': [[2]]} From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/firmware/fsl,scu.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/firmware/fsl,scu.example.dtb: system-controller: pinctrl: False schema does not allow {'compatible': ['fsl,imx8qxp-iomuxc'], 'lpuart0grp': {'fsl,pins': [[111, 0, 100663328, 112, 0, 100663328]]}} From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/firmware/fsl,scu.yaml Documentation/devicetree/bindings/firmware/fsl,scu.example.dtb:0:0: /example-0/firmware/system-controller/clock-controller: failed to match any schema with compatible: ['fsl,imx8qxp-clk', 'fsl,scu-clk'] Documentation/devicetree/bindings/firmware/fsl,scu.example.dtb:0:0: /example-0/firmware/system-controller/clock-controller: failed to match any schema with compatible: ['fsl,imx8qxp-clk', 'fsl,scu-clk'] Documentation/devicetree/bindings/firmware/fsl,scu.example.dtb:0:0: /example-0/firmware/system-controller/pinctrl: failed to match any schema with compatible: ['fsl,imx8qxp-iomuxc'] doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/patch/ This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit.
On 30/06/2022 14:13, Viorel Suman (OSS) wrote: > On 22-06-29 19:51:06, Krzysztof Kozlowski wrote: >> On 29/06/2022 18:44, Viorel Suman (OSS) wrote: >>> From: Viorel Suman <viorel.suman@nxp.com> >>> >>> Changes since v5: https://lore.kernel.org/lkml/20220616164303.790379-1-viorel.suman@nxp.com/ >>> * Updated according to Krzysztof Kozlowski comments >>> >> >> My comment a about removal of each part of TXT bindings in each patch, >> was not addressed. Your approach makes it more difficult to read patches >> and makes sense only if each subsystem maintainer will take the patches >> (separately). If the patches are going through one tree, then better to >> remove the TXT gradually. >> >> So the question - who is going to take each of the patches? > > Hi Krzysztof, > > I just understood the context of your comment, will do it in the next version. > > Assuming TXT is removed from aggregating TXT - fsl,scu.txt - gradually, do you expect the > removed to be added into the aggregating YAML - fsl,scu.yaml - also gradually within the > same patch ? Each patch making the conversion should remove the piece being converted. Then finally the patch adding fsl,scu.yaml should remove the last pieces (remaining ones). Best regards, Krzysztof
On Wed, Jun 29, 2022 at 07:51:06PM +0200, Krzysztof Kozlowski wrote: > On 29/06/2022 18:44, Viorel Suman (OSS) wrote: > > From: Viorel Suman <viorel.suman@nxp.com> > > > > Changes since v5: https://lore.kernel.org/lkml/20220616164303.790379-1-viorel.suman@nxp.com/ > > * Updated according to Krzysztof Kozlowski comments > > > > My comment a about removal of each part of TXT bindings in each patch, > was not addressed. Your approach makes it more difficult to read patches > and makes sense only if each subsystem maintainer will take the patches > (separately). If the patches are going through one tree, then better to > remove the TXT gradually. > > So the question - who is going to take each of the patches? I can take the series through IMX tree if that makes the most sense. Shawn
On 05/07/2022 02:39, Shawn Guo wrote: > On Wed, Jun 29, 2022 at 07:51:06PM +0200, Krzysztof Kozlowski wrote: >> On 29/06/2022 18:44, Viorel Suman (OSS) wrote: >>> From: Viorel Suman <viorel.suman@nxp.com> >>> >>> Changes since v5: https://lore.kernel.org/lkml/20220616164303.790379-1-viorel.suman@nxp.com/ >>> * Updated according to Krzysztof Kozlowski comments >>> >> >> My comment a about removal of each part of TXT bindings in each patch, >> was not addressed. Your approach makes it more difficult to read patches >> and makes sense only if each subsystem maintainer will take the patches >> (separately). If the patches are going through one tree, then better to >> remove the TXT gradually. >> >> So the question - who is going to take each of the patches? > > I can take the series through IMX tree if that makes the most sense. Sounds fine to me. Then however each piece of TXT file should be removed in each commit doing that piece conversion. Best regards, Krzysztof
On 22-07-05 09:28:24, Krzysztof Kozlowski wrote: > On 05/07/2022 02:39, Shawn Guo wrote: > > On Wed, Jun 29, 2022 at 07:51:06PM +0200, Krzysztof Kozlowski wrote: > >> On 29/06/2022 18:44, Viorel Suman (OSS) wrote: > >>> From: Viorel Suman <viorel.suman@nxp.com> > >>> > >>> Changes since v5: https://lore.kernel.org/lkml/20220616164303.790379-1-viorel.suman@nxp.com/ > >>> * Updated according to Krzysztof Kozlowski comments > >>> > >> > >> My comment a about removal of each part of TXT bindings in each patch, > >> was not addressed. Your approach makes it more difficult to read patches > >> and makes sense only if each subsystem maintainer will take the patches > >> (separately). If the patches are going through one tree, then better to > >> remove the TXT gradually. > >> > >> So the question - who is going to take each of the patches? > > > > I can take the series through IMX tree if that makes the most sense. > > Sounds fine to me. Then however each piece of TXT file should be removed > in each commit doing that piece conversion. > > Best regards, > Krzysztof Just sent v7 which removes TXT in each commit which does the conversion. Regards, Viorel
From: Viorel Suman <viorel.suman@nxp.com> Changes since v5: https://lore.kernel.org/lkml/20220616164303.790379-1-viorel.suman@nxp.com/ * Updated according to Krzysztof Kozlowski comments Changes since v4: https://lore.kernel.org/lkml/20220615105834.743045-1-viorel.suman@nxp.com/ * Missing SoB added Changes since v3: https://lore.kernel.org/lkml/20220609143423.2839186-1-abel.vesa@nxp.com/ * Examples included * Included Abel's patches fixing thermal zone, keys and power controller names. Abel Vesa (13): dt-bindings: clk: imx: Add fsl,scu-clk yaml file dt-bindings: pinctrl: imx: Add fsl,scu-iomux yaml file dt-bindings: input: Add fsl,scu-key yaml file dt-bindings: nvmem: Add fsl,scu-ocotp yaml file dt-bindings: power: Add fsl,scu-pd yaml file dt-bindings: rtc: Add fsl,scu-rtc yaml file dt-bindings: thermal: Add fsl,scu-thermal yaml file dt-bindings: watchdog: Add fsl,scu-wdt yaml file dt-bindings: firmware: Add fsl,scu yaml file arm64: dts: freescale: imx8: Fix power controller name arm64: dts: freescale: imx8qxp: Add fallback compatible for clock controller arm64: dts: freescale: imx8qxp: Fix the keys node name dt-bindings: arm: freescale: Remove fsl,scu txt file Viorel Suman (1): arm64: dts: freescale: imx8qxp: Remove unnecessary clock related entries .../bindings/arm/freescale/fsl,scu.txt | 271 ------------------ .../bindings/clock/fsl,scu-clk.yaml | 43 +++ .../devicetree/bindings/firmware/fsl,scu.yaml | 160 +++++++++++ .../bindings/input/fsl,scu-key.yaml | 40 +++ .../bindings/nvmem/fsl,scu-ocotp.yaml | 57 ++++ .../bindings/pinctrl/fsl,scu-pinctrl.yaml | 68 +++++ .../devicetree/bindings/power/fsl,scu-pd.yaml | 41 +++ .../devicetree/bindings/rtc/fsl,scu-rtc.yaml | 31 ++ .../bindings/thermal/fsl,scu-thermal.yaml | 38 +++ .../bindings/watchdog/fsl,scu-wdt.yaml | 34 +++ arch/arm64/boot/dts/freescale/imx8qm.dtsi | 2 +- arch/arm64/boot/dts/freescale/imx8qxp.dtsi | 8 +- 12 files changed, 516 insertions(+), 277 deletions(-) delete mode 100644 Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt create mode 100644 Documentation/devicetree/bindings/clock/fsl,scu-clk.yaml create mode 100644 Documentation/devicetree/bindings/firmware/fsl,scu.yaml create mode 100644 Documentation/devicetree/bindings/input/fsl,scu-key.yaml create mode 100644 Documentation/devicetree/bindings/nvmem/fsl,scu-ocotp.yaml create mode 100644 Documentation/devicetree/bindings/pinctrl/fsl,scu-pinctrl.yaml create mode 100644 Documentation/devicetree/bindings/power/fsl,scu-pd.yaml create mode 100644 Documentation/devicetree/bindings/rtc/fsl,scu-rtc.yaml create mode 100644 Documentation/devicetree/bindings/thermal/fsl,scu-thermal.yaml create mode 100644 Documentation/devicetree/bindings/watchdog/fsl,scu-wdt.yaml