| Message ID | 20220607102126.2605773-1-etienne.carriere@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [v3,1/3] drivers: tee: optee: remove unused probe local variable | expand |
Hi Etienne, On 6/7/22 12:21, Etienne Carriere wrote: > Removes local variable child in optee_probe() that is not used. > > Cc: Patrick Delaunay <patrick.delaunay@foss.st.com> > Signed-off-by: Etienne Carriere <etienne.carriere@linaro.org> > --- > No change since v2. > > New change not in v1 series. > --- > drivers/tee/optee/core.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/tee/optee/core.c b/drivers/tee/optee/core.c > index a89d62aaf0..c1f5fc4c7a 100644 > --- a/drivers/tee/optee/core.c > +++ b/drivers/tee/optee/core.c > @@ -642,7 +642,6 @@ static int optee_probe(struct udevice *dev) > { > struct optee_pdata *pdata = dev_get_plat(dev); > u32 sec_caps; > - struct udevice *child; > int ret; > > if (!is_optee_api(pdata->invoke_fn)) { > @@ -673,7 +672,7 @@ static int optee_probe(struct udevice *dev) > * only bind the drivers associated to the supported OP-TEE TA > */ > if (IS_ENABLED(CONFIG_RNG_OPTEE)) { > - ret = device_bind_driver(dev, "optee-rng", "optee-rng", &child); > + ret = device_bind_driver(dev, "optee-rng", "optee-rng", NULL); > if (ret) > return ret; > } Reviewed-by: Patrick Delaunay <patrick.delaunay@foss.st.com> Thanks Patrick
On Tue, 7 Jun 2022 at 13:22, Etienne Carriere <etienne.carriere@linaro.org> wrote: > > Removes local variable child in optee_probe() that is not used. > > Cc: Patrick Delaunay <patrick.delaunay@foss.st.com> > Signed-off-by: Etienne Carriere <etienne.carriere@linaro.org> > --- > No change since v2. > > New change not in v1 series. > --- > drivers/tee/optee/core.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/tee/optee/core.c b/drivers/tee/optee/core.c > index a89d62aaf0..c1f5fc4c7a 100644 > --- a/drivers/tee/optee/core.c > +++ b/drivers/tee/optee/core.c > @@ -642,7 +642,6 @@ static int optee_probe(struct udevice *dev) > { > struct optee_pdata *pdata = dev_get_plat(dev); > u32 sec_caps; > - struct udevice *child; > int ret; > > if (!is_optee_api(pdata->invoke_fn)) { > @@ -673,7 +672,7 @@ static int optee_probe(struct udevice *dev) > * only bind the drivers associated to the supported OP-TEE TA > */ > if (IS_ENABLED(CONFIG_RNG_OPTEE)) { > - ret = device_bind_driver(dev, "optee-rng", "optee-rng", &child); > + ret = device_bind_driver(dev, "optee-rng", "optee-rng", NULL); > if (ret) > return ret; > } > -- > 2.25.1 > Reviewed-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>
diff --git a/drivers/tee/optee/core.c b/drivers/tee/optee/core.c index a89d62aaf0..c1f5fc4c7a 100644 --- a/drivers/tee/optee/core.c +++ b/drivers/tee/optee/core.c @@ -642,7 +642,6 @@ static int optee_probe(struct udevice *dev) { struct optee_pdata *pdata = dev_get_plat(dev); u32 sec_caps; - struct udevice *child; int ret; if (!is_optee_api(pdata->invoke_fn)) { @@ -673,7 +672,7 @@ static int optee_probe(struct udevice *dev) * only bind the drivers associated to the supported OP-TEE TA */ if (IS_ENABLED(CONFIG_RNG_OPTEE)) { - ret = device_bind_driver(dev, "optee-rng", "optee-rng", &child); + ret = device_bind_driver(dev, "optee-rng", "optee-rng", NULL); if (ret) return ret; }
Removes local variable child in optee_probe() that is not used. Cc: Patrick Delaunay <patrick.delaunay@foss.st.com> Signed-off-by: Etienne Carriere <etienne.carriere@linaro.org> --- No change since v2. New change not in v1 series. --- drivers/tee/optee/core.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)