Message ID | 20220623070550.82053-1-helei.sig11@bytedance.com |
---|---|
Headers | show |
Series | virtio-crypto: support ECDSA algorithm | expand |
On Thu, Jun 23, 2022 at 03:05:46PM +0800, Lei He wrote: > From: lei he <helei.sig11@bytedance.com> > > This patch supports the ECDSA algorithm for virtio-crypto. virtio parts: Acked-by: Michael S. Tsirkin <mst@redhat.com> > V1 -> V2: > - explicitly specified an appropriate base commit. > - fixed the link error reported by kernel test robot <lkp@intl.com>. > - removed irrelevant commits. > > V1: > - fixed the problem that the max_signature_size of ECDSA is > incorrectly calculated. > - make pkcs8_private_key_parser can identify ECDSA private keys. > - implement ECDSA algorithm for virtio-crypto device > > > lei he (4): > crypto: fix the calculation of max_size for ECDSA > crypto: pkcs8 parser support ECDSA private keys > crypto: remove unused field in pkcs8_parse_context > virtio-crypto: support ECDSA algorithm > > crypto/Kconfig | 1 + > crypto/Makefile | 2 + > crypto/akcipher.c | 10 + > crypto/asymmetric_keys/pkcs8.asn1 | 2 +- > crypto/asymmetric_keys/pkcs8_parser.c | 46 +++- > crypto/ecdsa.c | 3 +- > crypto/ecdsa_helper.c | 45 +++ > drivers/crypto/virtio/Kconfig | 1 + > .../virtio/virtio_crypto_akcipher_algs.c | 259 ++++++++++++++++-- > include/crypto/internal/ecdsa.h | 15 + > include/linux/asn1_encoder.h | 2 + > lib/asn1_encoder.c | 3 +- > 12 files changed, 361 insertions(+), 28 deletions(-) > create mode 100644 crypto/ecdsa_helper.c > create mode 100644 include/crypto/internal/ecdsa.h > > > base-commit: 018ab4fabddd94f1c96f3b59e180691b9e88d5d8 > -- > 2.20.1
On Thu, Jun 30, 2022 at 4:37 PM Lei He <helei.sig11@bytedance.com> wrote:
> I have explained above why we need a driver that supports ECDSA, ...
I do not think we do. There are some security concerns.
https://en.wikipedia.org/wiki/Elliptic_Curve_Digital_Signature_Algorithm#Security
On Thu, Jun 23, 2022 at 03:05:46PM +0800, Lei He wrote: > From: lei he <helei.sig11@bytedance.com> > > This patch supports the ECDSA algorithm for virtio-crypto. > > V1 -> V2: > - explicitly specified an appropriate base commit. > - fixed the link error reported by kernel test robot <lkp@intl.com>. > - removed irrelevant commits. > > V1: > - fixed the problem that the max_signature_size of ECDSA is > incorrectly calculated. > - make pkcs8_private_key_parser can identify ECDSA private keys. > - implement ECDSA algorithm for virtio-crypto device So this depends on core crypto changes that need Herbert's ack. I'll drop this from my radar for now. > > lei he (4): > crypto: fix the calculation of max_size for ECDSA > crypto: pkcs8 parser support ECDSA private keys > crypto: remove unused field in pkcs8_parse_context > virtio-crypto: support ECDSA algorithm > > crypto/Kconfig | 1 + > crypto/Makefile | 2 + > crypto/akcipher.c | 10 + > crypto/asymmetric_keys/pkcs8.asn1 | 2 +- > crypto/asymmetric_keys/pkcs8_parser.c | 46 +++- > crypto/ecdsa.c | 3 +- > crypto/ecdsa_helper.c | 45 +++ > drivers/crypto/virtio/Kconfig | 1 + > .../virtio/virtio_crypto_akcipher_algs.c | 259 ++++++++++++++++-- > include/crypto/internal/ecdsa.h | 15 + > include/linux/asn1_encoder.h | 2 + > lib/asn1_encoder.c | 3 +- > 12 files changed, 361 insertions(+), 28 deletions(-) > create mode 100644 crypto/ecdsa_helper.c > create mode 100644 include/crypto/internal/ecdsa.h > > > base-commit: 018ab4fabddd94f1c96f3b59e180691b9e88d5d8 > -- > 2.20.1
From: lei he <helei.sig11@bytedance.com> This patch supports the ECDSA algorithm for virtio-crypto. V1 -> V2: - explicitly specified an appropriate base commit. - fixed the link error reported by kernel test robot <lkp@intl.com>. - removed irrelevant commits. V1: - fixed the problem that the max_signature_size of ECDSA is incorrectly calculated. - make pkcs8_private_key_parser can identify ECDSA private keys. - implement ECDSA algorithm for virtio-crypto device lei he (4): crypto: fix the calculation of max_size for ECDSA crypto: pkcs8 parser support ECDSA private keys crypto: remove unused field in pkcs8_parse_context virtio-crypto: support ECDSA algorithm crypto/Kconfig | 1 + crypto/Makefile | 2 + crypto/akcipher.c | 10 + crypto/asymmetric_keys/pkcs8.asn1 | 2 +- crypto/asymmetric_keys/pkcs8_parser.c | 46 +++- crypto/ecdsa.c | 3 +- crypto/ecdsa_helper.c | 45 +++ drivers/crypto/virtio/Kconfig | 1 + .../virtio/virtio_crypto_akcipher_algs.c | 259 ++++++++++++++++-- include/crypto/internal/ecdsa.h | 15 + include/linux/asn1_encoder.h | 2 + lib/asn1_encoder.c | 3 +- 12 files changed, 361 insertions(+), 28 deletions(-) create mode 100644 crypto/ecdsa_helper.c create mode 100644 include/crypto/internal/ecdsa.h base-commit: 018ab4fabddd94f1c96f3b59e180691b9e88d5d8