| Message ID | 753f19393f169ad4a5fc127f68e16074f1617306.1655944385.git.objelf@gmail.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [1/2] mt76: mt7921: reduce log severity levels for informative messages | expand |
Il 23/06/22 02:35, sean.wang@mediatek.com ha scritto: > From: Sean Wang <sean.wang@mediatek.com> > > Reduce the mutex lock scope for reset to get rid of possible task hung > e.g wpa_supplicant and to allow the user-space process to keep running > during we need more retries to complete the reset. > To actually, effectively, reduce the chance to get a hung task, and also to improve the general responsiveness, I think that the best way would be to manage the locking inside of the reset callback(s) for each dev/bus. This is especially because some of these reset functions (like the SDIO one) may end up waiting for more than *two seconds*. However, I get that this proposal requires way more effort, and this commit will anyway improve the situation as it is... so, you get my: Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> > Suggested-by: YN Chen <YN.Chen@mediatek.com> > Signed-off-by: Sean Wang <sean.wang@mediatek.com>
AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> writes: > Il 23/06/22 02:35, sean.wang@mediatek.com ha scritto: >> From: Sean Wang <sean.wang@mediatek.com> >> >> Use dev_info instead for the informative messages. >> >> Signed-off-by: Sean Wang <sean.wang@mediatek.com> >> --- >> drivers/net/wireless/mediatek/mt76/mt7921/mac.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/net/wireless/mediatek/mt76/mt7921/mac.c b/drivers/net/wireless/mediatek/mt76/mt7921/mac.c >> index eb1bfb682e02..2ce3a833176e 100644 >> --- a/drivers/net/wireless/mediatek/mt76/mt7921/mac.c >> +++ b/drivers/net/wireless/mediatek/mt76/mt7921/mac.c >> @@ -740,7 +740,7 @@ void mt7921_mac_reset_work(struct work_struct *work) >> struct mt76_connac_pm *pm = &dev->pm; >> int i; >> - dev_err(dev->mt76.dev, "chip reset\n"); >> + dev_info(dev->mt76.dev, "chip reset\n"); > > Since this function is normally expected to be called and this message is > describing the wanted flow and/or this worker function starting, I'd say > that this is not a really important information anyway... > > What about changing that one to a dev_dbg() instead? Yeah, that would be better.
diff --git a/drivers/net/wireless/mediatek/mt76/mt7921/mac.c b/drivers/net/wireless/mediatek/mt76/mt7921/mac.c index eb1bfb682e02..2ce3a833176e 100644 --- a/drivers/net/wireless/mediatek/mt76/mt7921/mac.c +++ b/drivers/net/wireless/mediatek/mt76/mt7921/mac.c @@ -740,7 +740,7 @@ void mt7921_mac_reset_work(struct work_struct *work) struct mt76_connac_pm *pm = &dev->pm; int i; - dev_err(dev->mt76.dev, "chip reset\n"); + dev_info(dev->mt76.dev, "chip reset\n"); dev->hw_full_reset = true; ieee80211_stop_queues(hw);