diff mbox series

[v9,11/12] dt-bindings: arm: freescale: scu-ocotp: Add i.MX8DXL compatible string

Message ID 20220607111625.1845393-12-abel.vesa@nxp.com
State New
Headers show
Series [v9,01/12] arm64: dts: freescale: Add adma subsystem dtsi for imx8dxl | expand

Commit Message

Abel Vesa June 7, 2022, 11:16 a.m. UTC
Add i.MX8DXL compatible string to the scu-ocotp bindings.

Signed-off-by: Abel Vesa <abel.vesa@nxp.com>
---
 .../devicetree/bindings/arm/freescale/fsl,scu-ocotp.yaml        | 2 ++
 1 file changed, 2 insertions(+)

Comments

Rob Herring (Arm) June 28, 2022, 2:34 p.m. UTC | #1
On Tue, Jun 07, 2022 at 02:16:24PM +0300, Abel Vesa wrote:
> Add i.MX8DXL compatible string to the scu-ocotp bindings.
> 
> Signed-off-by: Abel Vesa <abel.vesa@nxp.com>
> ---
>  .../devicetree/bindings/arm/freescale/fsl,scu-ocotp.yaml        | 2 ++
>  1 file changed, 2 insertions(+)

Why are you adding this patch which adds a dependency on v9 of your 
series?

> 
> diff --git a/Documentation/devicetree/bindings/arm/freescale/fsl,scu-ocotp.yaml b/Documentation/devicetree/bindings/arm/freescale/fsl,scu-ocotp.yaml
> index 1c2d2486f366..73c9bd16ec35 100644
> --- a/Documentation/devicetree/bindings/arm/freescale/fsl,scu-ocotp.yaml
> +++ b/Documentation/devicetree/bindings/arm/freescale/fsl,scu-ocotp.yaml
> @@ -20,7 +20,9 @@ properties:
>            - enum:
>                - fsl,imx8qm-scu-ocotp
>                - fsl,imx8qxp-scu-ocotp
> +              - fsl,imx8dxl-scu-ocotp
>        - items:
> +          - const: fsl,imx8dxl-scu-ocotp
>            - const: fsl,imx8qxp-scu-ocotp

This doesn't make sense. Either you have a fallback or you don't.

>  
>    '#address-cells':
> -- 
> 2.34.3
> 
>
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/arm/freescale/fsl,scu-ocotp.yaml b/Documentation/devicetree/bindings/arm/freescale/fsl,scu-ocotp.yaml
index 1c2d2486f366..73c9bd16ec35 100644
--- a/Documentation/devicetree/bindings/arm/freescale/fsl,scu-ocotp.yaml
+++ b/Documentation/devicetree/bindings/arm/freescale/fsl,scu-ocotp.yaml
@@ -20,7 +20,9 @@  properties:
           - enum:
               - fsl,imx8qm-scu-ocotp
               - fsl,imx8qxp-scu-ocotp
+              - fsl,imx8dxl-scu-ocotp
       - items:
+          - const: fsl,imx8dxl-scu-ocotp
           - const: fsl,imx8qxp-scu-ocotp
 
   '#address-cells':