diff mbox series

[net-next,2/2] dt-bindings: net: adin1110: Add docs

Message ID 20220624200628.77047-3-alexandru.tachici@analog.com
State New
Headers show
Series [net-next,1/2] net: ethernet: adi: Add ADIN1110 support | expand

Commit Message

Alexandru Tachici June 24, 2022, 8:06 p.m. UTC 
From: Alexandru Tachici <alexandru.tachici@analog.com>

Add bindings for the ADIN1110/2111 MAC-PHY/SWITCH.

Signed-off-by: Alexandru Tachici <alexandru.tachici@analog.com>
---
 .../devicetree/bindings/net/adi,adin1110.yaml | 127 ++++++++++++++++++
 1 file changed, 127 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/net/adi,adin1110.yaml

Comments

Andrew Lunn June 26, 2022, 10:06 a.m. UTC | #1 
> +patternProperties:
> +  "^phy@[0-1]$":
> +    description: |
> +      ADIN1100 PHY that is present on the same chip as the MAC.
> +    type: object
> +
> +    properties:
> +      reg:
> +        items:
> +          maximum: 1
> +
> +    allOf:
> +      - if:
> +          properties:
> +            compatible:
> +              contains:
> +                const: adi,adin1110
> +        then:
> +          properties:
> +            compatible:
> +              const: ethernet-phy-id0283.bc91
> +        else:
> +          properties:
> +            compatible:
> +              const: ethernet-phy-id0283.bca1
> +
> +    required:
> +      - compatible
> +      - reg

Why is any of this needed? You register an MDIO bus and then use the
PHY at address 0 or 1. phylib should find the PHY and read its ID
register to load the driver. So i don't think there is anything useful
here.

	Andrew
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/net/adi,adin1110.yaml b/Documentation/devicetree/bindings/net/adi,adin1110.yaml
new file mode 100644
index 000000000000..0ac18dd62e5a
--- /dev/null
+++ b/Documentation/devicetree/bindings/net/adi,adin1110.yaml
@@ -0,0 +1,127 @@ 
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: "http://devicetree.org/schemas/net/adi,adin1110.yaml#"
+$schema: "http://devicetree.org/meta-schemas/core.yaml#"
+
+title: ADI ADIN1110 MAC-PHY
+
+allOf:
+  - $ref: ethernet-controller.yaml#
+  - $ref: spi-controller.yaml#
+
+maintainers:
+  - Alexandru Tachici <alexandru.tachici@analog.com>
+
+description: |
+  The ADIN1110 is a low power single port 10BASE-T1L MAC-
+  PHY designed for industrial Ethernet applications. It integrates
+  an Ethernet PHY core with a MAC and all the associated analog
+  circuitry, input and output clock buffering.
+
+  The ADIN2111 is a low power, low complexity, two-Ethernet ports
+  switch with integrated 10BASE-T1L PHYs and one serial peripheral
+  interface (SPI) port. The device is designed for industrial Ethernet
+  applications using low power constrained nodes and is compliant
+  with the IEEE 802.3cg-2019 Ethernet standard for long reach
+  10 Mbps single pair Ethernet (SPE).
+
+  The device has a 4-wire SPI interface for communication
+  between the MAC and host processor.
+
+properties:
+  compatible:
+    enum:
+      - adi,adin1110
+      - adi,adin2111
+
+  '#address-cells':
+    const: 1
+
+  '#size-cells':
+    const: 0
+
+  reg:
+    maxItems: 1
+
+  adi,spi-crc:
+    description: |
+      Enable CRC8 checks on SPI read/writes.
+    type: boolean
+
+  interrupts:
+    maxItems: 1
+
+patternProperties:
+  "^phy@[0-1]$":
+    description: |
+      ADIN1100 PHY that is present on the same chip as the MAC.
+    type: object
+
+    properties:
+      reg:
+        items:
+          maximum: 1
+
+    allOf:
+      - if:
+          properties:
+            compatible:
+              contains:
+                const: adi,adin1110
+        then:
+          properties:
+            compatible:
+              const: ethernet-phy-id0283.bc91
+        else:
+          properties:
+            compatible:
+              const: ethernet-phy-id0283.bca1
+
+    required:
+      - compatible
+      - reg
+
+required:
+  - compatible
+  - reg
+  - interrupts
+  - phy@0
+
+unevaluatedProperties: false
+
+examples:
+  - |
+        spi0 {
+                #address-cells = <1>;
+                #size-cells = <0>;
+                status = "okay";
+
+                ethernet@0 {
+                        compatible = "adi,adin2111";
+                        reg = <0>;
+                        spi-max-frequency = <24500000>;
+
+                        adi,spi-crc;
+
+                        #address-cells = <1>;
+                        #size-cells = <0>;
+
+                        interrupt-parent = <&gpio>;
+                        interrupts = <25 2>;
+
+                        mac-address = [ ca 2f b7 10 23 63 ];
+
+                        phy@0 {
+                                #phy-cells = <0>;
+                                compatible = "ethernet-phy-id0283.bca1";
+                                reg = <0>;
+                        };
+
+                        phy@1 {
+                                #phy-cells = <0>;
+                                compatible = "ethernet-phy-id0283.bca1";
+                                reg = <1>;
+                        };
+                };
+        };