mbox series

[v1,0/4] clk: qcom: add SM8450 Display clock controller support

Message ID 20220623114737.247703-1-dmitry.baryshkov@linaro.org
Headers show
Series clk: qcom: add SM8450 Display clock controller support | expand

Message

Dmitry Baryshkov June 23, 2022, 11:47 a.m. UTC 
Add support for the Display clock controller found on SM8450 platform.
This patchseries depends on [1] for the Lucid EVO PLL support.

[1] https://lore.kernel.org/linux-arm-msm/20220610104951.2296533-1-vladimir.zapolskiy@linaro.org/

Dmitry Baryshkov (4):
  dt-bindings: clock: qcom: add bindings for dispcc on SM8450
  clk: qcom: Add support for Display Clock Controller on SM8450
  clk: qcom: alpha-pll: add support for power off mode for lucid evo PLL
  arm64: dts: qcom: sm8450: add display clock controller

 .../bindings/clock/qcom,dispcc-sm8450.yaml    |  132 ++
 arch/arm64/boot/dts/qcom/sm8450.dtsi          |   35 +
 drivers/clk/qcom/Kconfig                      |    9 +
 drivers/clk/qcom/Makefile                     |    1 +
 drivers/clk/qcom/clk-alpha-pll.c              |   40 +-
 drivers/clk/qcom/clk-alpha-pll.h              |    1 +
 drivers/clk/qcom/dispcc-sm8450.c              | 1806 +++++++++++++++++
 .../dt-bindings/clock/qcom,dispcc-sm8450.h    |  103 +
 8 files changed, 2124 insertions(+), 3 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/clock/qcom,dispcc-sm8450.yaml
 create mode 100644 drivers/clk/qcom/dispcc-sm8450.c
 create mode 100644 include/dt-bindings/clock/qcom,dispcc-sm8450.h


base-commit: f2906aa863381afb0015a9eb7fefad885d4e5a56
prerequisite-patch-id: 718981be9b1a9aa9a6780c04f8ae305958c133d2

Comments

Krzysztof Kozlowski June 24, 2022, 3:59 p.m. UTC | #1 
On 23/06/2022 13:47, Dmitry Baryshkov wrote:
> Add device tree bindings for the display clock controller on Qualcomm
> SM8450 platform.
> 
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
>  .../bindings/clock/qcom,dispcc-sm8450.yaml    | 132 ++++++++++++++++++
>  1 file changed, 132 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/clock/qcom,dispcc-sm8450.yaml
> 


Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>


Best regards,
Krzysztof
Rob Herring (Arm) June 24, 2022, 5:26 p.m. UTC | #2 
On Thu, 23 Jun 2022 14:47:34 +0300, Dmitry Baryshkov wrote:
> Add device tree bindings for the display clock controller on Qualcomm
> SM8450 platform.
> 
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
>  .../bindings/clock/qcom,dispcc-sm8450.yaml    | 132 ++++++++++++++++++
>  1 file changed, 132 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/clock/qcom,dispcc-sm8450.yaml
> 

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/clock/qcom,dispcc-sm8450.example.dtb: clock-controller@af00000: clocks: [[4294967295, 0], [4294967295, 1], [4294967295, 0], [4294967295, 1], [4294967295, 0], [4294967295, 1, 0, 0, 0, 0, 0, 0, 0, 0], [4294967295]] is too short
	From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/clock/qcom,dispcc-sm8450.yaml

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/patch/

This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit.