diff mbox series

[v2] gpio: xilinx: add missing blank line after declarations

Message ID 20220502110040.12225-1-shubhrajyoti.datta@xilinx.com
State Superseded
Headers show
Series [v2] gpio: xilinx: add missing blank line after declarations | expand

Commit Message

Shubhrajyoti Datta May 2, 2022, 11 a.m. UTC 
Add a missing blank line. No functional changes.

WARNING: Missing a blank line after declarations
128: FILE: drivers/gpio/gpio-xilinx.c:120:
+       void __iomem *addr = chip->regs + reg + xgpio_regoffset(chip, bit / 32);
+       xgpio_set_value32(a, bit, xgpio_readreg(addr));

WARNING: Missing a blank line after declarations
136: FILE: drivers/gpio/gpio-xilinx.c:126:
+       void __iomem *addr = chip->regs + reg + xgpio_regoffset(chip, bit / 32);
+       xgpio_writereg(addr, xgpio_get_value32(a, bit));

Reviewed-by: Radhey Shyam Pandey <radhey.shyam.pandey@xilinx.com>
Signed-off-by: Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com>
---
v2: Update commit message

 drivers/gpio/gpio-xilinx.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Shubhrajyoti Datta June 21, 2022, 10:21 a.m. UTC | #1 
[AMD Official Use Only - General]



> -----Original Message-----
> From: Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com>
> Sent: Monday, May 2, 2022 4:31 PM
> To: linux-gpio@vger.kernel.org
> Cc: Michal Simek <michals@xilinx.com>; Srinivas Neeli <sneeli@xilinx.com>;
> linux-kernel@vger.kernel.org; git <git@xilinx.com>; Shubhrajyoti Datta
> <shubhraj@xilinx.com>
> Subject: [PATCH v2] gpio: xilinx: add missing blank line after declarations
> 
> Add a missing blank line. No functional changes.
> 
> WARNING: Missing a blank line after declarations
> 128: FILE: drivers/gpio/gpio-xilinx.c:120:
> +       void __iomem *addr = chip->regs + reg + xgpio_regoffset(chip, bit / 32);
> +       xgpio_set_value32(a, bit, xgpio_readreg(addr));
> 
> WARNING: Missing a blank line after declarations
> 136: FILE: drivers/gpio/gpio-xilinx.c:126:
> +       void __iomem *addr = chip->regs + reg + xgpio_regoffset(chip, bit / 32);
> +       xgpio_writereg(addr, xgpio_get_value32(a, bit));
> 
> Reviewed-by: Radhey Shyam Pandey <radhey.shyam.pandey@xilinx.com>
> Signed-off-by: Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com>
> ---
If there are no further comments can it be merged.
Michal Simek July 7, 2022, 1:12 p.m. UTC | #2 
On 5/2/22 13:00, Shubhrajyoti Datta wrote:
> Add a missing blank line. No functional changes.
> 
> WARNING: Missing a blank line after declarations
> 128: FILE: drivers/gpio/gpio-xilinx.c:120:
> +       void __iomem *addr = chip->regs + reg + xgpio_regoffset(chip, bit / 32);
> +       xgpio_set_value32(a, bit, xgpio_readreg(addr));
> 
> WARNING: Missing a blank line after declarations
> 136: FILE: drivers/gpio/gpio-xilinx.c:126:
> +       void __iomem *addr = chip->regs + reg + xgpio_regoffset(chip, bit / 32);
> +       xgpio_writereg(addr, xgpio_get_value32(a, bit));
> 
> Reviewed-by: Radhey Shyam Pandey <radhey.shyam.pandey@xilinx.com>
> Signed-off-by: Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com>
> ---
> v2: Update commit message
> 
>   drivers/gpio/gpio-xilinx.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/gpio/gpio-xilinx.c b/drivers/gpio/gpio-xilinx.c
> index b6d3a57e27ed..7f129e7eae78 100644
> --- a/drivers/gpio/gpio-xilinx.c
> +++ b/drivers/gpio/gpio-xilinx.c
> @@ -117,12 +117,14 @@ static inline int xgpio_regoffset(struct xgpio_instance *chip, int ch)
>   static void xgpio_read_ch(struct xgpio_instance *chip, int reg, int bit, unsigned long *a)
>   {
>   	void __iomem *addr = chip->regs + reg + xgpio_regoffset(chip, bit / 32);
> +
>   	xgpio_set_value32(a, bit, xgpio_readreg(addr));
>   }
>   
>   static void xgpio_write_ch(struct xgpio_instance *chip, int reg, int bit, unsigned long *a)
>   {
>   	void __iomem *addr = chip->regs + reg + xgpio_regoffset(chip, bit / 32);
> +
>   	xgpio_writereg(addr, xgpio_get_value32(a, bit));
>   }
>   


Fixes: 02b3f84d9080 ("gpio: xilinx: Switch to use bitmap APIs")

Reviewed-by: Michal Simek <michal.simek@amd.com>

Bartosz: Can you please apply it?

Thanks,
Michal
diff mbox series

Patch

diff --git a/drivers/gpio/gpio-xilinx.c b/drivers/gpio/gpio-xilinx.c
index b6d3a57e27ed..7f129e7eae78 100644
--- a/drivers/gpio/gpio-xilinx.c
+++ b/drivers/gpio/gpio-xilinx.c
@@ -117,12 +117,14 @@  static inline int xgpio_regoffset(struct xgpio_instance *chip, int ch)
 static void xgpio_read_ch(struct xgpio_instance *chip, int reg, int bit, unsigned long *a)
 {
 	void __iomem *addr = chip->regs + reg + xgpio_regoffset(chip, bit / 32);
+
 	xgpio_set_value32(a, bit, xgpio_readreg(addr));
 }
 
 static void xgpio_write_ch(struct xgpio_instance *chip, int reg, int bit, unsigned long *a)
 {
 	void __iomem *addr = chip->regs + reg + xgpio_regoffset(chip, bit / 32);
+
 	xgpio_writereg(addr, xgpio_get_value32(a, bit));
 }