diff mbox series

[1/9] dt-bindings: arm: qcom: fix Alcatel OneTouch Idol 3 compatibles

Message ID 20220520123252.365762-1-krzysztof.kozlowski@linaro.org
State Accepted
Commit 944de5182f0269e72ffe0a8880c8dbeb30f473d8
Headers show
Series [1/9] dt-bindings: arm: qcom: fix Alcatel OneTouch Idol 3 compatibles | expand

Commit Message

Krzysztof Kozlowski May 20, 2022, 12:32 p.m. UTC
The MSM8916 Alcatel OneTouch Idol 3 does not use MTP fallbacks in
compatibles:

  msm8916-alcatel-idol347.dtb: /: compatible: 'oneOf' conditional failed, one must be fixed:
    ['alcatel,idol347', 'qcom,msm8916'] is too short

Reported-by: Rob Herring <robh@kernel.org>
Fixes: e9dd2f7204ed ("dt-bindings: arm: qcom: Document alcatel,idol347 board")
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 Documentation/devicetree/bindings/arm/qcom.yaml | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

Rob Herring May 26, 2022, 2:14 a.m. UTC | #1
On Fri, 20 May 2022 14:32:44 +0200, Krzysztof Kozlowski wrote:
> The MSM8916 Alcatel OneTouch Idol 3 does not use MTP fallbacks in
> compatibles:
> 
>   msm8916-alcatel-idol347.dtb: /: compatible: 'oneOf' conditional failed, one must be fixed:
>     ['alcatel,idol347', 'qcom,msm8916'] is too short
> 
> Reported-by: Rob Herring <robh@kernel.org>
> Fixes: e9dd2f7204ed ("dt-bindings: arm: qcom: Document alcatel,idol347 board")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
>  Documentation/devicetree/bindings/arm/qcom.yaml | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 

Acked-by: Rob Herring <robh@kernel.org>
Krzysztof Kozlowski June 21, 2022, 4:02 p.m. UTC | #2
On 20/05/2022 14:32, Krzysztof Kozlowski wrote:
> The MSM8916 Alcatel OneTouch Idol 3 does not use MTP fallbacks in
> compatibles:
> 
>   msm8916-alcatel-idol347.dtb: /: compatible: 'oneOf' conditional failed, one must be fixed:
>     ['alcatel,idol347', 'qcom,msm8916'] is too short
> 
> Reported-by: Rob Herring <robh@kernel.org>
> Fixes: e9dd2f7204ed ("dt-bindings: arm: qcom: Document alcatel,idol347 board")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
>  Documentation/devicetree/bindings/arm/qcom.yaml | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 

I pinged about the patchset two weeks ago. There were no responses, but
this one here is actually a fix.  Others document missing stuff, which
although is not a fix, but still necessary to reduce amount of dtbs
check warnings.

Shall I treat the silence as this won't be picked up? I can take it
instead, but it will create some conflicts because several people are
doing similar as here...

Best regards,
Krzysztof
Krzysztof Kozlowski June 22, 2022, 8:25 a.m. UTC | #3
On Fri, 20 May 2022 14:32:44 +0200, Krzysztof Kozlowski wrote:
> The MSM8916 Alcatel OneTouch Idol 3 does not use MTP fallbacks in
> compatibles:
> 
>   msm8916-alcatel-idol347.dtb: /: compatible: 'oneOf' conditional failed, one must be fixed:
>     ['alcatel,idol347', 'qcom,msm8916'] is too short
> 
> 
> [...]

Applied, thanks!

[1/9] dt-bindings: arm: qcom: fix Alcatel OneTouch Idol 3 compatibles
      https://git.kernel.org/krzk/linux-dt/c/5c7b9a89c60ce728f61ecd8f2ae043deceb1fe66
[2/9] dt-bindings: arm: qcom: fix Longcheer L8150 compatibles
      https://git.kernel.org/krzk/linux-dt/c/0c8195fca687db26cd00df27c9df1830bddf72b0
[3/9] dt-bindings: arm: qcom: fix MSM8916 MTP compatibles
      https://git.kernel.org/krzk/linux-dt/c/4de2601759e545625413284051e32124df3cbad4
[4/9] dt-bindings: arm: qcom: fix MSM8994 boards compatibles
      https://git.kernel.org/krzk/linux-dt/c/317e5467957b1f69df2235f247ffdabbc85dd01b
[5/9] dt-bindings: arm: qcom: add missing MSM8916 board compatibles
      https://git.kernel.org/krzk/linux-dt/c/496bb1347265130412739e752db77349e35e2ec2
[6/9] dt-bindings: arm: qcom: add missing MSM8994 board compatibles
      https://git.kernel.org/krzk/linux-dt/c/215ad5a02e6c60fef7460c6936bf9996989f4969
[7/9] dt-bindings: arm: qcom: add missing SM8150 board compatibles
      https://git.kernel.org/krzk/linux-dt/c/4c74aef40300efb7e3cb7fcae62969ac63d349bc
[8/9] dt-bindings: arm: qcom: add missing SM8250 board compatibles
      https://git.kernel.org/krzk/linux-dt/c/197b6d70cf9e166e93450c155ceac6cc63ee908b
[9/9] dt-bindings: arm: qcom: add missing SM8350 board compatibles
      https://git.kernel.org/krzk/linux-dt/c/33a34cefdfaab7410cb5e280ae8e4318e3d79e8a

Best regards,
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
index 5c06d1bfc046..b7dd61df7ec0 100644
--- a/Documentation/devicetree/bindings/arm/qcom.yaml
+++ b/Documentation/devicetree/bindings/arm/qcom.yaml
@@ -153,14 +153,13 @@  properties:
           - const: qcom,msm8974
 
       - items:
-          - enum:
-              - alcatel,idol347
           - const: qcom,msm8916-mtp/1
           - const: qcom,msm8916-mtp
           - const: qcom,msm8916
 
       - items:
           - enum:
+              - alcatel,idol347
               - longcheer,l8150
               - samsung,a3u-eur
               - samsung,a5u-eur