| Message ID | 20220608112702.80873-1-krzysztof.kozlowski@linaro.org |
|---|---|
| State | Accepted |
| Commit | f16d37056be2feeae0680b3675b95ae876ab8c5c |
| Headers | show |
| Series | [1/2] dt-bindings: thermal: qcom,spmi-temp-alarm: convert to dtschema | expand |
On 08/06/2022 15:45, Rob Herring wrote: > On Wed, 08 Jun 2022 13:27:01 +0200, Krzysztof Kozlowski wrote: >> Convert the Qualcomm QPNP PMIC Temperature Alarm to DT Schema. >> >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >> --- >> .../thermal/qcom,spmi-temp-alarm.yaml | 85 +++++++++++++++++++ >> .../bindings/thermal/qcom-spmi-temp-alarm.txt | 51 ----------- >> 2 files changed, 85 insertions(+), 51 deletions(-) >> create mode 100644 Documentation/devicetree/bindings/thermal/qcom,spmi-temp-alarm.yaml >> delete mode 100644 Documentation/devicetree/bindings/thermal/qcom-spmi-temp-alarm.txt >> > > Running 'make dtbs_check' with the schema in this patch gives the > following warnings. Consider if they are expected or the schema is > incorrect. These may not be new warnings. > > Note that it is not yet a requirement to have 0 warnings for dtbs_check. > This will change in the future. > > Full log is available here: https://patchwork.ozlabs.org/patch/ > > > temp-alarm@2400: '#thermal-sensor-cells' is a required property I should have ordered the patches differently. This is fixed in second patch. Best regards, Krzysztof
On 08/06/2022 13:27, Krzysztof Kozlowski wrote: > Convert the Qualcomm QPNP PMIC Temperature Alarm to DT Schema. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- > .../thermal/qcom,spmi-temp-alarm.yaml | 85 +++++++++++++++++++ > .../bindings/thermal/qcom-spmi-temp-alarm.txt | 51 ----------- > 2 files changed, 85 insertions(+), 51 deletions(-) > create mode 100644 Documentation/devicetree/bindings/thermal/qcom,spmi-temp-alarm.yaml > delete mode 100644 Documentation/devicetree/bindings/thermal/qcom-spmi-temp-alarm.txt Applied this patch. I can pick patch 2/2 if needed, just let me know
On 14/06/2022 21:17, Krzysztof Kozlowski wrote: > On 14/06/2022 12:01, Daniel Lezcano wrote: >> On 08/06/2022 13:27, Krzysztof Kozlowski wrote: >>> Convert the Qualcomm QPNP PMIC Temperature Alarm to DT Schema. >>> >>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >>> --- >>> .../thermal/qcom,spmi-temp-alarm.yaml | 85 +++++++++++++++++++ >>> .../bindings/thermal/qcom-spmi-temp-alarm.txt | 51 ----------- >>> 2 files changed, 85 insertions(+), 51 deletions(-) >>> create mode 100644 Documentation/devicetree/bindings/thermal/qcom,spmi-temp-alarm.yaml >>> delete mode 100644 Documentation/devicetree/bindings/thermal/qcom-spmi-temp-alarm.txt >> >> Applied this patch. >> >> I can pick patch 2/2 if needed, just let me know > > Thanks Daniel. I guess Bjorn will pick up the DTS patch. Ok, thanks
diff --git a/Documentation/devicetree/bindings/thermal/qcom,spmi-temp-alarm.yaml b/Documentation/devicetree/bindings/thermal/qcom,spmi-temp-alarm.yaml new file mode 100644 index 000000000000..5f08b6e59b8a --- /dev/null +++ b/Documentation/devicetree/bindings/thermal/qcom,spmi-temp-alarm.yaml @@ -0,0 +1,85 @@ +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/thermal/qcom,spmi-temp-alarm.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Qualcomm QPNP PMIC Temperature Alarm + +maintainers: + - Bjorn Andersson <bjorn.andersson@linaro.org> + +description: + QPNP temperature alarm peripherals are found inside of Qualcomm PMIC chips + that utilize the Qualcomm SPMI implementation. These peripherals provide an + interrupt signal and status register to identify high PMIC die temperature. + +allOf: + - $ref: thermal-sensor.yaml# + +properties: + compatible: + const: qcom,spmi-temp-alarm + + reg: + maxItems: 1 + + interrupts: + maxItems: 1 + + io-channels: + items: + - description: ADC channel, which reports chip die temperature + + io-channel-names: + items: + - const: thermal + + '#thermal-sensor-cells': + const: 0 + +required: + - compatible + - reg + - interrupts + - '#thermal-sensor-cells' + +additionalProperties: false + +examples: + - | + #include <dt-bindings/interrupt-controller/arm-gic.h> + + pmic { + #address-cells = <1>; + #size-cells = <0>; + + pm8350_temp_alarm: temperature-sensor@a00 { + compatible = "qcom,spmi-temp-alarm"; + reg = <0xa00>; + interrupts = <0x1 0xa 0x0 IRQ_TYPE_EDGE_BOTH>; + #thermal-sensor-cells = <0>; + }; + }; + + thermal-zones { + pm8350_thermal: pm8350c-thermal { + polling-delay-passive = <100>; + polling-delay = <0>; + thermal-sensors = <&pm8350_temp_alarm>; + + trips { + pm8350_trip0: trip0 { + temperature = <95000>; + hysteresis = <0>; + type = "passive"; + }; + + pm8350_crit: pm8350c-crit { + temperature = <115000>; + hysteresis = <0>; + type = "critical"; + }; + }; + }; + }; diff --git a/Documentation/devicetree/bindings/thermal/qcom-spmi-temp-alarm.txt b/Documentation/devicetree/bindings/thermal/qcom-spmi-temp-alarm.txt deleted file mode 100644 index 2d5b2ad03314..000000000000 --- a/Documentation/devicetree/bindings/thermal/qcom-spmi-temp-alarm.txt +++ /dev/null @@ -1,51 +0,0 @@ -Qualcomm QPNP PMIC Temperature Alarm - -QPNP temperature alarm peripherals are found inside of Qualcomm PMIC chips -that utilize the Qualcomm SPMI implementation. These peripherals provide an -interrupt signal and status register to identify high PMIC die temperature. - -Required properties: -- compatible: Should contain "qcom,spmi-temp-alarm". -- reg: Specifies the SPMI address. -- interrupts: PMIC temperature alarm interrupt. -- #thermal-sensor-cells: Should be 0. See Documentation/devicetree/bindings/thermal/thermal-sensor.yaml for a description. - -Optional properties: -- io-channels: Should contain IIO channel specifier for the ADC channel, - which report chip die temperature. -- io-channel-names: Should contain "thermal". - -Example: - - pm8941_temp: thermal-alarm@2400 { - compatible = "qcom,spmi-temp-alarm"; - reg = <0x2400>; - interrupts = <0 0x24 0 IRQ_TYPE_EDGE_RISING>; - #thermal-sensor-cells = <0>; - - io-channels = <&pm8941_vadc VADC_DIE_TEMP>; - io-channel-names = "thermal"; - }; - - thermal-zones { - pm8941 { - polling-delay-passive = <250>; - polling-delay = <1000>; - - thermal-sensors = <&pm8941_temp>; - - trips { - stage1 { - temperature = <105000>; - hysteresis = <2000>; - type = "passive"; - }; - stage2 { - temperature = <125000>; - hysteresis = <2000>; - type = "critical"; - }; - }; - }; - }; -
Convert the Qualcomm QPNP PMIC Temperature Alarm to DT Schema. Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- .../thermal/qcom,spmi-temp-alarm.yaml | 85 +++++++++++++++++++ .../bindings/thermal/qcom-spmi-temp-alarm.txt | 51 ----------- 2 files changed, 85 insertions(+), 51 deletions(-) create mode 100644 Documentation/devicetree/bindings/thermal/qcom,spmi-temp-alarm.yaml delete mode 100644 Documentation/devicetree/bindings/thermal/qcom-spmi-temp-alarm.txt